Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-14 Thread Vivek Goyal
On Fri, Jun 07, 2013 at 06:55:58PM +0200, Michael Holzheu wrote: [..] > /* > - * Create kdump ELF core header in new kernel, if it has not been passed via > - * the "elfcorehdr" kernel parameter > + * Free ELF core header (new kernel) > */ > -static int setup_kdump_elfcorehdr(void) > +void

Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-14 Thread Vivek Goyal
On Fri, Jun 07, 2013 at 06:55:58PM +0200, Michael Holzheu wrote: [..] /* - * Create kdump ELF core header in new kernel, if it has not been passed via - * the elfcorehdr kernel parameter + * Free ELF core header (new kernel) */ -static int setup_kdump_elfcorehdr(void) +void

Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:36:57 +0900 HATAYAMA Daisuke wrote: > > -static int setup_kdump_elfcorehdr(void) > > +void elfcorehdr_free(void) > > { > > - size_t elfcorebuf_sz; > > - char *elfcorebuf; > > - > > - if (!OLDMEM_BASE || is_kdump_kernel()) > > - return

Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-10 Thread HATAYAMA Daisuke
2013/6/8 Michael Holzheu : > @@ -417,27 +416,44 @@ static void s390_elf_corehdr_create(char **elfcorebuf, > size_t *elfcorebuf_sz) > ptr = notes_init(phdr_notes, ptr, ((unsigned long) hdr) + hdr_off); > /* Init loads */ > hdr_off = PTR_DIFF(ptr, hdr); > -

Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-10 Thread HATAYAMA Daisuke
2013/6/8 Michael Holzheu holz...@linux.vnet.ibm.com: cut @@ -417,27 +416,44 @@ static void s390_elf_corehdr_create(char **elfcorebuf, size_t *elfcorebuf_sz) ptr = notes_init(phdr_notes, ptr, ((unsigned long) hdr) + hdr_off); /* Init loads */ hdr_off = PTR_DIFF(ptr,

Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:36:57 +0900 HATAYAMA Daisuke d.hatay...@gmail.com wrote: -static int setup_kdump_elfcorehdr(void) +void elfcorehdr_free(void) { - size_t elfcorebuf_sz; - char *elfcorebuf; - - if (!OLDMEM_BASE || is_kdump_kernel()) - return

[PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-07 Thread Michael Holzheu
This patch now exchanges the old relocate mechanism with the new arch function call override mechanism that allows to create the ELF core header in the 2nd kernel. Signed-off-by: Michael Holzheu --- arch/s390/kernel/crash_dump.c | 70 ++- 1 file changed,

[PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-07 Thread Michael Holzheu
This patch now exchanges the old relocate mechanism with the new arch function call override mechanism that allows to create the ELF core header in the 2nd kernel. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- arch/s390/kernel/crash_dump.c | 70