Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-25 Thread Mark Brown
On Wed, Apr 25, 2018 at 10:04:54AM -0500, Rob Herring wrote: > On Tue, Apr 24, 2018 at 11:49 AM, Srinivas Kandagatla > If you don't have the values, then how does one validate a DT is correct? > Honestly, a single property like this seems insufficient to describe > audio routing. It's perfectly

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-25 Thread Mark Brown
On Wed, Apr 25, 2018 at 10:04:54AM -0500, Rob Herring wrote: > On Tue, Apr 24, 2018 at 11:49 AM, Srinivas Kandagatla > If you don't have the values, then how does one validate a DT is correct? > Honestly, a single property like this seems insufficient to describe > audio routing. It's perfectly

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-25 Thread Srinivas Kandagatla
On 25/04/18 16:04, Rob Herring wrote: I can list the values for the HDMI playback use-case, but the list would grow as we start adding wcd9335 codec support. If you don't have the values, then how does one validate a DT is correct? I can list all the sources and sinks wired on the board in

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-25 Thread Srinivas Kandagatla
On 25/04/18 16:04, Rob Herring wrote: I can list the values for the HDMI playback use-case, but the list would grow as we start adding wcd9335 codec support. If you don't have the values, then how does one validate a DT is correct? I can list all the sources and sinks wired on the board in

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-25 Thread Rob Herring
On Tue, Apr 24, 2018 at 11:49 AM, Srinivas Kandagatla wrote: > Thanks for the review. > > > On 24/04/18 17:25, Rob Herring wrote: >> >> On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org >> wrote: >>> >>> From: Srinivas Kandagatla

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-25 Thread Rob Herring
On Tue, Apr 24, 2018 at 11:49 AM, Srinivas Kandagatla wrote: > Thanks for the review. > > > On 24/04/18 17:25, Rob Herring wrote: >> >> On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org >> wrote: >>> >>> From: Srinivas Kandagatla >>> >>> Add devicetree bindings

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-24 Thread Srinivas Kandagatla
Thanks for the review. On 24/04/18 17:25, Rob Herring wrote: On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla Add devicetree bindings documentation file for Qualcomm apq8096 sound card. Signed-off-by:

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-24 Thread Srinivas Kandagatla
Thanks for the review. On 24/04/18 17:25, Rob Herring wrote: On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla Add devicetree bindings documentation file for Qualcomm apq8096 sound card. Signed-off-by: Srinivas Kandagatla ---

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-24 Thread Rob Herring
On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > Add devicetree bindings documentation file for Qualcomm apq8096 sound card. > > Signed-off-by: Srinivas Kandagatla >

Re: [PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-24 Thread Rob Herring
On Wed, Apr 18, 2018 at 04:31:55PM +0100, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > Add devicetree bindings documentation file for Qualcomm apq8096 sound card. > > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/sound/qcom,apq8096.txt | 76 >

[PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-18 Thread srinivas . kandagatla
From: Srinivas Kandagatla Add devicetree bindings documentation file for Qualcomm apq8096 sound card. Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/sound/qcom,apq8096.txt | 76 ++ 1 file

[PATCH v5 21/23] ASoC: qdsp6: dt-bindings: Add apq8096 machine bindings

2018-04-18 Thread srinivas . kandagatla
From: Srinivas Kandagatla Add devicetree bindings documentation file for Qualcomm apq8096 sound card. Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/sound/qcom,apq8096.txt | 76 ++ 1 file changed, 76 insertions(+) create mode 100644