Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-14 Thread Andy Shevchenko
On Tue, Nov 13, 2018 at 10:40 PM Ayman Bagabas wrote: > > > > On Tue, Nov 13, 2018, 1:51 PM Andy Shevchenko > wrote: >> >> On Tue, Nov 13, 2018 at 7:32 PM Takashi Iwai wrote: >> > On Sun, 11 Nov 2018 20:02:45 +0100, >> > Ayman Bagabas wrote: >> >> >> > With that fix, >> > Reviewed-by: Takashi

Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-13 Thread Andy Shevchenko
On Tue, Nov 13, 2018 at 7:32 PM Takashi Iwai wrote: > On Sun, 11 Nov 2018 20:02:45 +0100, > Ayman Bagabas wrote: > With that fix, > Reviewed-by: Takashi Iwai Ayman, please, send next version with requested changes and appended tags. I will apply it. -- With Best Regards, Andy Shevchenko

Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-13 Thread Takashi Iwai
On Sun, 11 Nov 2018 20:02:45 +0100, Ayman Bagabas wrote: > > Some of Huawei laptops come with a LED in the micmute key. This patch > enables and disable this LED accordingly. disable what? > This enables micmute LED for: > 1. Matebook X (19e5:3200), (19e5:3201) > 2. Matebook X Pro (19e5:3204) >

[PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-11 Thread Ayman Bagabas
Some of Huawei laptops come with a LED in the micmute key. This patch enables and disable this LED accordingly. This enables micmute LED for: 1. Matebook X (19e5:3200), (19e5:3201) 2. Matebook X Pro (19e5:3204) Signed-off-by: Ayman Bagabas --- sound/pci/hda/huawei_wmi_helper.c | 47 +