Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

2021-03-21 Thread Fabio Estevam
Hi Alistair, On Mon, Mar 15, 2021 at 11:27 PM Alistair Francis wrote: > > The reMarkable2 (https://remarkable.com) is an e-ink tablet based on > the imx7d SoC. > > This commit is based on the DTS provide by reMarkable but ported to the > latest kernel (instead of 4.14). I have removed references

Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

2021-03-20 Thread Alistair Francis
On Fri, Mar 19, 2021 at 9:06 AM Marco Felsch wrote: > > Hi Alistair, > > the patch looks quite good only a few notes inline. > > PS: It would be cool to have a log to previous patch versions. I'm not sure how I could add that, I will add a changelog for this version though. > > On 21-03-15

Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

2021-03-19 Thread Marco Felsch
Hi Alistair, the patch looks quite good only a few notes inline. PS: It would be cool to have a log to previous patch versions. On 21-03-15 22:27, Alistair Francis wrote: ... > + { > + status = "disabled"; > +}; Why do you disable the crypto subsystem? > +_apbh { > + status =

[PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

2021-03-15 Thread Alistair Francis
The reMarkable2 (https://remarkable.com) is an e-ink tablet based on the imx7d SoC. This commit is based on the DTS provide by reMarkable but ported to the latest kernel (instead of 4.14). I have removed references to non-upstream devices and have changed the UART so that the console can be