Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-11-05 Thread Jianxin Pan
On 2018/11/5 17:46, jbru...@baylibre.com wrote: > On Sun, 2018-11-04 at 02:01 +0800, Jianxin Pan wrote: >> Hi Jerome, >> >> Thanks for the review, we really appreciate your time. >> >> I'm very sorry maybe I don't catch all your meaning very well. >> >> Please see my comments below. >> >> On 2018/

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-11-05 Thread jbrunet
On Sun, 2018-11-04 at 02:01 +0800, Jianxin Pan wrote: > Hi Jerome, > > Thanks for the review, we really appreciate your time. > > I'm very sorry maybe I don't catch all your meaning very well. > > Please see my comments below. > > On 2018/10/29 3:16, Jerome Brunet wrote: > > On Thu, 2018-10-25

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-11-03 Thread Jianxin Pan
Hi Jerome, Thanks for the review, we really appreciate your time. I'm very sorry maybe I don't catch all your meaning very well. Please see my comments below. On 2018/10/29 3:16, Jerome Brunet wrote: > On Thu, 2018-10-25 at 22:58 +0200, Martin Blumenstingl wrote: >> Hi Jerome, >> >> On Thu, Oc

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-30 Thread Jianxin Pan
Hi Jerome, On 2018/10/29 3:16, Jerome Brunet wrote: > On Thu, 2018-10-25 at 22:58 +0200, Martin Blumenstingl wrote: >> Hi Jerome, >> >> On Thu, Oct 25, 2018 at 2:54 PM Jerome Brunet wrote: >> [snip] >> +static void clk_regmap_div_init(struct clk_hw *hw) >> +{ >> + struct clk_regmap *c

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-29 Thread Martin Blumenstingl
Hi Jerome, many thanks for the whole explanation! On Sun, Oct 28, 2018 at 8:16 PM Jerome Brunet wrote: > > On Thu, 2018-10-25 at 22:58 +0200, Martin Blumenstingl wrote: > > Hi Jerome, > > > > On Thu, Oct 25, 2018 at 2:54 PM Jerome Brunet wrote: > > [snip] > > > > > > +static void clk_regmap_div

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-28 Thread Jerome Brunet
On Thu, 2018-10-25 at 22:58 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Thu, Oct 25, 2018 at 2:54 PM Jerome Brunet wrote: > [snip] > > > > > +static void clk_regmap_div_init(struct clk_hw *hw) > > > > > +{ > > > > > + struct clk_regmap *clk = to_clk_regmap(hw); > > > > > + struct clk_re

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-28 Thread Jianxin Pan
Hi Jerome, On 2018/10/25 20:54, Jerome Brunet wrote: > On Thu, 2018-10-25 at 19:48 +0800, Jianxin Pan wrote: >> Hi Jerome, >> >> On 2018/10/24 17:01, Jerome Brunet wrote: >>> On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: From: Yixun Lan The patch will add a MMC clock contro

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-25 Thread Martin Blumenstingl
Hi Jerome, On Thu, Oct 25, 2018 at 2:54 PM Jerome Brunet wrote: [snip] > > > > +static void clk_regmap_div_init(struct clk_hw *hw) > > > > +{ > > > > + struct clk_regmap *clk = to_clk_regmap(hw); > > > > + struct clk_regmap_div_data *div = clk_get_regmap_div_data(clk); > > > > + unsigned int val;

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-25 Thread Jerome Brunet
On Thu, 2018-10-25 at 19:48 +0800, Jianxin Pan wrote: > Hi Jerome, > > On 2018/10/24 17:01, Jerome Brunet wrote: > > On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > > > From: Yixun Lan > > > > > > The patch will add a MMC clock controller driver which used by MMC or > > > NAND, > > > It

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-25 Thread Jianxin Pan
Hi Jerome, On 2018/10/24 17:01, Jerome Brunet wrote: > On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: >> From: Yixun Lan >> >> The patch will add a MMC clock controller driver which used by MMC or NAND, >> It provide a mux and divider clock, and three phase clocks - core, tx, tx. >> [...]

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-24 Thread Jerome Brunet
On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > From: Yixun Lan > > The patch will add a MMC clock controller driver which used by MMC or NAND, > It provide a mux and divider clock, and three phase clocks - core, tx, tx. > > Two clocks are provided as the parent of MMC clock controller f

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-24 Thread Jerome Brunet
On Fri, 2018-10-19 at 11:03 -0700, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-19 09:12:53) > > On 2018/10/19 1:13, Stephen Boyd wrote: > > > Quoting Jianxin Pan (2018-10-17 22:07:25) > > > > diff --git a/drivers/clk/meson/clk-regmap.c > > > > b/drivers/clk/meson/clk-regmap.c > > > > index

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-24 Thread Jianxin Pan
On 2018/10/24 16:47, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-23 23:29:24) >> On 2018/10/19 1:13, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:25) >> [...] diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c new file mode 100644 index 0

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-24 Thread Stephen Boyd
Quoting Jianxin Pan (2018-10-23 23:29:24) > On 2018/10/19 1:13, Stephen Boyd wrote: > > Quoting Jianxin Pan (2018-10-17 22:07:25) > [...] > >> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c > >> new file mode 100644 > >> index 000..e3f > >> --- /dev/null > >> +++ b

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-23 Thread Jianxin Pan
On 2018/10/19 1:13, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-17 22:07:25) [...] >> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c >> new file mode 100644 >> index 000..e3f >> --- /dev/null >> +++ b/drivers/clk/meson/mmc-clkc.c >> @@ -0,0 +1,296 @@ >> +//

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-21 Thread Jianxin Pan
On 2018/10/20 2:03, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-19 09:12:53) >> On 2018/10/19 1:13, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:25) diff --git a/drivers/clk/meson/clk-regmap.c b/drivers/clk/meson/clk-regmap.c index 305ee30..f96314d 100644 >>>

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-19 Thread Stephen Boyd
Quoting Jianxin Pan (2018-10-19 09:12:53) > On 2018/10/19 1:13, Stephen Boyd wrote: > > Quoting Jianxin Pan (2018-10-17 22:07:25) > >> diff --git a/drivers/clk/meson/clk-regmap.c > >> b/drivers/clk/meson/clk-regmap.c > >> index 305ee30..f96314d 100644 > >> --- a/drivers/clk/meson/clk-regmap.c > >>

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-19 Thread Jianxin Pan
On 2018/10/19 1:13, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-17 22:07:25) >> diff --git a/drivers/clk/meson/clk-regmap.c b/drivers/clk/meson/clk-regmap.c >> index 305ee30..f96314d 100644 >> --- a/drivers/clk/meson/clk-regmap.c >> +++ b/drivers/clk/meson/clk-regmap.c >> @@ -113,8 +113,25 @

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-18 Thread Stephen Boyd
Quoting Jianxin Pan (2018-10-17 22:07:25) > diff --git a/drivers/clk/meson/clk-regmap.c b/drivers/clk/meson/clk-regmap.c > index 305ee30..f96314d 100644 > --- a/drivers/clk/meson/clk-regmap.c > +++ b/drivers/clk/meson/clk-regmap.c > @@ -113,8 +113,25 @@ static int clk_regmap_div_set_rate(struct clk

[PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-17 Thread Jianxin Pan
From: Yixun Lan The patch will add a MMC clock controller driver which used by MMC or NAND, It provide a mux and divider clock, and three phase clocks - core, tx, tx. Two clocks are provided as the parent of MMC clock controller from upper layer clock controller - eg "amlogic,axg-clkc" in AXG pl