RE: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... [Snip] > > > Btw how and when does DMA stop, assuming it is circular it never > > > would, isn't there a valid/stop flag associated with a descriptor > > > which tells DMA engine what to do next > > > > There are two registers that controls the

RE: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... [Snip] > > > Btw how and when does DMA stop, assuming it is circular it never > > > would, isn't there a valid/stop flag associated with a descriptor > > > which tells DMA engine what to do next > > > > There are two registers that controls the

Re: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Vinod Koul
On Fri, Jan 13, 2017 at 06:00:44AM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > Thanks for the review... > > [Snip] > > > > > > > On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > > > > > When driver is handling AXI DMA SoftIP When user submits

Re: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Vinod Koul
On Fri, Jan 13, 2017 at 06:00:44AM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > Thanks for the review... > > [Snip] > > > > > > > On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > > > > > When driver is handling AXI DMA SoftIP When user submits

RE: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... [Snip] > > > > > On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > > > > When driver is handling AXI DMA SoftIP When user submits multiple > > > > descriptors back to back on the S2MM(recv) side with the current > > > > driver

RE: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... [Snip] > > > > > On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > > > > When driver is handling AXI DMA SoftIP When user submits multiple > > > > descriptors back to back on the S2MM(recv) side with the current > > > > driver

Re: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Vinod Koul
On Thu, Jan 12, 2017 at 02:19:49PM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > Thanks for the review... > > > On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > > > When driver is handling AXI DMA SoftIP When user submits multiple > > > descriptors

Re: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Vinod Koul
On Thu, Jan 12, 2017 at 02:19:49PM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > Thanks for the review... > > > On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > > > When driver is handling AXI DMA SoftIP When user submits multiple > > > descriptors

RE: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > > When driver is handling AXI DMA SoftIP When user submits multiple > > descriptors back to back on the S2MM(recv) side with the current > > driver flow the last buffer

RE: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-12 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > > When driver is handling AXI DMA SoftIP When user submits multiple > > descriptors back to back on the S2MM(recv) side with the current > > driver flow the last buffer

Re: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-10 Thread Vinod Koul
On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > When driver is handling AXI DMA SoftIP > When user submits multiple descriptors back to back on the S2MM(recv) > side with the current driver flow the last buffer descriptor next bd > points to a invalid location resulting

Re: [PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-10 Thread Vinod Koul
On Sat, Jan 07, 2017 at 12:15:30PM +0530, Kedareswara rao Appana wrote: > When driver is handling AXI DMA SoftIP > When user submits multiple descriptors back to back on the S2MM(recv) > side with the current driver flow the last buffer descriptor next bd > points to a invalid location resulting

[PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-06 Thread Kedareswara rao Appana
When driver is handling AXI DMA SoftIP When user submits multiple descriptors back to back on the S2MM(recv) side with the current driver flow the last buffer descriptor next bd points to a invalid location resulting the invalid data or errors in the DMA engine. This patch fixes this issue by

[PATCH v5 3/3] dmaengine: xilinx_dma: Fix race condition in the driver for multiple descriptor scenario

2017-01-06 Thread Kedareswara rao Appana
When driver is handling AXI DMA SoftIP When user submits multiple descriptors back to back on the S2MM(recv) side with the current driver flow the last buffer descriptor next bd points to a invalid location resulting the invalid data or errors in the DMA engine. This patch fixes this issue by