Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind

2016-05-27 Thread Jiri Olsa
On Fri, May 27, 2016 at 04:02:59PM +0800, Hekuang wrote: SNIP > > > The only concern is that, if later we support more platforms, > > > there will be too much files named as > > > 'tools/perf/util/unwind-libunwind*.c' > > > Is it acceptable or not? > > > > > > And I thought all files belongs to

Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind

2016-05-27 Thread Hekuang
在 2016/5/27 15:38, Jiri Olsa 写道: On Fri, May 27, 2016 at 03:13:04PM +0800, Hekuang wrote: SNIP - I understand we need to compile 3 objects from unwind-libunwind.c, how about we create 3 files like: util/unwind-libunwind-local.c util/unwind-libunwind-x86_32.c util

Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind

2016-05-27 Thread Jiri Olsa
On Fri, May 27, 2016 at 03:13:04PM +0800, Hekuang wrote: SNIP > >- I understand we need to compile 3 objects from unwind-libunwind.c, > > how about we create 3 files like: > > > > util/unwind-libunwind-local.c > > util/unwind-libunwind-x86_32.c > > util/unwind-libunwind-a

Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind

2016-05-27 Thread Hekuang
hi 在 2016/5/27 1:42, Jiri Olsa 写道: On Tue, May 24, 2016 at 09:20:27AM +, He Kuang wrote: Use thread specific unwind ops to unwind cross-platform callchains. Currently, unwind methods is suitable for local unwind, this patch changes the fixed methods to thread/map related. Each time a map i

Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind

2016-05-26 Thread Jiri Olsa
On Tue, May 24, 2016 at 09:20:27AM +, He Kuang wrote: > Use thread specific unwind ops to unwind cross-platform callchains. > > Currently, unwind methods is suitable for local unwind, this patch > changes the fixed methods to thread/map related. Each time a map is > inserted, we find the targe

Re: [PATCH v5 3/5] perf callchain: Add support for cross-platform unwind

2016-05-26 Thread Jiri Olsa
On Tue, May 24, 2016 at 09:20:27AM +, He Kuang wrote: > Use thread specific unwind ops to unwind cross-platform callchains. > > Currently, unwind methods is suitable for local unwind, this patch > changes the fixed methods to thread/map related. Each time a map is > inserted, we find the targe

[PATCH v5 3/5] perf callchain: Add support for cross-platform unwind

2016-05-24 Thread He Kuang
Use thread specific unwind ops to unwind cross-platform callchains. Currently, unwind methods is suitable for local unwind, this patch changes the fixed methods to thread/map related. Each time a map is inserted, we find the target arch and see if this platform can be remote unwind. We test for x8