Re: [PATCH v5 4/5] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-06 Thread Chanwoo Choi
Hi, I have a question. In this patch, the compatible name includes the specific h/w board name(TM2). Usually, when developing the device driver, we prefer to use the original h/w name of each device. - "samsung,tm2-touchkey" If this touchkey device is used on other h/w board, you should add new

Re: [PATCH v5 4/5] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-06 Thread Chanwoo Choi
Hi, I have a question. In this patch, the compatible name includes the specific h/w board name(TM2). Usually, when developing the device driver, we prefer to use the original h/w name of each device. - "samsung,tm2-touchkey" If this touchkey device is used on other h/w board, you should add new

[PATCH v5 4/5] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-06 Thread Andi Shyti
From: Jaechul Lee This patch adds support for the TM2 touch key and led functionality. The driver interfaces with userspace through an input device and reports KEY_PHONE and KEY_BACK event types. LED brightness can be controlled by

[PATCH v5 4/5] input: tm2-touchkey: Add touchkey driver support for TM2

2017-01-06 Thread Andi Shyti
From: Jaechul Lee This patch adds support for the TM2 touch key and led functionality. The driver interfaces with userspace through an input device and reports KEY_PHONE and KEY_BACK event types. LED brightness can be controlled by "/sys/class/leds/tm2-touchkey/brightness". Signed-off-by: