Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-08-25 Thread Mark Brown
On Sat, Aug 08, 2015 at 04:35:41PM +0100, Russell King - ARM Linux wrote: > On Sat, Jun 20, 2015 at 12:28:15AM +0800, Yakir Yang wrote: > > Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card > > driver could connect to this codec through the codec dai name > > "dw-hdmi-i2s-audio". > I'm

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-08-25 Thread Mark Brown
On Sat, Aug 08, 2015 at 04:35:41PM +0100, Russell King - ARM Linux wrote: On Sat, Jun 20, 2015 at 12:28:15AM +0800, Yakir Yang wrote: Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card driver could connect to this codec through the codec dai name dw-hdmi-i2s-audio. I'm applying

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-08-08 Thread Russell King - ARM Linux
On Sat, Jun 20, 2015 at 12:28:15AM +0800, Yakir Yang wrote: > Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card > driver could connect to this codec through the codec dai name > "dw-hdmi-i2s-audio". I'm applying this patch to my tree with some changes. I haven't seen anyone ack it,

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-08-08 Thread Russell King - ARM Linux
On Sat, Jun 20, 2015 at 12:28:15AM +0800, Yakir Yang wrote: Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card driver could connect to this codec through the codec dai name dw-hdmi-i2s-audio. I'm applying this patch to my tree with some changes. I haven't seen anyone ack it, nor

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-22 Thread Yakir Yang
Russell, 在 2015/6/22 18:10, Russell King - ARM Linux 写道: On Mon, Jun 22, 2015 at 12:06:04PM +0200, Paul Bolle wrote: But I think there's no platform_device with a "dw-hdmi-i2s-audio" name. So I wonder whether this MODULE_ALIAS() is actually needed. What breaks if you leave it out? + }

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-22 Thread Yakir Yang
Paul, 在 2015/6/22 18:06, Paul Bolle 写道: Something I didn't notice in v4, sorry. On Sat, 2015-06-20 at 00:28 +0800, Yakir Yang wrote: --- /dev/null +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c +#define DRIVER_NAME "dw-hdmi-i2s-audio" +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME); 0)

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-22 Thread Russell King - ARM Linux
On Mon, Jun 22, 2015 at 12:06:04PM +0200, Paul Bolle wrote: > But I think there's no platform_device with a "dw-hdmi-i2s-audio" name. > So I wonder whether this MODULE_ALIAS() is actually needed. What breaks > if you leave it out? + } else if (hdmi_readb(hdmi, HDMI_CONFIG0_ID) &

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-22 Thread Paul Bolle
Something I didn't notice in v4, sorry. On Sat, 2015-06-20 at 00:28 +0800, Yakir Yang wrote: > --- /dev/null > +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c > +#define DRIVER_NAME "dw-hdmi-i2s-audio" > +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME); 0) Side note: this is the first time

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-22 Thread Paul Bolle
Something I didn't notice in v4, sorry. On Sat, 2015-06-20 at 00:28 +0800, Yakir Yang wrote: --- /dev/null +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c +#define DRIVER_NAME dw-hdmi-i2s-audio +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME); 0) Side note: this is the first time that

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-22 Thread Russell King - ARM Linux
On Mon, Jun 22, 2015 at 12:06:04PM +0200, Paul Bolle wrote: But I think there's no platform_device with a dw-hdmi-i2s-audio name. So I wonder whether this MODULE_ALIAS() is actually needed. What breaks if you leave it out? + } else if (hdmi_readb(hdmi, HDMI_CONFIG0_ID) HDMI_CONFIG0_I2S)

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-22 Thread Yakir Yang
Paul, 在 2015/6/22 18:06, Paul Bolle 写道: Something I didn't notice in v4, sorry. On Sat, 2015-06-20 at 00:28 +0800, Yakir Yang wrote: --- /dev/null +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c +#define DRIVER_NAME dw-hdmi-i2s-audio +MODULE_ALIAS(PLATFORM_MODULE_PREFIX DRIVER_NAME); 0)

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-22 Thread Yakir Yang
Russell, 在 2015/6/22 18:10, Russell King - ARM Linux 写道: On Mon, Jun 22, 2015 at 12:06:04PM +0200, Paul Bolle wrote: But I think there's no platform_device with a dw-hdmi-i2s-audio name. So I wonder whether this MODULE_ALIAS() is actually needed. What breaks if you leave it out? + }

[PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-19 Thread Yakir Yang
Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card driver could connect to this codec through the codec dai name "dw-hdmi-i2s-audio". Signed-off-by: Yakir Yang --- Changes in v5: - Take Mark Brown suggest that remove jack_status recorded, report jack status directly when hdmi plug

[PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

2015-06-19 Thread Yakir Yang
Add ALSA based HDMI I2S audio driver for dw_hdmi. Sound card driver could connect to this codec through the codec dai name dw-hdmi-i2s-audio. Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v5: - Take Mark Brown suggest that remove jack_status recorded, report jack status directly