Re: [PATCH v5 4/8] Watchdog: introdouce "pretimeout" into framework

2015-06-11 Thread Guenter Roeck
On Thu, Jun 11, 2015 at 07:22:44PM +0800, Fu Wei wrote: > Hi Guenter, > [ ... ] > > > value we are trying to set. Effectively the above accepts every pretimeout > > if wdd->pretimeout is 0. It also accepts every pretimeout if > > max_pretimeout == 0, even if wdd->timeout is set and t >=

Re: [PATCH v5 4/8] Watchdog: introdouce "pretimeout" into framework

2015-06-11 Thread Fu Wei
Hi Guenter, Great thanks for your time. On 11 June 2015 at 00:21, Guenter Roeck wrote: > On 06/10/2015 06:41 AM, fu@linaro.org wrote: >> >> From: Fu Wei >> >> Also update Documentation/watchdog/watchdog-kernel-api.txt to >> introduce: >> (1)the new elements in the watchdog_device and

Re: [PATCH v5 4/8] Watchdog: introdouce pretimeout into framework

2015-06-11 Thread Fu Wei
Hi Guenter, Great thanks for your time. On 11 June 2015 at 00:21, Guenter Roeck li...@roeck-us.net wrote: On 06/10/2015 06:41 AM, fu@linaro.org wrote: From: Fu Wei fu@linaro.org Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the

Re: [PATCH v5 4/8] Watchdog: introdouce pretimeout into framework

2015-06-11 Thread Guenter Roeck
On Thu, Jun 11, 2015 at 07:22:44PM +0800, Fu Wei wrote: Hi Guenter, [ ... ] value we are trying to set. Effectively the above accepts every pretimeout if wdd-pretimeout is 0. It also accepts every pretimeout if max_pretimeout == 0, even if wdd-timeout is set and t = wdd-timeout. Try

Re: [PATCH v5 4/8] Watchdog: introdouce "pretimeout" into framework

2015-06-10 Thread Guenter Roeck
On 06/10/2015 06:41 AM, fu@linaro.org wrote: From: Fu Wei Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API "watchdog_init_timeouts" Reasons: (1)kernel already has two watchdog

[PATCH v5 4/8] Watchdog: introdouce "pretimeout" into framework

2015-06-10 Thread fu . wei
From: Fu Wei Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API "watchdog_init_timeouts" Reasons: (1)kernel already has two watchdog drivers are using "pretimeout":

[PATCH v5 4/8] Watchdog: introdouce pretimeout into framework

2015-06-10 Thread fu . wei
From: Fu Wei fu@linaro.org Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API watchdog_init_timeouts Reasons: (1)kernel already has two watchdog drivers are using pretimeout:

Re: [PATCH v5 4/8] Watchdog: introdouce pretimeout into framework

2015-06-10 Thread Guenter Roeck
On 06/10/2015 06:41 AM, fu@linaro.org wrote: From: Fu Wei fu@linaro.org Also update Documentation/watchdog/watchdog-kernel-api.txt to introduce: (1)the new elements in the watchdog_device and watchdog_ops struct; (2)the new API watchdog_init_timeouts Reasons: (1)kernel already has two