Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Chen Zhong]

On Thu, 2018-03-29 at 09:15 -0700, Dmitry Torokhov wrote:
> 
> 
> Oh, sorry, I did not realize you wanted my Ack for bindings. I usually
> leave it to Rob and simply ack the driver itself when I am happy with
> the code.
> 
> I'll go and add my ack to the binding post if that will help merging
> the series.
> 
> Thanks. 

Hi Lee,

May I know if I need to collect Dmitry's comments and send a new version
for the merging?

Thank you.

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Chen Zhong]

On Thu, 2018-03-29 at 09:15 -0700, Dmitry Torokhov wrote:
> 
> 
> Oh, sorry, I did not realize you wanted my Ack for bindings. I usually
> leave it to Rob and simply ack the driver itself when I am happy with
> the code.
> 
> I'll go and add my ack to the binding post if that will help merging
> the series.
> 
> Thanks. 

Hi Lee,

May I know if I need to collect Dmitry's comments and send a new version
for the merging?

Thank you.

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Dmitry Torokhov]

On Thu, Mar 29, 2018 at 02:04:02PM +0100, Lee Jones wrote:
> On Thu, 29 Mar 2018, Chen Zhong wrote:
> 
> > On Wed, 2018-03-28 at 11:26 +0100, Lee Jones wrote:
> > > On Tue, 27 Mar 2018, Matthias Brugger wrote:
> > > 
> > > > 
> > > > 
> > > > On 03/27/2018 10:05 AM, Lee Jones wrote:
> > > > > On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> > > > >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> > > > >>> Hi, Dmitry and Lee
> > > > >>>
> > > > >>> The series seems not being got merged. Are they good enough to be 
> > > > >>> ready
> > > > >>> into the your tree?
> > > > >>>
> > > > >>> Recently I've tested the series with focusing on pwrkey event 
> > > > >>> generated
> > > > >>> through interrupt when push and release the key on bpi-r2 board and 
> > > > >>> then
> > > > >>> finally it's working fine. but for homekey it cannot be found on the
> > > > >>> board and thus I cannot have more tests more about it.
> > > > >>>
> > > > >>> Tested-by: Sean Wang 
> > > > >>
> > > > >> You have my Ack on the input patch; I expect it go through Lee's 
> > > > >> tree as
> > > > >> there are some dependencies on mfd core piece.
> > > > > 
> > > > > Are you happy for me to merge the Input dt-bindings without your Ack?
> > > > > 
> > > > 
> > > > They got both Acked in v5, but the commit message was not updated:
> > > > https://patchwork.kernel.org/patch/9973721/
> > > > https://patchwork.kernel.org/patch/9973723/
> > > 
> > > Thanks Matthias.
> > > 
> > > Chen, can you collect all the Acks and repost as a RESEND please?
> > > 
> > 
> > Thanks Matthias, Lee, Dmitry and Sean for your comments.
> > 
> > Hi Lee,
> > 
> > I have collected the Acks by Rob and sent the v6:
> > https://patchwork.kernel.org/patch/10026705
> > https://patchwork.kernel.org/patch/10026707
> > 
> > Are they enough to be merged?
> 
> Oh, I see.
> 
> I was asking about Dmitry's Ack.

Oh, sorry, I did not realize you wanted my Ack for bindings. I usually
leave it to Rob and simply ack the driver itself when I am happy with
the code.

I'll go and add my ack to the binding post if that will help merging
the series.

Thanks.

-- 
Dmitry

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Dmitry Torokhov]

On Thu, Mar 29, 2018 at 02:04:02PM +0100, Lee Jones wrote:
> On Thu, 29 Mar 2018, Chen Zhong wrote:
> 
> > On Wed, 2018-03-28 at 11:26 +0100, Lee Jones wrote:
> > > On Tue, 27 Mar 2018, Matthias Brugger wrote:
> > > 
> > > > 
> > > > 
> > > > On 03/27/2018 10:05 AM, Lee Jones wrote:
> > > > > On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> > > > >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> > > > >>> Hi, Dmitry and Lee
> > > > >>>
> > > > >>> The series seems not being got merged. Are they good enough to be 
> > > > >>> ready
> > > > >>> into the your tree?
> > > > >>>
> > > > >>> Recently I've tested the series with focusing on pwrkey event 
> > > > >>> generated
> > > > >>> through interrupt when push and release the key on bpi-r2 board and 
> > > > >>> then
> > > > >>> finally it's working fine. but for homekey it cannot be found on the
> > > > >>> board and thus I cannot have more tests more about it.
> > > > >>>
> > > > >>> Tested-by: Sean Wang 
> > > > >>
> > > > >> You have my Ack on the input patch; I expect it go through Lee's 
> > > > >> tree as
> > > > >> there are some dependencies on mfd core piece.
> > > > > 
> > > > > Are you happy for me to merge the Input dt-bindings without your Ack?
> > > > > 
> > > > 
> > > > They got both Acked in v5, but the commit message was not updated:
> > > > https://patchwork.kernel.org/patch/9973721/
> > > > https://patchwork.kernel.org/patch/9973723/
> > > 
> > > Thanks Matthias.
> > > 
> > > Chen, can you collect all the Acks and repost as a RESEND please?
> > > 
> > 
> > Thanks Matthias, Lee, Dmitry and Sean for your comments.
> > 
> > Hi Lee,
> > 
> > I have collected the Acks by Rob and sent the v6:
> > https://patchwork.kernel.org/patch/10026705
> > https://patchwork.kernel.org/patch/10026707
> > 
> > Are they enough to be merged?
> 
> Oh, I see.
> 
> I was asking about Dmitry's Ack.

Oh, sorry, I did not realize you wanted my Ack for bindings. I usually
leave it to Rob and simply ack the driver itself when I am happy with
the code.

I'll go and add my ack to the binding post if that will help merging
the series.

Thanks.

-- 
Dmitry

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Lee Jones]

On Thu, 29 Mar 2018, Chen Zhong wrote:

> On Wed, 2018-03-28 at 11:26 +0100, Lee Jones wrote:
> > On Tue, 27 Mar 2018, Matthias Brugger wrote:
> > 
> > > 
> > > 
> > > On 03/27/2018 10:05 AM, Lee Jones wrote:
> > > > On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> > > >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> > > >>> Hi, Dmitry and Lee
> > > >>>
> > > >>> The series seems not being got merged. Are they good enough to be 
> > > >>> ready
> > > >>> into the your tree?
> > > >>>
> > > >>> Recently I've tested the series with focusing on pwrkey event 
> > > >>> generated
> > > >>> through interrupt when push and release the key on bpi-r2 board and 
> > > >>> then
> > > >>> finally it's working fine. but for homekey it cannot be found on the
> > > >>> board and thus I cannot have more tests more about it.
> > > >>>
> > > >>> Tested-by: Sean Wang 
> > > >>
> > > >> You have my Ack on the input patch; I expect it go through Lee's tree 
> > > >> as
> > > >> there are some dependencies on mfd core piece.
> > > > 
> > > > Are you happy for me to merge the Input dt-bindings without your Ack?
> > > > 
> > > 
> > > They got both Acked in v5, but the commit message was not updated:
> > > https://patchwork.kernel.org/patch/9973721/
> > > https://patchwork.kernel.org/patch/9973723/
> > 
> > Thanks Matthias.
> > 
> > Chen, can you collect all the Acks and repost as a RESEND please?
> > 
> 
> Thanks Matthias, Lee, Dmitry and Sean for your comments.
> 
> Hi Lee,
> 
> I have collected the Acks by Rob and sent the v6:
> https://patchwork.kernel.org/patch/10026705
> https://patchwork.kernel.org/patch/10026707
> 
> Are they enough to be merged?

Oh, I see.

I was asking about Dmitry's Ack.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Lee Jones]

On Thu, 29 Mar 2018, Chen Zhong wrote:

> On Wed, 2018-03-28 at 11:26 +0100, Lee Jones wrote:
> > On Tue, 27 Mar 2018, Matthias Brugger wrote:
> > 
> > > 
> > > 
> > > On 03/27/2018 10:05 AM, Lee Jones wrote:
> > > > On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> > > >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> > > >>> Hi, Dmitry and Lee
> > > >>>
> > > >>> The series seems not being got merged. Are they good enough to be 
> > > >>> ready
> > > >>> into the your tree?
> > > >>>
> > > >>> Recently I've tested the series with focusing on pwrkey event 
> > > >>> generated
> > > >>> through interrupt when push and release the key on bpi-r2 board and 
> > > >>> then
> > > >>> finally it's working fine. but for homekey it cannot be found on the
> > > >>> board and thus I cannot have more tests more about it.
> > > >>>
> > > >>> Tested-by: Sean Wang 
> > > >>
> > > >> You have my Ack on the input patch; I expect it go through Lee's tree 
> > > >> as
> > > >> there are some dependencies on mfd core piece.
> > > > 
> > > > Are you happy for me to merge the Input dt-bindings without your Ack?
> > > > 
> > > 
> > > They got both Acked in v5, but the commit message was not updated:
> > > https://patchwork.kernel.org/patch/9973721/
> > > https://patchwork.kernel.org/patch/9973723/
> > 
> > Thanks Matthias.
> > 
> > Chen, can you collect all the Acks and repost as a RESEND please?
> > 
> 
> Thanks Matthias, Lee, Dmitry and Sean for your comments.
> 
> Hi Lee,
> 
> I have collected the Acks by Rob and sent the v6:
> https://patchwork.kernel.org/patch/10026705
> https://patchwork.kernel.org/patch/10026707
> 
> Are they enough to be merged?

Oh, I see.

I was asking about Dmitry's Ack.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Chen Zhong]

On Wed, 2018-03-28 at 11:26 +0100, Lee Jones wrote:
> On Tue, 27 Mar 2018, Matthias Brugger wrote:
> 
> > 
> > 
> > On 03/27/2018 10:05 AM, Lee Jones wrote:
> > > On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> > >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> > >>> Hi, Dmitry and Lee
> > >>>
> > >>> The series seems not being got merged. Are they good enough to be ready
> > >>> into the your tree?
> > >>>
> > >>> Recently I've tested the series with focusing on pwrkey event generated
> > >>> through interrupt when push and release the key on bpi-r2 board and then
> > >>> finally it's working fine. but for homekey it cannot be found on the
> > >>> board and thus I cannot have more tests more about it.
> > >>>
> > >>> Tested-by: Sean Wang 
> > >>
> > >> You have my Ack on the input patch; I expect it go through Lee's tree as
> > >> there are some dependencies on mfd core piece.
> > > 
> > > Are you happy for me to merge the Input dt-bindings without your Ack?
> > > 
> > 
> > They got both Acked in v5, but the commit message was not updated:
> > https://patchwork.kernel.org/patch/9973721/
> > https://patchwork.kernel.org/patch/9973723/
> 
> Thanks Matthias.
> 
> Chen, can you collect all the Acks and repost as a RESEND please?
> 

Thanks Matthias, Lee, Dmitry and Sean for your comments.

Hi Lee,

I have collected the Acks by Rob and sent the v6:
https://patchwork.kernel.org/patch/10026705
https://patchwork.kernel.org/patch/10026707

Are they enough to be merged?

Thank you.

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Chen Zhong]

On Wed, 2018-03-28 at 11:26 +0100, Lee Jones wrote:
> On Tue, 27 Mar 2018, Matthias Brugger wrote:
> 
> > 
> > 
> > On 03/27/2018 10:05 AM, Lee Jones wrote:
> > > On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> > >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> > >>> Hi, Dmitry and Lee
> > >>>
> > >>> The series seems not being got merged. Are they good enough to be ready
> > >>> into the your tree?
> > >>>
> > >>> Recently I've tested the series with focusing on pwrkey event generated
> > >>> through interrupt when push and release the key on bpi-r2 board and then
> > >>> finally it's working fine. but for homekey it cannot be found on the
> > >>> board and thus I cannot have more tests more about it.
> > >>>
> > >>> Tested-by: Sean Wang 
> > >>
> > >> You have my Ack on the input patch; I expect it go through Lee's tree as
> > >> there are some dependencies on mfd core piece.
> > > 
> > > Are you happy for me to merge the Input dt-bindings without your Ack?
> > > 
> > 
> > They got both Acked in v5, but the commit message was not updated:
> > https://patchwork.kernel.org/patch/9973721/
> > https://patchwork.kernel.org/patch/9973723/
> 
> Thanks Matthias.
> 
> Chen, can you collect all the Acks and repost as a RESEND please?
> 

Thanks Matthias, Lee, Dmitry and Sean for your comments.

Hi Lee,

I have collected the Acks by Rob and sent the v6:
https://patchwork.kernel.org/patch/10026705
https://patchwork.kernel.org/patch/10026707

Are they enough to be merged?

Thank you.

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Lee Jones]

On Tue, 27 Mar 2018, Matthias Brugger wrote:

> 
> 
> On 03/27/2018 10:05 AM, Lee Jones wrote:
> > On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> >>> Hi, Dmitry and Lee
> >>>
> >>> The series seems not being got merged. Are they good enough to be ready
> >>> into the your tree?
> >>>
> >>> Recently I've tested the series with focusing on pwrkey event generated
> >>> through interrupt when push and release the key on bpi-r2 board and then
> >>> finally it's working fine. but for homekey it cannot be found on the
> >>> board and thus I cannot have more tests more about it.
> >>>
> >>> Tested-by: Sean Wang 
> >>
> >> You have my Ack on the input patch; I expect it go through Lee's tree as
> >> there are some dependencies on mfd core piece.
> > 
> > Are you happy for me to merge the Input dt-bindings without your Ack?
> > 
> 
> They got both Acked in v5, but the commit message was not updated:
> https://patchwork.kernel.org/patch/9973721/
> https://patchwork.kernel.org/patch/9973723/

Thanks Matthias.

Chen, can you collect all the Acks and repost as a RESEND please?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Lee Jones]

On Tue, 27 Mar 2018, Matthias Brugger wrote:

> 
> 
> On 03/27/2018 10:05 AM, Lee Jones wrote:
> > On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> >>> Hi, Dmitry and Lee
> >>>
> >>> The series seems not being got merged. Are they good enough to be ready
> >>> into the your tree?
> >>>
> >>> Recently I've tested the series with focusing on pwrkey event generated
> >>> through interrupt when push and release the key on bpi-r2 board and then
> >>> finally it's working fine. but for homekey it cannot be found on the
> >>> board and thus I cannot have more tests more about it.
> >>>
> >>> Tested-by: Sean Wang 
> >>
> >> You have my Ack on the input patch; I expect it go through Lee's tree as
> >> there are some dependencies on mfd core piece.
> > 
> > Are you happy for me to merge the Input dt-bindings without your Ack?
> > 
> 
> They got both Acked in v5, but the commit message was not updated:
> https://patchwork.kernel.org/patch/9973721/
> https://patchwork.kernel.org/patch/9973723/

Thanks Matthias.

Chen, can you collect all the Acks and repost as a RESEND please?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Matthias Brugger]

On 03/27/2018 10:05 AM, Lee Jones wrote:
> On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
>> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
>>> Hi, Dmitry and Lee
>>>
>>> The series seems not being got merged. Are they good enough to be ready
>>> into the your tree?
>>>
>>> Recently I've tested the series with focusing on pwrkey event generated
>>> through interrupt when push and release the key on bpi-r2 board and then
>>> finally it's working fine. but for homekey it cannot be found on the
>>> board and thus I cannot have more tests more about it.
>>>
>>> Tested-by: Sean Wang 
>>
>> You have my Ack on the input patch; I expect it go through Lee's tree as
>> there are some dependencies on mfd core piece.
> 
> Are you happy for me to merge the Input dt-bindings without your Ack?
> 

They got both Acked in v5, but the commit message was not updated:
https://patchwork.kernel.org/patch/9973721/
https://patchwork.kernel.org/patch/9973723/

Regards,
Matthias

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Matthias Brugger]

On 03/27/2018 10:05 AM, Lee Jones wrote:
> On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
>> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
>>> Hi, Dmitry and Lee
>>>
>>> The series seems not being got merged. Are they good enough to be ready
>>> into the your tree?
>>>
>>> Recently I've tested the series with focusing on pwrkey event generated
>>> through interrupt when push and release the key on bpi-r2 board and then
>>> finally it's working fine. but for homekey it cannot be found on the
>>> board and thus I cannot have more tests more about it.
>>>
>>> Tested-by: Sean Wang 
>>
>> You have my Ack on the input patch; I expect it go through Lee's tree as
>> there are some dependencies on mfd core piece.
> 
> Are you happy for me to merge the Input dt-bindings without your Ack?
> 

They got both Acked in v5, but the commit message was not updated:
https://patchwork.kernel.org/patch/9973721/
https://patchwork.kernel.org/patch/9973723/

Regards,
Matthias

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Lee Jones]

On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> > Hi, Dmitry and Lee
> > 
> > The series seems not being got merged. Are they good enough to be ready
> > into the your tree?
> > 
> > Recently I've tested the series with focusing on pwrkey event generated
> > through interrupt when push and release the key on bpi-r2 board and then
> > finally it's working fine. but for homekey it cannot be found on the
> > board and thus I cannot have more tests more about it.
> > 
> > Tested-by: Sean Wang 
> 
> You have my Ack on the input patch; I expect it go through Lee's tree as
> there are some dependencies on mfd core piece.

Are you happy for me to merge the Input dt-bindings without your Ack?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Lee Jones]

On Fri, 23 Mar 2018, Dmitry Torokhov wrote:
> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> > Hi, Dmitry and Lee
> > 
> > The series seems not being got merged. Are they good enough to be ready
> > into the your tree?
> > 
> > Recently I've tested the series with focusing on pwrkey event generated
> > through interrupt when push and release the key on bpi-r2 board and then
> > finally it's working fine. but for homekey it cannot be found on the
> > board and thus I cannot have more tests more about it.
> > 
> > Tested-by: Sean Wang 
> 
> You have my Ack on the input patch; I expect it go through Lee's tree as
> there are some dependencies on mfd core piece.

Are you happy for me to merge the Input dt-bindings without your Ack?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Dmitry Torokhov]

Hi Sean,

On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> Hi, Dmitry and Lee
> 
> The series seems not being got merged. Are they good enough to be ready
> into the your tree?
> 
> Recently I've tested the series with focusing on pwrkey event generated
> through interrupt when push and release the key on bpi-r2 board and then
> finally it's working fine. but for homekey it cannot be found on the
> board and thus I cannot have more tests more about it.
> 
> Tested-by: Sean Wang <sean.w...@mediatek.com>

You have my Ack on the input patch; I expect it go through Lee's tree as
there are some dependencies on mfd core piece.

Thanks.

> 
>   Sean
> 
> 
> On Thu, 2018-03-22 at 10:03 +0800, Sean Wang (王志亘) wrote:
> > 
> > > -Original Message-
> > > From: Linux-mediatek [mailto:linux-mediatek-boun...@lists.infradead.org] 
> > > On
> > > Behalf Of Chen Zhong
> > > Sent: Wednesday, October 25, 2017 9:16 PM
> > > To: Dmitry Torokhov <dmitry.torok...@gmail.com>; Rob Herring
> > > <robh...@kernel.org>; Lee Jones <lee.jo...@linaro.org>; Alexandre Belloni
> > > <alexandre.bell...@free-electrons.com>
> > > Cc: Mark Rutland <mark.rutl...@arm.com>; Alessandro Zummo
> > > <a.zu...@towertech.it>; devicet...@vger.kernel.org; Linus Walleij
> > > <linus.wall...@linaro.org>; Jaechul Lee <jcsing@samsung.com>; linux-
> > > ker...@vger.kernel.org; Krzysztof Kozlowski <k...@kernel.org>; Javier
> > > Martinez Canillas <jav...@osg.samsung.com>; linux-
> > > media...@lists.infradead.org; linux-arm-ker...@lists.infradead.org; linux-
> > > in...@vger.kernel.org; Matthias Brugger <matthias@gmail.com>; Eddie
> > > Huang (S智) <eddie.hu...@mediatek.com>; Chen Zhong (钟辰)
> > > <chen.zh...@mediatek.com>; Beomho Seo <beomho@samsung.com>;
> > > linux-...@vger.kernel.org
> > > Subject: [PATCH v6 0/6] Add MediaTek PMIC keys support
> > > 
> > > MediaTek PMIC are multi-function devices that can handle key interrupts,
> > > typically there are two keys attached to PMIC, which called pwrkey and
> > > homekey. PWRKEY usually used to wake up system from sleep. Homekey can
> > > used as volume down key due to board design. Long press keys can shutdown
> > > PMIC, the mode can be choose to be one key only or two keys together.
> > > This series add support for key functions for MediaTek PMIC MT6397/MT6323.
> > > 
> > > Changes since v5:
> > > - use __maybe_unused annotation instead of #ifdef guard
> > > - use of_* API instead of device_* API
> > > 
> > > Changes since v4:
> > > - rebase to Linux 4.14-rc1
> > > - add a common keyboard binding document
> > > - use child device tree node to define each key
> > > 
> > > Changes since v3:
> > > - make the naming to be consistent as mtk_pmic or MTK_PMIC
> > > - add suspend/resume functions to enable/disable irq
> > > - change binding properties to define wakeup sources
> > > 
> > > Changes since v2:
> > > - use standard properties for keycodes and debounce time
> > > - change to use platform_get_irq in leaf drivers
> > > - use better ways to define IRQ resources
> > > 
> > > Changes since v1:
> > > - create irq mappings in mfd core driver instead of leaf drivers
> > > - remove some unused parts in mtk-pmic-keys driver
> > > 
> > > Chen Zhong (6):
> > >   mfd: mt6397: create irq mappings in mfd core driver
> > >   dt-bindings: input: Add common keyboard document bindings
> > >   dt-bindings: input: Add document bindings for mtk-pmic-keys
> > >   dt-bindings: mfd: Add bindings for the keys as subnode of PMIC
> > >   input: Add MediaTek PMIC keys support
> > >   mfd: mt6397: Add PMIC keys support to MT6397 driver
> > > 
> > >  Documentation/devicetree/bindings/input/keys.txt   |   8 +
> > >  .../devicetree/bindings/input/mtk-pmic-keys.txt|  43 +++
> > >  Documentation/devicetree/bindings/mfd/mt6397.txt   |   6 +
> > >  drivers/input/keyboard/Kconfig |   9 +
> > >  drivers/input/keyboard/Makefile|   1 +
> > >  drivers/input/keyboard/mtk-pmic-keys.c | 339
> > > +
> > >  drivers/mfd/mt6397-core.c  |  26 +-
> > >  drivers/rtc/rtc-mt6397.c   |   7 +-
> > >  8 files changed, 432 insertions(+), 7 deletions(-)  create mode 100644
> > > Documentation/devicetree/bindings/input/keys.txt
> > >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-
> > > keys.txt
> > >  create mode 100644 drivers/input/keyboard/mtk-pmic-keys.c
> > > 
> > > --
> > > 1.9.1
> > > 
> > > 
> > > 
> > > ___
> > > Linux-mediatek mailing list
> > > linux-media...@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 
> 

-- 
Dmitry

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Dmitry Torokhov]

Hi Sean,

On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote:
> Hi, Dmitry and Lee
> 
> The series seems not being got merged. Are they good enough to be ready
> into the your tree?
> 
> Recently I've tested the series with focusing on pwrkey event generated
> through interrupt when push and release the key on bpi-r2 board and then
> finally it's working fine. but for homekey it cannot be found on the
> board and thus I cannot have more tests more about it.
> 
> Tested-by: Sean Wang 

You have my Ack on the input patch; I expect it go through Lee's tree as
there are some dependencies on mfd core piece.

Thanks.

> 
>   Sean
> 
> 
> On Thu, 2018-03-22 at 10:03 +0800, Sean Wang (王志亘) wrote:
> > 
> > > -Original Message-
> > > From: Linux-mediatek [mailto:linux-mediatek-boun...@lists.infradead.org] 
> > > On
> > > Behalf Of Chen Zhong
> > > Sent: Wednesday, October 25, 2017 9:16 PM
> > > To: Dmitry Torokhov ; Rob Herring
> > > ; Lee Jones ; Alexandre Belloni
> > > 
> > > Cc: Mark Rutland ; Alessandro Zummo
> > > ; devicet...@vger.kernel.org; Linus Walleij
> > > ; Jaechul Lee ; linux-
> > > ker...@vger.kernel.org; Krzysztof Kozlowski ; Javier
> > > Martinez Canillas ; linux-
> > > media...@lists.infradead.org; linux-arm-ker...@lists.infradead.org; linux-
> > > in...@vger.kernel.org; Matthias Brugger ; Eddie
> > > Huang (S智) ; Chen Zhong (钟辰)
> > > ; Beomho Seo ;
> > > linux-...@vger.kernel.org
> > > Subject: [PATCH v6 0/6] Add MediaTek PMIC keys support
> > > 
> > > MediaTek PMIC are multi-function devices that can handle key interrupts,
> > > typically there are two keys attached to PMIC, which called pwrkey and
> > > homekey. PWRKEY usually used to wake up system from sleep. Homekey can
> > > used as volume down key due to board design. Long press keys can shutdown
> > > PMIC, the mode can be choose to be one key only or two keys together.
> > > This series add support for key functions for MediaTek PMIC MT6397/MT6323.
> > > 
> > > Changes since v5:
> > > - use __maybe_unused annotation instead of #ifdef guard
> > > - use of_* API instead of device_* API
> > > 
> > > Changes since v4:
> > > - rebase to Linux 4.14-rc1
> > > - add a common keyboard binding document
> > > - use child device tree node to define each key
> > > 
> > > Changes since v3:
> > > - make the naming to be consistent as mtk_pmic or MTK_PMIC
> > > - add suspend/resume functions to enable/disable irq
> > > - change binding properties to define wakeup sources
> > > 
> > > Changes since v2:
> > > - use standard properties for keycodes and debounce time
> > > - change to use platform_get_irq in leaf drivers
> > > - use better ways to define IRQ resources
> > > 
> > > Changes since v1:
> > > - create irq mappings in mfd core driver instead of leaf drivers
> > > - remove some unused parts in mtk-pmic-keys driver
> > > 
> > > Chen Zhong (6):
> > >   mfd: mt6397: create irq mappings in mfd core driver
> > >   dt-bindings: input: Add common keyboard document bindings
> > >   dt-bindings: input: Add document bindings for mtk-pmic-keys
> > >   dt-bindings: mfd: Add bindings for the keys as subnode of PMIC
> > >   input: Add MediaTek PMIC keys support
> > >   mfd: mt6397: Add PMIC keys support to MT6397 driver
> > > 
> > >  Documentation/devicetree/bindings/input/keys.txt   |   8 +
> > >  .../devicetree/bindings/input/mtk-pmic-keys.txt|  43 +++
> > >  Documentation/devicetree/bindings/mfd/mt6397.txt   |   6 +
> > >  drivers/input/keyboard/Kconfig |   9 +
> > >  drivers/input/keyboard/Makefile|   1 +
> > >  drivers/input/keyboard/mtk-pmic-keys.c | 339
> > > +
> > >  drivers/mfd/mt6397-core.c  |  26 +-
> > >  drivers/rtc/rtc-mt6397.c   |   7 +-
> > >  8 files changed, 432 insertions(+), 7 deletions(-)  create mode 100644
> > > Documentation/devicetree/bindings/input/keys.txt
> > >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-
> > > keys.txt
> > >  create mode 100644 drivers/input/keyboard/mtk-pmic-keys.c
> > > 
> > > --
> > > 1.9.1
> > > 
> > > 
> > > 
> > > ___
> > > Linux-mediatek mailing list
> > > linux-media...@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 
> 

-- 
Dmitry

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Sean Wang]

Hi, Dmitry and Lee

The series seems not being got merged. Are they good enough to be ready
into the your tree?

Recently I've tested the series with focusing on pwrkey event generated
through interrupt when push and release the key on bpi-r2 board and then
finally it's working fine. but for homekey it cannot be found on the
board and thus I cannot have more tests more about it.

Tested-by: Sean Wang <sean.w...@mediatek.com>

Sean


On Thu, 2018-03-22 at 10:03 +0800, Sean Wang (王志亘) wrote:
> 
> > -Original Message-
> > From: Linux-mediatek [mailto:linux-mediatek-boun...@lists.infradead.org] On
> > Behalf Of Chen Zhong
> > Sent: Wednesday, October 25, 2017 9:16 PM
> > To: Dmitry Torokhov <dmitry.torok...@gmail.com>; Rob Herring
> > <robh...@kernel.org>; Lee Jones <lee.jo...@linaro.org>; Alexandre Belloni
> > <alexandre.bell...@free-electrons.com>
> > Cc: Mark Rutland <mark.rutl...@arm.com>; Alessandro Zummo
> > <a.zu...@towertech.it>; devicet...@vger.kernel.org; Linus Walleij
> > <linus.wall...@linaro.org>; Jaechul Lee <jcsing@samsung.com>; linux-
> > ker...@vger.kernel.org; Krzysztof Kozlowski <k...@kernel.org>; Javier
> > Martinez Canillas <jav...@osg.samsung.com>; linux-
> > media...@lists.infradead.org; linux-arm-ker...@lists.infradead.org; linux-
> > in...@vger.kernel.org; Matthias Brugger <matthias@gmail.com>; Eddie
> > Huang (S智) <eddie.hu...@mediatek.com>; Chen Zhong (钟辰)
> > <chen.zh...@mediatek.com>; Beomho Seo <beomho@samsung.com>;
> > linux-...@vger.kernel.org
> > Subject: [PATCH v6 0/6] Add MediaTek PMIC keys support
> > 
> > MediaTek PMIC are multi-function devices that can handle key interrupts,
> > typically there are two keys attached to PMIC, which called pwrkey and
> > homekey. PWRKEY usually used to wake up system from sleep. Homekey can
> > used as volume down key due to board design. Long press keys can shutdown
> > PMIC, the mode can be choose to be one key only or two keys together.
> > This series add support for key functions for MediaTek PMIC MT6397/MT6323.
> > 
> > Changes since v5:
> > - use __maybe_unused annotation instead of #ifdef guard
> > - use of_* API instead of device_* API
> > 
> > Changes since v4:
> > - rebase to Linux 4.14-rc1
> > - add a common keyboard binding document
> > - use child device tree node to define each key
> > 
> > Changes since v3:
> > - make the naming to be consistent as mtk_pmic or MTK_PMIC
> > - add suspend/resume functions to enable/disable irq
> > - change binding properties to define wakeup sources
> > 
> > Changes since v2:
> > - use standard properties for keycodes and debounce time
> > - change to use platform_get_irq in leaf drivers
> > - use better ways to define IRQ resources
> > 
> > Changes since v1:
> > - create irq mappings in mfd core driver instead of leaf drivers
> > - remove some unused parts in mtk-pmic-keys driver
> > 
> > Chen Zhong (6):
> >   mfd: mt6397: create irq mappings in mfd core driver
> >   dt-bindings: input: Add common keyboard document bindings
> >   dt-bindings: input: Add document bindings for mtk-pmic-keys
> >   dt-bindings: mfd: Add bindings for the keys as subnode of PMIC
> >   input: Add MediaTek PMIC keys support
> >   mfd: mt6397: Add PMIC keys support to MT6397 driver
> > 
> >  Documentation/devicetree/bindings/input/keys.txt   |   8 +
> >  .../devicetree/bindings/input/mtk-pmic-keys.txt|  43 +++
> >  Documentation/devicetree/bindings/mfd/mt6397.txt   |   6 +
> >  drivers/input/keyboard/Kconfig |   9 +
> >  drivers/input/keyboard/Makefile|   1 +
> >  drivers/input/keyboard/mtk-pmic-keys.c | 339
> > +
> >  drivers/mfd/mt6397-core.c  |  26 +-
> >  drivers/rtc/rtc-mt6397.c   |   7 +-
> >  8 files changed, 432 insertions(+), 7 deletions(-)  create mode 100644
> > Documentation/devicetree/bindings/input/keys.txt
> >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-
> > keys.txt
> >  create mode 100644 drivers/input/keyboard/mtk-pmic-keys.c
> > 
> > --
> > 1.9.1
> > 
> > 
> > 
> > ___
> > Linux-mediatek mailing list
> > linux-media...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

[Sean Wang]

Hi, Dmitry and Lee

The series seems not being got merged. Are they good enough to be ready
into the your tree?

Recently I've tested the series with focusing on pwrkey event generated
through interrupt when push and release the key on bpi-r2 board and then
finally it's working fine. but for homekey it cannot be found on the
board and thus I cannot have more tests more about it.

Tested-by: Sean Wang 

Sean


On Thu, 2018-03-22 at 10:03 +0800, Sean Wang (王志亘) wrote:
> 
> > -Original Message-
> > From: Linux-mediatek [mailto:linux-mediatek-boun...@lists.infradead.org] On
> > Behalf Of Chen Zhong
> > Sent: Wednesday, October 25, 2017 9:16 PM
> > To: Dmitry Torokhov ; Rob Herring
> > ; Lee Jones ; Alexandre Belloni
> > 
> > Cc: Mark Rutland ; Alessandro Zummo
> > ; devicet...@vger.kernel.org; Linus Walleij
> > ; Jaechul Lee ; linux-
> > ker...@vger.kernel.org; Krzysztof Kozlowski ; Javier
> > Martinez Canillas ; linux-
> > media...@lists.infradead.org; linux-arm-ker...@lists.infradead.org; linux-
> > in...@vger.kernel.org; Matthias Brugger ; Eddie
> > Huang (S智) ; Chen Zhong (钟辰)
> > ; Beomho Seo ;
> > linux-...@vger.kernel.org
> > Subject: [PATCH v6 0/6] Add MediaTek PMIC keys support
> > 
> > MediaTek PMIC are multi-function devices that can handle key interrupts,
> > typically there are two keys attached to PMIC, which called pwrkey and
> > homekey. PWRKEY usually used to wake up system from sleep. Homekey can
> > used as volume down key due to board design. Long press keys can shutdown
> > PMIC, the mode can be choose to be one key only or two keys together.
> > This series add support for key functions for MediaTek PMIC MT6397/MT6323.
> > 
> > Changes since v5:
> > - use __maybe_unused annotation instead of #ifdef guard
> > - use of_* API instead of device_* API
> > 
> > Changes since v4:
> > - rebase to Linux 4.14-rc1
> > - add a common keyboard binding document
> > - use child device tree node to define each key
> > 
> > Changes since v3:
> > - make the naming to be consistent as mtk_pmic or MTK_PMIC
> > - add suspend/resume functions to enable/disable irq
> > - change binding properties to define wakeup sources
> > 
> > Changes since v2:
> > - use standard properties for keycodes and debounce time
> > - change to use platform_get_irq in leaf drivers
> > - use better ways to define IRQ resources
> > 
> > Changes since v1:
> > - create irq mappings in mfd core driver instead of leaf drivers
> > - remove some unused parts in mtk-pmic-keys driver
> > 
> > Chen Zhong (6):
> >   mfd: mt6397: create irq mappings in mfd core driver
> >   dt-bindings: input: Add common keyboard document bindings
> >   dt-bindings: input: Add document bindings for mtk-pmic-keys
> >   dt-bindings: mfd: Add bindings for the keys as subnode of PMIC
> >   input: Add MediaTek PMIC keys support
> >   mfd: mt6397: Add PMIC keys support to MT6397 driver
> > 
> >  Documentation/devicetree/bindings/input/keys.txt   |   8 +
> >  .../devicetree/bindings/input/mtk-pmic-keys.txt|  43 +++
> >  Documentation/devicetree/bindings/mfd/mt6397.txt   |   6 +
> >  drivers/input/keyboard/Kconfig |   9 +
> >  drivers/input/keyboard/Makefile|   1 +
> >  drivers/input/keyboard/mtk-pmic-keys.c | 339
> > +
> >  drivers/mfd/mt6397-core.c  |  26 +-
> >  drivers/rtc/rtc-mt6397.c   |   7 +-
> >  8 files changed, 432 insertions(+), 7 deletions(-)  create mode 100644
> > Documentation/devicetree/bindings/input/keys.txt
> >  create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-
> > keys.txt
> >  create mode 100644 drivers/input/keyboard/mtk-pmic-keys.c
> > 
> > --
> > 1.9.1
> > 
> > 
> > 
> > ___
> > Linux-mediatek mailing list
> > linux-media...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek

[PATCH v6 0/6] Add MediaTek PMIC keys support

[Chen Zhong]

MediaTek PMIC are multi-function devices that can handle key interrupts, 
typically there are two keys attached to PMIC, which called pwrkey and homekey. 
PWRKEY usually used to wake up system from sleep. Homekey can used as volume 
down key due to board design. Long press keys can shutdown PMIC, the mode can 
be choose to be one key only or two keys together.
This series add support for key functions for MediaTek PMIC MT6397/MT6323.

Changes since v5:
- use __maybe_unused annotation instead of #ifdef guard
- use of_* API instead of device_* API

Changes since v4:
- rebase to Linux 4.14-rc1
- add a common keyboard binding document
- use child device tree node to define each key

Changes since v3:
- make the naming to be consistent as mtk_pmic or MTK_PMIC
- add suspend/resume functions to enable/disable irq
- change binding properties to define wakeup sources

Changes since v2:
- use standard properties for keycodes and debounce time
- change to use platform_get_irq in leaf drivers
- use better ways to define IRQ resources

Changes since v1:
- create irq mappings in mfd core driver instead of leaf drivers
- remove some unused parts in mtk-pmic-keys driver

Chen Zhong (6):
  mfd: mt6397: create irq mappings in mfd core driver
  dt-bindings: input: Add common keyboard document bindings
  dt-bindings: input: Add document bindings for mtk-pmic-keys
  dt-bindings: mfd: Add bindings for the keys as subnode of PMIC
  input: Add MediaTek PMIC keys support
  mfd: mt6397: Add PMIC keys support to MT6397 driver

 Documentation/devicetree/bindings/input/keys.txt   |   8 +
 .../devicetree/bindings/input/mtk-pmic-keys.txt|  43 +++
 Documentation/devicetree/bindings/mfd/mt6397.txt   |   6 +
 drivers/input/keyboard/Kconfig |   9 +
 drivers/input/keyboard/Makefile|   1 +
 drivers/input/keyboard/mtk-pmic-keys.c | 339 +
 drivers/mfd/mt6397-core.c  |  26 +-
 drivers/rtc/rtc-mt6397.c   |   7 +-
 8 files changed, 432 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/keys.txt
 create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
 create mode 100644 drivers/input/keyboard/mtk-pmic-keys.c

-- 
1.9.1

[PATCH v6 0/6] Add MediaTek PMIC keys support

[Chen Zhong]

MediaTek PMIC are multi-function devices that can handle key interrupts, 
typically there are two keys attached to PMIC, which called pwrkey and homekey. 
PWRKEY usually used to wake up system from sleep. Homekey can used as volume 
down key due to board design. Long press keys can shutdown PMIC, the mode can 
be choose to be one key only or two keys together.
This series add support for key functions for MediaTek PMIC MT6397/MT6323.

Changes since v5:
- use __maybe_unused annotation instead of #ifdef guard
- use of_* API instead of device_* API

Changes since v4:
- rebase to Linux 4.14-rc1
- add a common keyboard binding document
- use child device tree node to define each key

Changes since v3:
- make the naming to be consistent as mtk_pmic or MTK_PMIC
- add suspend/resume functions to enable/disable irq
- change binding properties to define wakeup sources

Changes since v2:
- use standard properties for keycodes and debounce time
- change to use platform_get_irq in leaf drivers
- use better ways to define IRQ resources

Changes since v1:
- create irq mappings in mfd core driver instead of leaf drivers
- remove some unused parts in mtk-pmic-keys driver

Chen Zhong (6):
  mfd: mt6397: create irq mappings in mfd core driver
  dt-bindings: input: Add common keyboard document bindings
  dt-bindings: input: Add document bindings for mtk-pmic-keys
  dt-bindings: mfd: Add bindings for the keys as subnode of PMIC
  input: Add MediaTek PMIC keys support
  mfd: mt6397: Add PMIC keys support to MT6397 driver

 Documentation/devicetree/bindings/input/keys.txt   |   8 +
 .../devicetree/bindings/input/mtk-pmic-keys.txt|  43 +++
 Documentation/devicetree/bindings/mfd/mt6397.txt   |   6 +
 drivers/input/keyboard/Kconfig |   9 +
 drivers/input/keyboard/Makefile|   1 +
 drivers/input/keyboard/mtk-pmic-keys.c | 339 +
 drivers/mfd/mt6397-core.c  |  26 +-
 drivers/rtc/rtc-mt6397.c   |   7 +-
 8 files changed, 432 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/keys.txt
 create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
 create mode 100644 drivers/input/keyboard/mtk-pmic-keys.c

-- 
1.9.1