Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-07-13 Thread Fu Wei
Hi Guenter, Great thanks for your info, looking forward to your feedback. :-) Have a good vacation! :-) On 13 July 2015 at 23:34, Guenter Roeck wrote: > On Mon, Jul 13, 2015 at 05:09:57PM +0800, Fu Wei wrote: >> Hi Guenter, >> >> If you get some time, could you help me on this patchset again?

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-07-13 Thread Guenter Roeck
On Mon, Jul 13, 2015 at 05:09:57PM +0800, Fu Wei wrote: > Hi Guenter, > > If you get some time, could you help me on this patchset again? > Great thanks for your help! > I am on vacation this week. Hopefully next week or two weeks from now, depending on my work load. Guenter -- To unsubscribe

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-07-13 Thread Fu Wei
Hi Guenter, If you get some time, could you help me on this patchset again? Great thanks for your help! On 30 June 2015 at 03:16, Guenter Roeck wrote: > On 06/29/2015 09:53 AM, Fu Wei wrote: >> >> Hi Guenter, >> >> Any suggestion on this v6 patchset, for now , I only got : > > > Problem is that

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-07-13 Thread Fu Wei
Hi Guenter, If you get some time, could you help me on this patchset again? Great thanks for your help! On 30 June 2015 at 03:16, Guenter Roeck li...@roeck-us.net wrote: On 06/29/2015 09:53 AM, Fu Wei wrote: Hi Guenter, Any suggestion on this v6 patchset, for now , I only got : Problem

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-07-13 Thread Guenter Roeck
On Mon, Jul 13, 2015 at 05:09:57PM +0800, Fu Wei wrote: Hi Guenter, If you get some time, could you help me on this patchset again? Great thanks for your help! I am on vacation this week. Hopefully next week or two weeks from now, depending on my work load. Guenter -- To unsubscribe from

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-07-13 Thread Fu Wei
Hi Guenter, Great thanks for your info, looking forward to your feedback. :-) Have a good vacation! :-) On 13 July 2015 at 23:34, Guenter Roeck li...@roeck-us.net wrote: On Mon, Jul 13, 2015 at 05:09:57PM +0800, Fu Wei wrote: Hi Guenter, If you get some time, could you help me on this

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-30 Thread Fu Wei
Hi Guenter, Great thanks for your time, I can't tell you how much I appreciate your review! :-) np, I will improve my patchset, once I get your suggestion. :-) On 30 June 2015 at 03:16, Guenter Roeck wrote: > On 06/29/2015 09:53 AM, Fu Wei wrote: >> >> Hi Guenter, >> >> Any suggestion on this

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-30 Thread Fu Wei
Hi Guenter, Great thanks for your time, I can't tell you how much I appreciate your review! :-) np, I will improve my patchset, once I get your suggestion. :-) On 30 June 2015 at 03:16, Guenter Roeck li...@roeck-us.net wrote: On 06/29/2015 09:53 AM, Fu Wei wrote: Hi Guenter, Any suggestion

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-29 Thread Guenter Roeck
On 06/29/2015 09:53 AM, Fu Wei wrote: Hi Guenter, Any suggestion on this v6 patchset, for now , I only got : Problem is that each version of your patchset tends to introduce substantially new or different functionality, meaning the review has to pretty much start from scratch. Right now I

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-29 Thread Fu Wei
Hi Guenter, Any suggestion on this v6 patchset, for now , I only got : (1) delete WCV output: diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c index 2de5899..c42883b 100644 --- a/drivers/watchdog/sbsa_gwdt.c +++ b/drivers/watchdog/sbsa_gwdt.c @@ -344,8 +342,7 @@ static int

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-29 Thread Fu Wei
Hi Guenter, Any suggestion on this v6 patchset, for now , I only got : (1) delete WCV output: diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c index 2de5899..c42883b 100644 --- a/drivers/watchdog/sbsa_gwdt.c +++ b/drivers/watchdog/sbsa_gwdt.c @@ -344,8 +342,7 @@ static int

Re: [PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-29 Thread Guenter Roeck
On 06/29/2015 09:53 AM, Fu Wei wrote: Hi Guenter, Any suggestion on this v6 patchset, for now , I only got : Problem is that each version of your patchset tends to introduce substantially new or different functionality, meaning the review has to pretty much start from scratch. Right now I

[PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-23 Thread fu . wei
From: Fu Wei This patchset: (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt for FDT info of SBSA Generic Watchdog, and give two examples of adding SBSA Generic Watchdog device node into the dts files: foundation-v8.dts and amd-seattle-soc.dtsi.

[PATCH v6 0/8] Watchdog: introduce ARM SBSA watchdog driver

2015-06-23 Thread fu . wei
From: Fu Wei fu@linaro.org This patchset: (1)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt for FDT info of SBSA Generic Watchdog, and give two examples of adding SBSA Generic Watchdog device node into the dts files: foundation-v8.dts and