Re: [PATCH v6 0/9] KVM/ARM: Some vgic fixes and init sequence KVM selftests
On Mon, 5 Apr 2021 18:39:32 +0200, Eric Auger wrote: > While writting vgic v3 init sequence KVM selftests I noticed some > relatively minor issues. This was also the opportunity to try to > fix the issue laterly reported by Zenghui, related to the RDIST_TYPER > last bit emulation. The final patch is a first batch of VGIC init > sequence selftests. Of course they can be augmented with a lot more > register access tests, but let's try to move forward incrementally ... > > [...] Applied to kvm-arm64/vgic-5.13, thanks! [1/9] KVM: arm64: vgic-v3: Fix some error codes when setting RDIST base commit: d9b201e99c616001b4a51627820377b293479384 [2/9] KVM: arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION read commit: 53b16dd6ba5cf64ed147ac3523ec34651d553cb0 [3/9] KVM: arm64: vgic-v3: Fix error handling in vgic_v3_set_redist_base() commit: 8542a8f95a67ff6b76d6868ec0af58c464bdf041 [4/9] KVM: arm/arm64: vgic: Reset base address on kvm_vgic_dist_destroy() commit: 3a5211612764fa3948e5db5254734168e9e763de [5/9] docs: kvm: devices/arm-vgic-v3: enhance KVM_DEV_ARM_VGIC_CTRL_INIT doc commit: 298c41b8fa1e02c5a35e2263d138583220ab6094 [6/9] KVM: arm64: Simplify argument passing to vgic_uaccess_[read|write] commit: da3853097679022e14a2d125983f11a67fd2f96a [7/9] kvm: arm64: vgic-v3: Introduce vgic_v3_free_redist_region() commit: e5a35635464bc5304674b84ea42615a3fd0bd949 [8/9] KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace commit: 28e9d4bce3be9b8fec6c854f87923db99c8fb874 [9/9] KVM: selftests: aarch64/vgic-v3 init sequence tests commit: dc0e058eef42f61effe9fd4f0fa4b0c793cc1f14 Cheers, M. -- Without deviation from the norm, progress is not possible.
[PATCH v6 0/9] KVM/ARM: Some vgic fixes and init sequence KVM selftests
While writting vgic v3 init sequence KVM selftests I noticed some relatively minor issues. This was also the opportunity to try to fix the issue laterly reported by Zenghui, related to the RDIST_TYPER last bit emulation. The final patch is a first batch of VGIC init sequence selftests. Of course they can be augmented with a lot more register access tests, but let's try to move forward incrementally ... Best Regards Eric This series can be found at: https://github.com/eauger/linux/tree/vgic_kvmselftests_v6 History: v5 -> v6: - Fix the note in "KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace", confirming the rdist region list is sorted by index and not by base address. - Properly send 9 patches :-/ v4 -> v5: - rewrite the last bit detection according to Marc's interpretation of the spec and modify the kvm selftests accordingly v3 -> v4: - take into account Drew's comment on the kvm selftests. No change to the KVM related patches compared to v3 v2 ->v3: - reworked last bit read accessor to handle contiguous redist regions and rdist not registered in ascending order - removed [PATCH 5/9] KVM: arm: move has_run_once after the map_resources v1 -> v2: - Took into account all comments from Marc and Alexandru's except the has_run_once still after the map_resources (this would oblige me to revisit in depth the selftests) Eric Auger (9): KVM: arm64: vgic-v3: Fix some error codes when setting RDIST base KVM: arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION read KVM: arm64: vgic-v3: Fix error handling in vgic_v3_set_redist_base() KVM: arm/arm64: vgic: Reset base address on kvm_vgic_dist_destroy() docs: kvm: devices/arm-vgic-v3: enhance KVM_DEV_ARM_VGIC_CTRL_INIT doc KVM: arm64: Simplify argument passing to vgic_uaccess_[read|write] kvm: arm64: vgic-v3: Introduce vgic_v3_free_redist_region() KVM: arm64: vgic-v3: Expose GICR_TYPER.Last for userspace KVM: selftests: aarch64/vgic-v3 init sequence tests .../virt/kvm/devices/arm-vgic-v3.rst | 2 +- arch/arm64/kvm/vgic/vgic-init.c | 12 +- arch/arm64/kvm/vgic/vgic-kvm-device.c | 3 + arch/arm64/kvm/vgic/vgic-mmio-v3.c| 93 +-- arch/arm64/kvm/vgic/vgic-mmio.c | 10 +- arch/arm64/kvm/vgic/vgic.h| 1 + include/kvm/arm_vgic.h| 1 + tools/testing/selftests/kvm/.gitignore| 1 + tools/testing/selftests/kvm/Makefile | 1 + .../testing/selftests/kvm/aarch64/vgic_init.c | 585 ++ .../testing/selftests/kvm/include/kvm_util.h | 9 + tools/testing/selftests/kvm/lib/kvm_util.c| 77 +++ 12 files changed, 746 insertions(+), 49 deletions(-) create mode 100644 tools/testing/selftests/kvm/aarch64/vgic_init.c -- 2.26.3
