Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-19 Thread Yinghai Lu
On Wed, Dec 19, 2012 at 12:48 PM, Borislav Petkov wrote: > > "Also, do not boundary-check 'next' but pass 'end' down to > phys_pud_init() instead because the loop in there terminates at > PTRS_PER_PUD and thus can handle a possibly bigger 'end' properly." --- Just like the way we calculate next

Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-19 Thread Borislav Petkov
On Tue, Dec 18, 2012 at 07:37:14PM -0800, Yinghai Lu wrote: > update to : > > --- > Subject: [PATCH] x86, mm: make pgd next calculation consistent with pud/pmd > > Just like the way we calculate next for pud and pmd, aka > round down and add size. > > also remove not needed next checking, just

Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-19 Thread Borislav Petkov
On Tue, Dec 18, 2012 at 07:37:14PM -0800, Yinghai Lu wrote: update to : --- Subject: [PATCH] x86, mm: make pgd next calculation consistent with pud/pmd Just like the way we calculate next for pud and pmd, aka round down and add size. also remove not needed next checking, just pass end

Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-19 Thread Yinghai Lu
On Wed, Dec 19, 2012 at 12:48 PM, Borislav Petkov b...@alien8.de wrote: Also, do not boundary-check 'next' but pass 'end' down to phys_pud_init() instead because the loop in there terminates at PTRS_PER_PUD and thus can handle a possibly bigger 'end' properly. --- Just like the way we

Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-18 Thread Yinghai Lu
On Fri, Dec 14, 2012 at 6:34 AM, Borislav Petkov wrote: > On Thu, Dec 13, 2012 at 02:01:56PM -0800, Yinghai Lu wrote: >> Just like PUD_SIZE, and PMD_SIZE next calculation, aka >> round down and add size. > > Why? Please explain more verbosely. > >> also remove not need next checking, just pass

Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-18 Thread Yinghai Lu
On Fri, Dec 14, 2012 at 6:34 AM, Borislav Petkov b...@alien8.de wrote: On Thu, Dec 13, 2012 at 02:01:56PM -0800, Yinghai Lu wrote: Just like PUD_SIZE, and PMD_SIZE next calculation, aka round down and add size. Why? Please explain more verbosely. also remove not need next checking, just

Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-14 Thread Borislav Petkov
On Thu, Dec 13, 2012 at 02:01:56PM -0800, Yinghai Lu wrote: > Just like PUD_SIZE, and PMD_SIZE next calculation, aka > round down and add size. Why? Please explain more verbosely. > also remove not need next checking, just pass end instead. > later phys_pud_init uses PTRS_PER_PUD checking to

Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-14 Thread Borislav Petkov
On Thu, Dec 13, 2012 at 02:01:56PM -0800, Yinghai Lu wrote: Just like PUD_SIZE, and PMD_SIZE next calculation, aka round down and add size. Why? Please explain more verbosely. also remove not need next checking, just pass end instead. later phys_pud_init uses PTRS_PER_PUD checking to exit

[PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-13 Thread Yinghai Lu
Just like PUD_SIZE, and PMD_SIZE next calculation, aka round down and add size. also remove not need next checking, just pass end instead. later phys_pud_init uses PTRS_PER_PUD checking to exit early if end is too big. Signed-off-by: Yinghai Lu --- arch/x86/mm/init_64.c |6 ++ 1 file

[PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd

2012-12-13 Thread Yinghai Lu
Just like PUD_SIZE, and PMD_SIZE next calculation, aka round down and add size. also remove not need next checking, just pass end instead. later phys_pud_init uses PTRS_PER_PUD checking to exit early if end is too big. Signed-off-by: Yinghai Lu ying...@kernel.org --- arch/x86/mm/init_64.c |