Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Tue, May 01 2018 at 10:42 -0600, Doug Anderson wrote: Hi, On Tue, May 1, 2018 at 9:10 AM, Lina Iyer wrote: Yes, this is incorrect in its current form. This is what it should be - static int find_match(const struct tcs_group *tcs, const struct tcs_cmd *cmd,

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Tue, May 01 2018 at 10:42 -0600, Doug Anderson wrote: Hi, On Tue, May 1, 2018 at 9:10 AM, Lina Iyer wrote: Yes, this is incorrect in its current form. This is what it should be - static int find_match(const struct tcs_group *tcs, const struct tcs_cmd *cmd, int len) {

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Hi Lina, On Tue, May 01, 2018 at 10:10:10AM -0600, Lina Iyer wrote: > On Fri, Apr 27 2018 at 17:24 -0600, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 27, 2018 at 2:54 PM, Matthias Kaehlcke > > wrote: > > > > > Am I getting something wrong here? > > > > > > > > The

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Hi Lina, On Tue, May 01, 2018 at 10:10:10AM -0600, Lina Iyer wrote: > On Fri, Apr 27 2018 at 17:24 -0600, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 27, 2018 at 2:54 PM, Matthias Kaehlcke > > wrote: > > > > > Am I getting something wrong here? > > > > > > > > The for_each_set_bit()

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Hi, On Tue, May 1, 2018 at 9:10 AM, Lina Iyer wrote: > Yes, this is incorrect in its current form. This is what it should be - > > static int find_match(const struct tcs_group *tcs, const struct tcs_cmd > *cmd, > int len) > { >int i, j; > >

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Hi, On Tue, May 1, 2018 at 9:10 AM, Lina Iyer wrote: > Yes, this is incorrect in its current form. This is what it should be - > > static int find_match(const struct tcs_group *tcs, const struct tcs_cmd > *cmd, > int len) > { >int i, j; > >/* Check for

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27 2018 at 17:24 -0600, Doug Anderson wrote: Hi, On Fri, Apr 27, 2018 at 2:54 PM, Matthias Kaehlcke wrote: > Am I getting something wrong here? The for_each_set_bit() should increment the 'i' and we would attempt to compare the first address in the request with

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27 2018 at 17:24 -0600, Doug Anderson wrote: Hi, On Fri, Apr 27, 2018 at 2:54 PM, Matthias Kaehlcke wrote: > Am I getting something wrong here? The for_each_set_bit() should increment the 'i' and we would attempt to compare the first address in the request with the next command

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Hi, On Fri, Apr 27, 2018 at 2:54 PM, Matthias Kaehlcke wrote: >> > Am I getting something wrong here? >> >> The for_each_set_bit() should increment the 'i' and we would attempt to >> compare the first address in the request with the next command in the >> TCS cache. If they

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Hi, On Fri, Apr 27, 2018 at 2:54 PM, Matthias Kaehlcke wrote: >> > Am I getting something wrong here? >> >> The for_each_set_bit() should increment the 'i' and we would attempt to >> compare the first address in the request with the next command in the >> TCS cache. If they don't match we repeat

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27, 2018 at 03:32:01PM -0600, Lina Iyer wrote: > On Fri, Apr 27 2018 at 14:06 -0600, Matthias Kaehlcke wrote: > > On Fri, Apr 27, 2018 at 01:45:59PM -0600, Lina Iyer wrote: > > > On Fri, Apr 27 2018 at 12:40 -0600, Matthias Kaehlcke wrote: > > > > On Fri, Apr 27, 2018 at 11:39:43AM

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27, 2018 at 03:32:01PM -0600, Lina Iyer wrote: > On Fri, Apr 27 2018 at 14:06 -0600, Matthias Kaehlcke wrote: > > On Fri, Apr 27, 2018 at 01:45:59PM -0600, Lina Iyer wrote: > > > On Fri, Apr 27 2018 at 12:40 -0600, Matthias Kaehlcke wrote: > > > > On Fri, Apr 27, 2018 at 11:39:43AM

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27 2018 at 14:06 -0600, Matthias Kaehlcke wrote: On Fri, Apr 27, 2018 at 01:45:59PM -0600, Lina Iyer wrote: On Fri, Apr 27 2018 at 12:40 -0600, Matthias Kaehlcke wrote: > On Fri, Apr 27, 2018 at 11:39:43AM -0600, Lina Iyer wrote: > > On Wed, Apr 25 2018 at 15:41 -0600, Matthias

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27 2018 at 14:06 -0600, Matthias Kaehlcke wrote: On Fri, Apr 27, 2018 at 01:45:59PM -0600, Lina Iyer wrote: On Fri, Apr 27 2018 at 12:40 -0600, Matthias Kaehlcke wrote: > On Fri, Apr 27, 2018 at 11:39:43AM -0600, Lina Iyer wrote: > > On Wed, Apr 25 2018 at 15:41 -0600, Matthias

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27, 2018 at 01:45:59PM -0600, Lina Iyer wrote: > On Fri, Apr 27 2018 at 12:40 -0600, Matthias Kaehlcke wrote: > > On Fri, Apr 27, 2018 at 11:39:43AM -0600, Lina Iyer wrote: > > > On Wed, Apr 25 2018 at 15:41 -0600, Matthias Kaehlcke wrote: > > > > On Thu, Apr 19, 2018 at 04:16:30PM

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27, 2018 at 01:45:59PM -0600, Lina Iyer wrote: > On Fri, Apr 27 2018 at 12:40 -0600, Matthias Kaehlcke wrote: > > On Fri, Apr 27, 2018 at 11:39:43AM -0600, Lina Iyer wrote: > > > On Wed, Apr 25 2018 at 15:41 -0600, Matthias Kaehlcke wrote: > > > > On Thu, Apr 19, 2018 at 04:16:30PM

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27 2018 at 12:40 -0600, Matthias Kaehlcke wrote: On Fri, Apr 27, 2018 at 11:39:43AM -0600, Lina Iyer wrote: On Wed, Apr 25 2018 at 15:41 -0600, Matthias Kaehlcke wrote: > On Thu, Apr 19, 2018 at 04:16:30PM -0600, Lina Iyer wrote: > > Sleep and wake requests are sent when the

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27 2018 at 12:40 -0600, Matthias Kaehlcke wrote: On Fri, Apr 27, 2018 at 11:39:43AM -0600, Lina Iyer wrote: On Wed, Apr 25 2018 at 15:41 -0600, Matthias Kaehlcke wrote: > On Thu, Apr 19, 2018 at 04:16:30PM -0600, Lina Iyer wrote: > > Sleep and wake requests are sent when the

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27, 2018 at 11:39:43AM -0600, Lina Iyer wrote: > On Wed, Apr 25 2018 at 15:41 -0600, Matthias Kaehlcke wrote: > > On Thu, Apr 19, 2018 at 04:16:30PM -0600, Lina Iyer wrote: > > > Sleep and wake requests are sent when the application processor > > > subsystem of the SoC is entering deep

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Fri, Apr 27, 2018 at 11:39:43AM -0600, Lina Iyer wrote: > On Wed, Apr 25 2018 at 15:41 -0600, Matthias Kaehlcke wrote: > > On Thu, Apr 19, 2018 at 04:16:30PM -0600, Lina Iyer wrote: > > > Sleep and wake requests are sent when the application processor > > > subsystem of the SoC is entering deep

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Wed, Apr 25 2018 at 15:41 -0600, Matthias Kaehlcke wrote: On Thu, Apr 19, 2018 at 04:16:30PM -0600, Lina Iyer wrote: Sleep and wake requests are sent when the application processor subsystem of the SoC is entering deep sleep states like in suspend. These requests help lower the system power

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Wed, Apr 25 2018 at 15:41 -0600, Matthias Kaehlcke wrote: On Thu, Apr 19, 2018 at 04:16:30PM -0600, Lina Iyer wrote: Sleep and wake requests are sent when the application processor subsystem of the SoC is entering deep sleep states like in suspend. These requests help lower the system power

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Thu, Apr 19, 2018 at 04:16:30PM -0600, Lina Iyer wrote: > Sleep and wake requests are sent when the application processor > subsystem of the SoC is entering deep sleep states like in suspend. > These requests help lower the system power requirements when the > resources are not in use. > >

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

On Thu, Apr 19, 2018 at 04:16:30PM -0600, Lina Iyer wrote: > Sleep and wake requests are sent when the application processor > subsystem of the SoC is entering deep sleep states like in suspend. > These requests help lower the system power requirements when the > resources are not in use. > >

[PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Sleep and wake requests are sent when the application processor subsystem of the SoC is entering deep sleep states like in suspend. These requests help lower the system power requirements when the resources are not in use. Sleep and wake requests are written to the TCS slots but are not triggered

[PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Sleep and wake requests are sent when the application processor subsystem of the SoC is entering deep sleep states like in suspend. These requests help lower the system power requirements when the resources are not in use. Sleep and wake requests are written to the TCS slots but are not triggered