Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

Hi Stephen, 2016-09-07 9:32 GMT+09:00 Stephen Boyd : > On 09/05, Masahiro Yamada wrote: >> 2016-08-30 3:22 GMT+09:00 Stephen Boyd : >> > On 08/29, Masahiro Yamada wrote: >> >> I tried this, but it did not work. >> >> >> >> To make dev_get_regmap() work,

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

Hi Stephen, 2016-09-07 9:32 GMT+09:00 Stephen Boyd : > On 09/05, Masahiro Yamada wrote: >> 2016-08-30 3:22 GMT+09:00 Stephen Boyd : >> > On 08/29, Masahiro Yamada wrote: >> >> I tried this, but it did not work. >> >> >> >> To make dev_get_regmap() work, >> >> the parent device needs to call

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

On 09/05, Masahiro Yamada wrote: > 2016-08-30 3:22 GMT+09:00 Stephen Boyd : > > On 08/29, Masahiro Yamada wrote: > >> I tried this, but it did not work. > >> > >> To make dev_get_regmap() work, > >> the parent device needs to call dev_regmap_init_mmio() beforehand. > >> > >>

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

On 09/05, Masahiro Yamada wrote: > 2016-08-30 3:22 GMT+09:00 Stephen Boyd : > > On 08/29, Masahiro Yamada wrote: > >> I tried this, but it did not work. > >> > >> To make dev_get_regmap() work, > >> the parent device needs to call dev_regmap_init_mmio() beforehand. > >> > >> > >> Since commit

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

Hi Stephen, 2016-08-30 3:22 GMT+09:00 Stephen Boyd : > On 08/29, Masahiro Yamada wrote: >> Hi Stephen, >> >> >> 2016-08-20 4:16 GMT+09:00 Stephen Boyd : >> >> >> >> >> + >> >> >> + parent = of_get_parent(dev->of_node); /* parent should be syscon

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

Hi Stephen, 2016-08-30 3:22 GMT+09:00 Stephen Boyd : > On 08/29, Masahiro Yamada wrote: >> Hi Stephen, >> >> >> 2016-08-20 4:16 GMT+09:00 Stephen Boyd : >> >> >> >> >> + >> >> >> + parent = of_get_parent(dev->of_node); /* parent should be syscon >> >> >> node */ >> >> >> + regmap =

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

On 08/29, Masahiro Yamada wrote: > Hi Stephen, > > > 2016-08-20 4:16 GMT+09:00 Stephen Boyd : > >> > >> >> + > >> >> + parent = of_get_parent(dev->of_node); /* parent should be syscon > >> >> node */ > >> >> + regmap = syscon_node_to_regmap(parent); > >> >> +

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

On 08/29, Masahiro Yamada wrote: > Hi Stephen, > > > 2016-08-20 4:16 GMT+09:00 Stephen Boyd : > >> > >> >> + > >> >> + parent = of_get_parent(dev->of_node); /* parent should be syscon > >> >> node */ > >> >> + regmap = syscon_node_to_regmap(parent); > >> >> + of_node_put(parent); >

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

Hi Stephen, 2016-08-20 4:16 GMT+09:00 Stephen Boyd : >> >> >> + >> >> + parent = of_get_parent(dev->of_node); /* parent should be syscon >> >> node */ >> >> + regmap = syscon_node_to_regmap(parent); >> >> + of_node_put(parent); >> > >> >

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

Hi Stephen, 2016-08-20 4:16 GMT+09:00 Stephen Boyd : >> >> >> + >> >> + parent = of_get_parent(dev->of_node); /* parent should be syscon >> >> node */ >> >> + regmap = syscon_node_to_regmap(parent); >> >> + of_node_put(parent); >> > >> > devm_get_regmap(dev->parent) should work

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

On 08/20, Masahiro Yamada wrote: > 2016-08-19 9:25 GMT+09:00 Stephen Boyd : > >> +{ > >> + struct device *dev = >dev; > >> + const struct of_device_id *match; > >> + struct clk_hw_onecell_data *hw_data; > >> + struct device_node *parent; > >> + struct

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

On 08/20, Masahiro Yamada wrote: > 2016-08-19 9:25 GMT+09:00 Stephen Boyd : > >> +{ > >> + struct device *dev = >dev; > >> + const struct of_device_id *match; > >> + struct clk_hw_onecell_data *hw_data; > >> + struct device_node *parent; > >> + struct regmap *regmap; > >> +

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

Hi Stephen, 2016-08-19 9:25 GMT+09:00 Stephen Boyd : >> +int uniphier_clk_probe(struct platform_device *pdev) > > static? Thanks. Will fix in v7. >> +{ >> + struct device *dev = >dev; >> + const struct of_device_id *match; >> + struct clk_hw_onecell_data

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

Hi Stephen, 2016-08-19 9:25 GMT+09:00 Stephen Boyd : >> +int uniphier_clk_probe(struct platform_device *pdev) > > static? Thanks. Will fix in v7. >> +{ >> + struct device *dev = >dev; >> + const struct of_device_id *match; >> + struct clk_hw_onecell_data *hw_data; >> + struct

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

On 08/02, Masahiro Yamada wrote: > diff --git a/drivers/clk/uniphier/clk-uniphier-core.c > b/drivers/clk/uniphier/clk-uniphier-core.c > new file mode 100644 > index 000..d6dfa4d > --- /dev/null > +++ b/drivers/clk/uniphier/clk-uniphier-core.c > @@ -0,0 +1,124 @@ > +/* > + * Copyright (C) 2016

Re: [PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

On 08/02, Masahiro Yamada wrote: > diff --git a/drivers/clk/uniphier/clk-uniphier-core.c > b/drivers/clk/uniphier/clk-uniphier-core.c > new file mode 100644 > index 000..d6dfa4d > --- /dev/null > +++ b/drivers/clk/uniphier/clk-uniphier-core.c > @@ -0,0 +1,124 @@ > +/* > + * Copyright (C) 2016

[PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

This includes UniPhier clock driver code, except SoC-specific data arrays. Signed-off-by: Masahiro Yamada --- MAINTAINERS | 1 + drivers/clk/Kconfig | 1 + drivers/clk/Makefile

[PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

This includes UniPhier clock driver code, except SoC-specific data arrays. Signed-off-by: Masahiro Yamada --- MAINTAINERS | 1 + drivers/clk/Kconfig | 1 + drivers/clk/Makefile | 1 +

[PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

This includes UniPhier clock driver code, except SoC-specific data arrays. Signed-off-by: Masahiro Yamada --- MAINTAINERS | 1 + drivers/clk/Kconfig | 1 + drivers/clk/Makefile

[PATCH v6 1/2] clk: uniphier: add core support code for UniPhier clock driver

This includes UniPhier clock driver code, except SoC-specific data arrays. Signed-off-by: Masahiro Yamada --- MAINTAINERS | 1 + drivers/clk/Kconfig | 1 + drivers/clk/Makefile | 1 +