Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-20 Thread Parthiban Nallathambi
Hi Marcus, On 08/19/2018 11:50 PM, Marcus Folkesson wrote: Hi, On Tue, Aug 07, 2018 at 12:27:03PM +0200, Parthiban Nallathambi wrote: Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by:

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-20 Thread Parthiban Nallathambi
Hi Marcus, On 08/19/2018 11:50 PM, Marcus Folkesson wrote: Hi, On Tue, Aug 07, 2018 at 12:27:03PM +0200, Parthiban Nallathambi wrote: Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by:

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-19 Thread Marcus Folkesson
Hi, On Tue, Aug 07, 2018 at 12:27:03PM +0200, Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function > > Signed-off-by: Parthiban Nallathambi > > Changelog since v1: > >

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-19 Thread Marcus Folkesson
Hi, On Tue, Aug 07, 2018 at 12:27:03PM +0200, Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function > > Signed-off-by: Parthiban Nallathambi > > Changelog since v1: > >

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-19 Thread Jonathan Cameron
On Tue, 7 Aug 2018 12:27:03 +0200 Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function > > Signed-off-by: Parthiban Nallathambi > Changelog should be below the --- as

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-19 Thread Jonathan Cameron
On Tue, 7 Aug 2018 12:27:03 +0200 Parthiban Nallathambi wrote: > Add support for VCNL4035, which is capable of Ambient light > sensing (ALS) and proximity function. This patch adds support > only for ALS function > > Signed-off-by: Parthiban Nallathambi > Changelog should be below the --- as

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-19 Thread Jonathan Cameron
On Sat, 11 Aug 2018 23:25:41 +0800 kbuild test robot wrote: > Hi Parthiban, > > Thank you for the patch! Yet something to improve: The issue here is I think that you should be simply calling hweight8 rather than directly calling the fallback software version. I 'might' fix that up if it is

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-19 Thread Jonathan Cameron
On Sat, 11 Aug 2018 23:25:41 +0800 kbuild test robot wrote: > Hi Parthiban, > > Thank you for the patch! Yet something to improve: The issue here is I think that you should be simply calling hweight8 rather than directly calling the fallback software version. I 'might' fix that up if it is

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-11 Thread kbuild test robot
Hi Parthiban, Thank you for the patch! Yet something to improve: [auto build test ERROR on iio/togreg] [also build test ERROR on v4.18-rc8 next-20180810] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-11 Thread kbuild test robot
Hi Parthiban, Thank you for the patch! Yet something to improve: [auto build test ERROR on iio/togreg] [also build test ERROR on v4.18-rc8 next-20180810] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-07 Thread Parthiban Nallathambi
Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by: Parthiban Nallathambi Changelog since v1: 1. Fixed 0-day warning on le16_to_cpu usage 2. Persistence value is directly mapped to

[PATCH v6 1/2] iio: light: Add support for vishay vcnl4035

2018-08-07 Thread Parthiban Nallathambi
Add support for VCNL4035, which is capable of Ambient light sensing (ALS) and proximity function. This patch adds support only for ALS function Signed-off-by: Parthiban Nallathambi Changelog since v1: 1. Fixed 0-day warning on le16_to_cpu usage 2. Persistence value is directly mapped to