Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-13 Thread David Gow
On Sat, Nov 14, 2020 at 9:38 AM Arpitha Raghunandan <98.a...@gmail.com> wrote: > > On 14/11/20 5:44 am, Marco Elver wrote: > > > > Arpitha: Do you want to send v7, but with the following modifications > > from what I proposed? Assuming nobody objects. > > > > 1. Remove the num_params counter and

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-13 Thread Arpitha Raghunandan
On 14/11/20 5:44 am, Marco Elver wrote: > On Fri, 13 Nov 2020 at 23:37, David Gow wrote: >> >> On Fri, Nov 13, 2020 at 6:31 PM Marco Elver wrote: >>> >>> On Fri, Nov 13, 2020 at 01:17PM +0800, David Gow wrote: On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote: >>> [...] >> (It also

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-13 Thread Marco Elver
On Fri, 13 Nov 2020 at 23:37, David Gow wrote: > > On Fri, Nov 13, 2020 at 6:31 PM Marco Elver wrote: > > > > On Fri, Nov 13, 2020 at 01:17PM +0800, David Gow wrote: > > > On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote: > > [...] > > > > > (It also might be a little tricky with the current

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-13 Thread David Gow
On Fri, Nov 13, 2020 at 6:31 PM Marco Elver wrote: > > On Fri, Nov 13, 2020 at 01:17PM +0800, David Gow wrote: > > On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote: > [...] > > > > (It also might be a little tricky with the current implementation to > > > > produce the test plan, as the

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-13 Thread Marco Elver
On Fri, Nov 13, 2020 at 01:17PM +0800, David Gow wrote: > On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote: [...] > > > (It also might be a little tricky with the current implementation to > > > produce the test plan, as the parameters come from a generator, and I > > > don't think there's a way

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-12 Thread David Gow
On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote: > > On Thu, Nov 12, 2020 at 04:18PM +0800, David Gow wrote: > > On Thu, Nov 12, 2020 at 12:55 AM Bird, Tim wrote: > [...] > > > > kunit_tool has a bug when parsing the comments / diagnostic lines, > > > > which requires a ": " to be present.

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-12 Thread Marco Elver
On Thu, Nov 12, 2020 at 04:18PM +0800, David Gow wrote: > On Thu, Nov 12, 2020 at 12:55 AM Bird, Tim wrote: [...] > > > kunit_tool has a bug when parsing the comments / diagnostic lines, > > > which requires a ": " to be present. This is a bug, which is being > > > fixed[1], so while it's _nice_

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-12 Thread David Gow
On Thu, Nov 12, 2020 at 12:55 AM Bird, Tim wrote: > > > > > -Original Message- > > From: David Gow > > > > On Wed, Nov 11, 2020 at 1:02 AM Bird, Tim wrote: > > > > > > > -Original Message- > > > > From: David Gow > > > > > > > > On Mon, Nov 9, 2020 at 2:49 PM Arpitha

RE: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-11 Thread Bird, Tim
> -Original Message- > From: David Gow > > On Wed, Nov 11, 2020 at 1:02 AM Bird, Tim wrote: > > > > > -Original Message- > > > From: David Gow > > > > > > On Mon, Nov 9, 2020 at 2:49 PM Arpitha Raghunandan <98.a...@gmail.com> > > > wrote: > > > > > > > > On 07/11/20 3:36 pm,

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-10 Thread David Gow
On Wed, Nov 11, 2020 at 1:02 AM Bird, Tim wrote: > > > > > -Original Message- > > From: David Gow > > > > On Mon, Nov 9, 2020 at 2:49 PM Arpitha Raghunandan <98.a...@gmail.com> > > wrote: > > > > > > On 07/11/20 3:36 pm, Marco Elver wrote: > > > > On Sat, 7 Nov 2020 at 05:58, David Gow

RE: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-10 Thread Bird, Tim
> -Original Message- > From: David Gow > > On Mon, Nov 9, 2020 at 2:49 PM Arpitha Raghunandan <98.a...@gmail.com> wrote: > > > > On 07/11/20 3:36 pm, Marco Elver wrote: > > > On Sat, 7 Nov 2020 at 05:58, David Gow wrote: > > >> On Sat, Nov 7, 2020 at 3:22 AM Arpitha Raghunandan

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-10 Thread Arpitha Raghunandan
On 10/11/20 10:11 pm, Marco Elver wrote: > On Tue, 10 Nov 2020 at 17:32, Arpitha Raghunandan <98.a...@gmail.com> wrote: >> >> On 10/11/20 4:05 pm, Marco Elver wrote: >>> On Tue, 10 Nov 2020 at 08:21, David Gow wrote: >>> [...] >> >> The previous attempt [1] at something similar failed

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-10 Thread Marco Elver
On Tue, 10 Nov 2020 at 17:32, Arpitha Raghunandan <98.a...@gmail.com> wrote: > > On 10/11/20 4:05 pm, Marco Elver wrote: > > On Tue, 10 Nov 2020 at 08:21, David Gow wrote: > > [...] > > The previous attempt [1] at something similar failed because it seems > we'd need to teach

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-10 Thread Arpitha Raghunandan
On 10/11/20 4:05 pm, Marco Elver wrote: > On Tue, 10 Nov 2020 at 08:21, David Gow wrote: > [...] The previous attempt [1] at something similar failed because it seems we'd need to teach kunit-tool new tricks [2], too. [1]

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-10 Thread Marco Elver
On Tue, 10 Nov 2020 at 08:21, David Gow wrote: [...] > > > > > > The previous attempt [1] at something similar failed because it seems > > > we'd need to teach kunit-tool new tricks [2], too. > > > [1] https://lkml.kernel.org/r/20201105195503.ga2399...@elver.google.com > > > [2]

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-09 Thread David Gow
On Mon, Nov 9, 2020 at 2:49 PM Arpitha Raghunandan <98.a...@gmail.com> wrote: > > On 07/11/20 3:36 pm, Marco Elver wrote: > > On Sat, 7 Nov 2020 at 05:58, David Gow wrote: > >> On Sat, Nov 7, 2020 at 3:22 AM Arpitha Raghunandan <98.a...@gmail.com> > >> wrote: > >>> > >>> Implementation of

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-08 Thread Arpitha Raghunandan
On 07/11/20 3:36 pm, Marco Elver wrote: > On Sat, 7 Nov 2020 at 05:58, David Gow wrote: >> On Sat, Nov 7, 2020 at 3:22 AM Arpitha Raghunandan <98.a...@gmail.com> wrote: >>> >>> Implementation of support for parameterized testing in KUnit. >>> This approach requires the creation of a test case

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-07 Thread Marco Elver
On Sat, 7 Nov 2020 at 05:58, David Gow wrote: > On Sat, Nov 7, 2020 at 3:22 AM Arpitha Raghunandan <98.a...@gmail.com> wrote: > > > > Implementation of support for parameterized testing in KUnit. > > This approach requires the creation of a test case using the > > KUNIT_CASE_PARAM macro that

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread David Gow
On Sat, Nov 7, 2020 at 3:22 AM Arpitha Raghunandan <98.a...@gmail.com> wrote: > > Implementation of support for parameterized testing in KUnit. > This approach requires the creation of a test case using the > KUNIT_CASE_PARAM macro that accepts a generator function as input. > This generator

Re: [PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread Marco Elver
On Fri, 6 Nov 2020 at 20:22, Arpitha Raghunandan <98.a...@gmail.com> wrote: > Implementation of support for parameterized testing in KUnit. > This approach requires the creation of a test case using the > KUNIT_CASE_PARAM macro that accepts a generator function as input. > This generator function

[PATCH v6 1/2] kunit: Support for Parameterized Testing

2020-11-06 Thread Arpitha Raghunandan
Implementation of support for parameterized testing in KUnit. This approach requires the creation of a test case using the KUNIT_CASE_PARAM macro that accepts a generator function as input. This generator function should return the next parameter given the previous parameter in parameterized