Re: [PATCH v6 1/5] seccomp: add a return code to trap to userspace

2018-09-08 Thread Tycho Andersen
On Thu, Sep 06, 2018 at 10:15:12PM +, Tyler Hicks wrote: > On 2018-09-06 09:28:55, Tycho Andersen wrote: > > /** > > * struct seccomp_filter - container for seccomp BPF programs > > * > > @@ -66,6 +114,30 @@ struct seccomp_filter { > > bool log; > > struct seccomp_filter *prev; >

Re: [PATCH v6 1/5] seccomp: add a return code to trap to userspace

2018-09-08 Thread Tycho Andersen
On Thu, Sep 06, 2018 at 10:15:12PM +, Tyler Hicks wrote: > On 2018-09-06 09:28:55, Tycho Andersen wrote: > > /** > > * struct seccomp_filter - container for seccomp BPF programs > > * > > @@ -66,6 +114,30 @@ struct seccomp_filter { > > bool log; > > struct seccomp_filter *prev; >

Re: [PATCH v6 1/5] seccomp: add a return code to trap to userspace

2018-09-07 Thread Tycho Andersen
Hey Tyler, On Thu, Sep 06, 2018 at 10:15:12PM +, Tyler Hicks wrote: > > +Users can read via ``ioctl(SECCOMP_NOTIF_RECV)`` (or ``poll()``) on a > > seccomp > > +notification fd to receive a ``struct seccomp_notif``, which contains five > > +members: the input length of the structure, a

Re: [PATCH v6 1/5] seccomp: add a return code to trap to userspace

2018-09-07 Thread Tycho Andersen
Hey Tyler, On Thu, Sep 06, 2018 at 10:15:12PM +, Tyler Hicks wrote: > > +Users can read via ``ioctl(SECCOMP_NOTIF_RECV)`` (or ``poll()``) on a > > seccomp > > +notification fd to receive a ``struct seccomp_notif``, which contains five > > +members: the input length of the structure, a

Re: [PATCH v6 1/5] seccomp: add a return code to trap to userspace

2018-09-06 Thread Tyler Hicks
Hey Tycho - I'm finally getting around to reviewing this patch set. I don't have access to previous review comments while I'm doing this review so I hope I'm not revisiting too many previous discussions. On 2018-09-06 09:28:55, Tycho Andersen wrote: > This patch introduces a means for syscalls

Re: [PATCH v6 1/5] seccomp: add a return code to trap to userspace

2018-09-06 Thread Tyler Hicks
Hey Tycho - I'm finally getting around to reviewing this patch set. I don't have access to previous review comments while I'm doing this review so I hope I'm not revisiting too many previous discussions. On 2018-09-06 09:28:55, Tycho Andersen wrote: > This patch introduces a means for syscalls

[PATCH v6 1/5] seccomp: add a return code to trap to userspace

2018-09-06 Thread Tycho Andersen
This patch introduces a means for syscalls matched in seccomp to notify some other task that a particular filter has been triggered. The motivation for this is primarily for use with containers. For example, if a container does an init_module(), we obviously don't want to load this untrusted

[PATCH v6 1/5] seccomp: add a return code to trap to userspace

2018-09-06 Thread Tycho Andersen
This patch introduces a means for syscalls matched in seccomp to notify some other task that a particular filter has been triggered. The motivation for this is primarily for use with containers. For example, if a container does an init_module(), we obviously don't want to load this untrusted