Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 June 2013 07:13 PM, Sylwester Nawrocki wrote: Hi, On 06/04/2013 02:26 PM, Kishon Vijay Abraham I wrote: +static inline int phy_init(struct phy *phy) +{ + pm_runtime_get_sync(&phy->dev); Hmm, no need to check return value here ? Also it looks a bit unexpected to I pu

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Sylwester Nawrocki
Hi, On 06/04/2013 02:26 PM, Kishon Vijay Abraham I wrote: >>> +static inline int phy_init(struct phy *phy) >>> +{ >>> + pm_runtime_get_sync(&phy->dev); >> >> Hmm, no need to check return value here ? Also it looks a bit unexpected to > > I purposely dint check the return values in order to supp

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Kishon Vijay Abraham I
Hi, On Tuesday 04 June 2013 03:51 PM, Sylwester Nawrocki wrote: On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. F

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Sylwester Nawrocki
On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of APIs for the PHY drivers to > create/destroy a PHY and APIs for the PHY users to obtain a reference to the > PHY with or without using phandle. For dt-boot, the PHY drivers should > also register *PHY provid

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-06-04 Thread Sylwester Nawrocki
Hi, On 05/29/2013 07:38 AM, Kishon Vijay Abraham I wrote: > On Wednesday 29 May 2013 04:07 AM, Sylwester Nawrocki wrote: >> > On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: >>> >> The PHY framework provides a set of APIs for the PHY drivers to >>> >> create/destroy a PHY and APIs for the PH

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-05-28 Thread Kishon Vijay Abraham I
Hi, On Wednesday 29 May 2013 04:07 AM, Sylwester Nawrocki wrote: Hi Kishon, On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without usi

Re: [PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-05-28 Thread Sylwester Nawrocki
Hi Kishon, On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY

[PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-04-29 Thread Kishon Vijay Abraham I
The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. For dt-boot, the PHY drivers should also register *PHY provider* with the framework. PHY drivers should create the PHY by