Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-24 Thread Srinivas Kandagatla
On 23/06/15 10:26, Pantelis Antoniou wrote: Hi Joe, >On Jun 23, 2015, at 05:52 , Joe Perches wrote: > >On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote: >>This patch adds just providers part of the framework just to enable easy >>review. >[] >>include/linux/nvmem-provider.h |

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-24 Thread Srinivas Kandagatla
On 23/06/15 21:10, Stefan Wahren wrote: Hi Srinivas, sorry for the messed up indention. NP, + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include Sorting alphabetically would by nice Good Idea. + [...] +/** + *

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-24 Thread Srinivas Kandagatla
On 23/06/15 21:10, Stefan Wahren wrote: Hi Srinivas, sorry for the messed up indention. NP, + */ + +#include linux/device.h +#include linux/nvmem-provider.h +#include linux/export.h +#include linux/fs.h +#include linux/idr.h +#include linux/init.h +#include linux/regmap.h +#include

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-24 Thread Srinivas Kandagatla
On 23/06/15 10:26, Pantelis Antoniou wrote: Hi Joe, On Jun 23, 2015, at 05:52 , Joe Perchesj...@perches.com wrote: On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote: This patch adds just providers part of the framework just to enable easy review. []

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-23 Thread Stefan Wahren
Hi Srinivas, sorry for the messed up indention. > Srinivas Kandagatla hat am 23. Juni 2015 um > 01:08 geschrieben: > > > [...] > --- /dev/null > +++ b/drivers/nvmem/Kconfig > @@ -0,0 +1,10 @@ > +menuconfig NVMEM > + tristate "NVMEM Support" > + select REGMAP > + help > + Support for NVMEM

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-23 Thread Pantelis Antoniou
Hi Joe, > On Jun 23, 2015, at 05:52 , Joe Perches wrote: > > On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote: >> This patch adds just providers part of the framework just to enable easy >> review. > [] >> include/linux/nvmem-provider.h | 54 ++ > > Unless there are going to be

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-23 Thread Stefan Wahren
Hi Srinivas, sorry for the messed up indention. Srinivas Kandagatla srinivas.kandaga...@linaro.org hat am 23. Juni 2015 um 01:08 geschrieben: [...] --- /dev/null +++ b/drivers/nvmem/Kconfig @@ -0,0 +1,10 @@ +menuconfig NVMEM + tristate NVMEM Support + select REGMAP + help + Support

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-23 Thread Pantelis Antoniou
Hi Joe, On Jun 23, 2015, at 05:52 , Joe Perches j...@perches.com wrote: On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote: This patch adds just providers part of the framework just to enable easy review. [] include/linux/nvmem-provider.h | 54 ++ Unless there are going

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-22 Thread Joe Perches
On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote: > This patch adds just providers part of the framework just to enable easy > review. [] > include/linux/nvmem-provider.h | 54 ++ Unless there are going to be users of nvmem-provider.h outside of the drivers/nvmem directory,

[PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-22 Thread Srinivas Kandagatla
This patch adds just providers part of the framework just to enable easy review. Up until now, NVMEM drivers like eeprom were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they

[PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-22 Thread Srinivas Kandagatla
This patch adds just providers part of the framework just to enable easy review. Up until now, NVMEM drivers like eeprom were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they

Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-06-22 Thread Joe Perches
On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote: This patch adds just providers part of the framework just to enable easy review. [] include/linux/nvmem-provider.h | 54 ++ Unless there are going to be users of nvmem-provider.h outside of the drivers/nvmem directory, perhaps