Re: [PATCH v6 14/14] dt: qcom: Add qcom-cpufreq-kryo driver configuration

2018-05-14 Thread Viresh Kumar
On 14-05-18, 16:12, Ilia Lin wrote:
> Signed-off-by: Ilia Lin 
> ---
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts |   2 +-
>  arch/arm64/boot/dts/qcom/msm8996.dtsi   | 310 
> +++-
>  2 files changed, 309 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts 
> b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index 230e9c8..da23bda 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -17,5 +17,5 @@
>  
>  / {
>   model = "Qualcomm Technologies, Inc. DB820c";
> - compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc";
> + compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc", "qcom,apq8096";
>  };
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi 
> b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index d7adef9..fbf92f6 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -174,218 +174,519 @@
>   };
>  
>   cluster0_opp: opp_table0 {
> - compatible = "operating-points-v2";
> + compatible = "operating-points-v2-kryo-cpu";

I think you need to mention both the above compatible strings here
with the kyro one mentioned first.


-- 
viresh


Re: [PATCH v6 14/14] dt: qcom: Add qcom-cpufreq-kryo driver configuration

2018-05-14 Thread Viresh Kumar
On 14-05-18, 16:12, Ilia Lin wrote:
> Signed-off-by: Ilia Lin 
> ---
>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts |   2 +-
>  arch/arm64/boot/dts/qcom/msm8996.dtsi   | 310 
> +++-
>  2 files changed, 309 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts 
> b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index 230e9c8..da23bda 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -17,5 +17,5 @@
>  
>  / {
>   model = "Qualcomm Technologies, Inc. DB820c";
> - compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc";
> + compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc", "qcom,apq8096";
>  };
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi 
> b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index d7adef9..fbf92f6 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -174,218 +174,519 @@
>   };
>  
>   cluster0_opp: opp_table0 {
> - compatible = "operating-points-v2";
> + compatible = "operating-points-v2-kryo-cpu";

I think you need to mention both the above compatible strings here
with the kyro one mentioned first.


-- 
viresh


[PATCH v6 14/14] dt: qcom: Add qcom-cpufreq-kryo driver configuration

2018-05-14 Thread Ilia Lin
Signed-off-by: Ilia Lin 
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts |   2 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi   | 310 +++-
 2 files changed, 309 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts 
b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index 230e9c8..da23bda 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -17,5 +17,5 @@
 
 / {
model = "Qualcomm Technologies, Inc. DB820c";
-   compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc";
+   compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc", "qcom,apq8096";
 };
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi 
b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index d7adef9..fbf92f6 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -174,218 +174,519 @@
};
 
cluster0_opp: opp_table0 {
-   compatible = "operating-points-v2";
+   compatible = "operating-points-v2-kryo-cpu";
+   nvmem-cells = <_efuse>;
opp-shared;
 
opp-30720 {
opp-hz = /bits/ 64 <30720>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x77>;
+   clock-latency-ns = <20>;
+   };
+   opp-38400 {
+   opp-hz = /bits/ 64 <38400>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-42240 {
opp-hz = /bits/ 64 <42240>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-46080 {
+   opp-hz = /bits/ 64 <46080>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-48000 {
opp-hz = /bits/ 64 <48000>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-53760 {
+   opp-hz = /bits/ 64 <53760>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-55680 {
opp-hz = /bits/ 64 <55680>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-61440 {
+   opp-hz = /bits/ 64 <61440>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-65280 {
opp-hz = /bits/ 64 <65280>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-69120 {
+   opp-hz = /bits/ 64 <69120>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-72960 {
opp-hz = /bits/ 64 <72960>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-76800 {
+   opp-hz = /bits/ 64 <76800>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-84480 {
opp-hz = /bits/ 64 <84480>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x77>;
+   clock-latency-ns = <20>;
+   };
+   opp-90240 {
+   opp-hz = /bits/ 64 <90240>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = 

[PATCH v6 14/14] dt: qcom: Add qcom-cpufreq-kryo driver configuration

2018-05-14 Thread Ilia Lin
Signed-off-by: Ilia Lin 
---
 arch/arm64/boot/dts/qcom/apq8096-db820c.dts |   2 +-
 arch/arm64/boot/dts/qcom/msm8996.dtsi   | 310 +++-
 2 files changed, 309 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts 
b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index 230e9c8..da23bda 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -17,5 +17,5 @@
 
 / {
model = "Qualcomm Technologies, Inc. DB820c";
-   compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc";
+   compatible = "arrow,apq8096-db820c", "qcom,apq8096-sbc", "qcom,apq8096";
 };
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi 
b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index d7adef9..fbf92f6 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -174,218 +174,519 @@
};
 
cluster0_opp: opp_table0 {
-   compatible = "operating-points-v2";
+   compatible = "operating-points-v2-kryo-cpu";
+   nvmem-cells = <_efuse>;
opp-shared;
 
opp-30720 {
opp-hz = /bits/ 64 <30720>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x77>;
+   clock-latency-ns = <20>;
+   };
+   opp-38400 {
+   opp-hz = /bits/ 64 <38400>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-42240 {
opp-hz = /bits/ 64 <42240>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-46080 {
+   opp-hz = /bits/ 64 <46080>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-48000 {
opp-hz = /bits/ 64 <48000>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-53760 {
+   opp-hz = /bits/ 64 <53760>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-55680 {
opp-hz = /bits/ 64 <55680>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-61440 {
+   opp-hz = /bits/ 64 <61440>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-65280 {
opp-hz = /bits/ 64 <65280>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-69120 {
+   opp-hz = /bits/ 64 <69120>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-72960 {
opp-hz = /bits/ 64 <72960>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x7>;
+   clock-latency-ns = <20>;
+   };
+   opp-76800 {
+   opp-hz = /bits/ 64 <76800>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;
};
opp-84480 {
opp-hz = /bits/ 64 <84480>;
opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x77>;
+   clock-latency-ns = <20>;
+   };
+   opp-90240 {
+   opp-hz = /bits/ 64 <90240>;
+   opp-microvolt = <905000 905000 114>;
+   opp-supported-hw = <0x70>;
clock-latency-ns = <20>;