Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-11 Thread kbuild test robot
Hi Mario, [auto build test WARNING on platform-drivers-x86/for-next] [also build test WARNING on next-20171009] [cannot apply to v4.14-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mario-L

Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-11 Thread kbuild test robot
Hi Mario, [auto build test WARNING on platform-drivers-x86/for-next] [also build test WARNING on next-20171009] [cannot apply to v4.14-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mario-L

RE: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-10 Thread Mario.Limonciello
pali.ro...@gmail.com; r...@rjwysocki.net; mj...@google.com; h...@lst.de > Subject: Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce > userspace interface > > On Mon, Oct 09, 2017 at 05:51:52PM -0500, Mario Limonciello wrote: > > + ret = device_create_file(&wd

Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-10 Thread Greg KH
On Mon, Oct 09, 2017 at 05:51:52PM -0500, Mario Limonciello wrote: > + ret = device_create_file(&wdev->dev, &priv->req_buf_size_attr); > + if (ret) > + goto fail_create_sysfs; Why isn't the "WMI core" creating this sysfs file? Why have per-driver sysfs files, making all of the

[PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-09 Thread Mario Limonciello
It's important for the driver to provide a R/W ioctl to ensure that two competing userspace processes don't race to provide or read each others data. This userspace character device will be used to perform SMBIOS calls from any applications. It provides an ioctl that will allow passing the WMI ca