Re: [PATCH v6 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files
On 19 December 2013 00:41, Peter Crosthwaite wrote: >> + clocks { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + ref12: ref12M { >> + compatible = "fixed-clock"; > > Is the correct split to perhaps have the fixed-clock node in dtsi as > you have here but ... > >> + #clock-cells = <0>; >> + clock-frequency = <1200>; > > The board is responsible for the frequency? > > I guess in this schema, > > 1. the "fixed-clock" node corresponds to the existence of clock input > pins on the SoC level - hence the node is DTSI. > 2. setting the clock-frequency corresponds to populatation of those > input pins with a soldered crystal - hence done in DTS Yes, the soldered crystal belongs to board. Changes in v7 should reflect that. I tried to doing what you said above, it didn't quite work, I got the same error from of_clk_get() / of_clk_get_by_name(), but came up with another solution please have a look at v7. Thanks, Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files
On 19 December 2013 00:41, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: + clocks { + #address-cells = 1; + #size-cells = 0; + + ref12: ref12M { + compatible = fixed-clock; Is the correct split to perhaps have the fixed-clock node in dtsi as you have here but ... + #clock-cells = 0; + clock-frequency = 1200; The board is responsible for the frequency? I guess in this schema, 1. the fixed-clock node corresponds to the existence of clock input pins on the SoC level - hence the node is DTSI. 2. setting the clock-frequency corresponds to populatation of those input pins with a soldered crystal - hence done in DTS Yes, the soldered crystal belongs to board. Changes in v7 should reflect that. I tried to doing what you said above, it didn't quite work, I got the same error from of_clk_get() / of_clk_get_by_name(), but came up with another solution please have a look at v7. Thanks, Jonas -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files
On Wed, Dec 18, 2013 at 10:58 PM, Jonas Jensen wrote: > Add a generic (dtsi) include file for MOXA ART SoCs. > > Also add a file for UC-7112-LX. > > Signed-off-by: Jonas Jensen > --- > Documentation/devicetree/bindings/arm/moxart.txt | 12 ++ > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/moxart-uc7112lx.dts| 109 > arch/arm/boot/dts/moxart.dtsi| 154 > +++ > 4 files changed, 276 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/moxart.txt > create mode 100644 arch/arm/boot/dts/moxart-uc7112lx.dts > create mode 100644 arch/arm/boot/dts/moxart.dtsi > > diff --git a/Documentation/devicetree/bindings/arm/moxart.txt > b/Documentation/devicetree/bindings/arm/moxart.txt > new file mode 100644 > index 000..11087ed > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/moxart.txt > @@ -0,0 +1,12 @@ > +MOXA ART device tree bindings > + > +Boards with the MOXA ART SoC shall have the following properties: > + > +Required root node property: > + > +compatible = "moxa,moxart"; > + > +Boards: > + > +- UC-7112-LX: embedded computer > + compatible = "moxa,moxart-uc-7112-lx", "moxa,moxart" > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 16f0c5c..b95a9c6 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -110,6 +110,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ > kirkwood-ts219-6281.dtb \ > kirkwood-ts219-6282.dtb > dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb > +dtb-$(CONFIG_ARCH_MOXART) += moxart-uc7112lx.dtb > dtb-$(CONFIG_ARCH_MSM) += qcom-msm8660-surf.dtb \ > qcom-msm8960-cdp.dtb > dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \ > diff --git a/arch/arm/boot/dts/moxart-uc7112lx.dts > b/arch/arm/boot/dts/moxart-uc7112lx.dts > new file mode 100644 > index 000..90749d5 > --- /dev/null > +++ b/arch/arm/boot/dts/moxart-uc7112lx.dts > @@ -0,0 +1,109 @@ > +/* moxart-uc7112lx.dts - Device Tree file for MOXA UC-7112-LX > + * > + * Copyright (C) 2013 Jonas Jensen > + * > + * Licensed under GPLv2 or later. > + */ > + > +/dts-v1/; > +/include/ "moxart.dtsi" > + > +/ { > + model = "MOXA UC-7112-LX"; > + compatible = "moxa,moxart-uc-7112-lx", "moxa,moxart"; > + > + memory { > + device_type = "memory"; > + reg = <0x0 0x200>; > + }; > + > + flash@8000,0 { > + compatible = "numonyx,js28f128", "cfi-flash"; > + reg = <0x8000 0x100>; > + bank-width = <2>; > + #address-cells = <1>; > + #size-cells = <1>; > + partition@0 { > + label = "bootloader"; > + reg = <0x0 0x4>; > + }; > + partition@4 { > + label = "linux kernel"; > + reg = <0x4 0x1C>; > + }; > + partition@20 { > + label = "root filesystem"; > + reg = <0x20 0x80>; > + }; > + partition@a0 { > + label = "user filesystem"; > + reg = <0xa0 0x60>; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + user-led { > + label = "ready-led"; > + gpios = < 27 0x1>; > + default-state = "on"; > + linux,default-trigger = "default-on"; > + }; > + }; > + > + gpio_keys_polled { > + compatible = "gpio-keys-polled"; > + #address-cells = <1>; > + #size-cells = <0>; > + poll-interval = <500>; > + button@25 { > + label = "GPIO Reset"; > + linux,code = <116>; > + gpios = < 25 1>; > + }; > + }; > + > + chosen { > + bootargs = "console=ttyS0,115200n8 earlyprintk > root=/dev/mmcblk0p1 rw rootwait"; > + }; > +}; > + > +_pll { > + clocks = <>; > +}; > + > + { > + status = "okay"; > +}; > + > + { > + status = "okay"; > + > + ethphy0: ethernet-phy@1 { > + device_type = "ethernet-phy"; > + compatible = "moxa,moxart-rtl8201cp", > "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + }; > +}; > + > + { > + status = "okay"; > + > + ethphy1: ethernet-phy@1 { > + device_type = "ethernet-phy"; > + compatible = "moxa,moxart-rtl8201cp", > "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + }; You phy stuff looks good to me, thanks for the changes. > +}; > + > + { > + status = "okay"; > +}; > + > + { > + status = "okay"; > +}; > + > + {
[PATCH v6 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files
Add a generic (dtsi) include file for MOXA ART SoCs. Also add a file for UC-7112-LX. Signed-off-by: Jonas Jensen --- Documentation/devicetree/bindings/arm/moxart.txt | 12 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/moxart-uc7112lx.dts| 109 arch/arm/boot/dts/moxart.dtsi| 154 +++ 4 files changed, 276 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/moxart.txt create mode 100644 arch/arm/boot/dts/moxart-uc7112lx.dts create mode 100644 arch/arm/boot/dts/moxart.dtsi diff --git a/Documentation/devicetree/bindings/arm/moxart.txt b/Documentation/devicetree/bindings/arm/moxart.txt new file mode 100644 index 000..11087ed --- /dev/null +++ b/Documentation/devicetree/bindings/arm/moxart.txt @@ -0,0 +1,12 @@ +MOXA ART device tree bindings + +Boards with the MOXA ART SoC shall have the following properties: + +Required root node property: + +compatible = "moxa,moxart"; + +Boards: + +- UC-7112-LX: embedded computer + compatible = "moxa,moxart-uc-7112-lx", "moxa,moxart" diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 16f0c5c..b95a9c6 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -110,6 +110,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb +dtb-$(CONFIG_ARCH_MOXART) += moxart-uc7112lx.dtb dtb-$(CONFIG_ARCH_MSM) += qcom-msm8660-surf.dtb \ qcom-msm8960-cdp.dtb dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \ diff --git a/arch/arm/boot/dts/moxart-uc7112lx.dts b/arch/arm/boot/dts/moxart-uc7112lx.dts new file mode 100644 index 000..90749d5 --- /dev/null +++ b/arch/arm/boot/dts/moxart-uc7112lx.dts @@ -0,0 +1,109 @@ +/* moxart-uc7112lx.dts - Device Tree file for MOXA UC-7112-LX + * + * Copyright (C) 2013 Jonas Jensen + * + * Licensed under GPLv2 or later. + */ + +/dts-v1/; +/include/ "moxart.dtsi" + +/ { + model = "MOXA UC-7112-LX"; + compatible = "moxa,moxart-uc-7112-lx", "moxa,moxart"; + + memory { + device_type = "memory"; + reg = <0x0 0x200>; + }; + + flash@8000,0 { + compatible = "numonyx,js28f128", "cfi-flash"; + reg = <0x8000 0x100>; + bank-width = <2>; + #address-cells = <1>; + #size-cells = <1>; + partition@0 { + label = "bootloader"; + reg = <0x0 0x4>; + }; + partition@4 { + label = "linux kernel"; + reg = <0x4 0x1C>; + }; + partition@20 { + label = "root filesystem"; + reg = <0x20 0x80>; + }; + partition@a0 { + label = "user filesystem"; + reg = <0xa0 0x60>; + }; + }; + + leds { + compatible = "gpio-leds"; + user-led { + label = "ready-led"; + gpios = < 27 0x1>; + default-state = "on"; + linux,default-trigger = "default-on"; + }; + }; + + gpio_keys_polled { + compatible = "gpio-keys-polled"; + #address-cells = <1>; + #size-cells = <0>; + poll-interval = <500>; + button@25 { + label = "GPIO Reset"; + linux,code = <116>; + gpios = < 25 1>; + }; + }; + + chosen { + bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/mmcblk0p1 rw rootwait"; + }; +}; + +_pll { + clocks = <>; +}; + + { + status = "okay"; +}; + + { + status = "okay"; + + ethphy0: ethernet-phy@1 { + device_type = "ethernet-phy"; + compatible = "moxa,moxart-rtl8201cp", "ethernet-phy-ieee802.3-c22"; + reg = <1>; + }; +}; + + { + status = "okay"; + + ethphy1: ethernet-phy@1 { + device_type = "ethernet-phy"; + compatible = "moxa,moxart-rtl8201cp", "ethernet-phy-ieee802.3-c22"; + reg = <1>; + }; +}; + + { + status = "okay"; +}; + + { + status = "okay"; +}; + + { + status = "okay"; +}; diff --git a/arch/arm/boot/dts/moxart.dtsi b/arch/arm/boot/dts/moxart.dtsi new file mode 100644 index 000..da1d8ef --- /dev/null +++ b/arch/arm/boot/dts/moxart.dtsi @@ -0,0 +1,154 @@ +/* moxart.dtsi - Device Tree Include file for MOXA ART family SoC + * + * Copyright (C) 2013 Jonas Jensen + * + * Licensed under GPLv2 or later. + */ + +/include/ "skeleton.dtsi" + +/ { + compatible = "moxa,moxart";
[PATCH v6 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files
Add a generic (dtsi) include file for MOXA ART SoCs. Also add a file for UC-7112-LX. Signed-off-by: Jonas Jensen jonas.jen...@gmail.com --- Documentation/devicetree/bindings/arm/moxart.txt | 12 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/moxart-uc7112lx.dts| 109 arch/arm/boot/dts/moxart.dtsi| 154 +++ 4 files changed, 276 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/moxart.txt create mode 100644 arch/arm/boot/dts/moxart-uc7112lx.dts create mode 100644 arch/arm/boot/dts/moxart.dtsi diff --git a/Documentation/devicetree/bindings/arm/moxart.txt b/Documentation/devicetree/bindings/arm/moxart.txt new file mode 100644 index 000..11087ed --- /dev/null +++ b/Documentation/devicetree/bindings/arm/moxart.txt @@ -0,0 +1,12 @@ +MOXA ART device tree bindings + +Boards with the MOXA ART SoC shall have the following properties: + +Required root node property: + +compatible = moxa,moxart; + +Boards: + +- UC-7112-LX: embedded computer + compatible = moxa,moxart-uc-7112-lx, moxa,moxart diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 16f0c5c..b95a9c6 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -110,6 +110,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb +dtb-$(CONFIG_ARCH_MOXART) += moxart-uc7112lx.dtb dtb-$(CONFIG_ARCH_MSM) += qcom-msm8660-surf.dtb \ qcom-msm8960-cdp.dtb dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \ diff --git a/arch/arm/boot/dts/moxart-uc7112lx.dts b/arch/arm/boot/dts/moxart-uc7112lx.dts new file mode 100644 index 000..90749d5 --- /dev/null +++ b/arch/arm/boot/dts/moxart-uc7112lx.dts @@ -0,0 +1,109 @@ +/* moxart-uc7112lx.dts - Device Tree file for MOXA UC-7112-LX + * + * Copyright (C) 2013 Jonas Jensen jonas.jen...@gmail.com + * + * Licensed under GPLv2 or later. + */ + +/dts-v1/; +/include/ moxart.dtsi + +/ { + model = MOXA UC-7112-LX; + compatible = moxa,moxart-uc-7112-lx, moxa,moxart; + + memory { + device_type = memory; + reg = 0x0 0x200; + }; + + flash@8000,0 { + compatible = numonyx,js28f128, cfi-flash; + reg = 0x8000 0x100; + bank-width = 2; + #address-cells = 1; + #size-cells = 1; + partition@0 { + label = bootloader; + reg = 0x0 0x4; + }; + partition@4 { + label = linux kernel; + reg = 0x4 0x1C; + }; + partition@20 { + label = root filesystem; + reg = 0x20 0x80; + }; + partition@a0 { + label = user filesystem; + reg = 0xa0 0x60; + }; + }; + + leds { + compatible = gpio-leds; + user-led { + label = ready-led; + gpios = gpio 27 0x1; + default-state = on; + linux,default-trigger = default-on; + }; + }; + + gpio_keys_polled { + compatible = gpio-keys-polled; + #address-cells = 1; + #size-cells = 0; + poll-interval = 500; + button@25 { + label = GPIO Reset; + linux,code = 116; + gpios = gpio 25 1; + }; + }; + + chosen { + bootargs = console=ttyS0,115200n8 earlyprintk root=/dev/mmcblk0p1 rw rootwait; + }; +}; + +clk_pll { + clocks = ref12; +}; + +sdhci { + status = okay; +}; + +mdio0 { + status = okay; + + ethphy0: ethernet-phy@1 { + device_type = ethernet-phy; + compatible = moxa,moxart-rtl8201cp, ethernet-phy-ieee802.3-c22; + reg = 1; + }; +}; + +mdio1 { + status = okay; + + ethphy1: ethernet-phy@1 { + device_type = ethernet-phy; + compatible = moxa,moxart-rtl8201cp, ethernet-phy-ieee802.3-c22; + reg = 1; + }; +}; + +mac0 { + status = okay; +}; + +mac1 { + status = okay; +}; + +uart0 { + status = okay; +}; diff --git a/arch/arm/boot/dts/moxart.dtsi b/arch/arm/boot/dts/moxart.dtsi new file mode 100644 index 000..da1d8ef --- /dev/null +++ b/arch/arm/boot/dts/moxart.dtsi @@ -0,0 +1,154 @@ +/* moxart.dtsi - Device Tree Include file for MOXA ART family SoC + * + * Copyright (C) 2013 Jonas Jensen jonas.jen...@gmail.com + * + * Licensed under GPLv2 or later. + */ + +/include/ skeleton.dtsi + +/ { + compatible =
Re: [PATCH v6 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files
On Wed, Dec 18, 2013 at 10:58 PM, Jonas Jensen jonas.jen...@gmail.com wrote: Add a generic (dtsi) include file for MOXA ART SoCs. Also add a file for UC-7112-LX. Signed-off-by: Jonas Jensen jonas.jen...@gmail.com --- Documentation/devicetree/bindings/arm/moxart.txt | 12 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/moxart-uc7112lx.dts| 109 arch/arm/boot/dts/moxart.dtsi| 154 +++ 4 files changed, 276 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/moxart.txt create mode 100644 arch/arm/boot/dts/moxart-uc7112lx.dts create mode 100644 arch/arm/boot/dts/moxart.dtsi diff --git a/Documentation/devicetree/bindings/arm/moxart.txt b/Documentation/devicetree/bindings/arm/moxart.txt new file mode 100644 index 000..11087ed --- /dev/null +++ b/Documentation/devicetree/bindings/arm/moxart.txt @@ -0,0 +1,12 @@ +MOXA ART device tree bindings + +Boards with the MOXA ART SoC shall have the following properties: + +Required root node property: + +compatible = moxa,moxart; + +Boards: + +- UC-7112-LX: embedded computer + compatible = moxa,moxart-uc-7112-lx, moxa,moxart diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 16f0c5c..b95a9c6 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -110,6 +110,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb +dtb-$(CONFIG_ARCH_MOXART) += moxart-uc7112lx.dtb dtb-$(CONFIG_ARCH_MSM) += qcom-msm8660-surf.dtb \ qcom-msm8960-cdp.dtb dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \ diff --git a/arch/arm/boot/dts/moxart-uc7112lx.dts b/arch/arm/boot/dts/moxart-uc7112lx.dts new file mode 100644 index 000..90749d5 --- /dev/null +++ b/arch/arm/boot/dts/moxart-uc7112lx.dts @@ -0,0 +1,109 @@ +/* moxart-uc7112lx.dts - Device Tree file for MOXA UC-7112-LX + * + * Copyright (C) 2013 Jonas Jensen jonas.jen...@gmail.com + * + * Licensed under GPLv2 or later. + */ + +/dts-v1/; +/include/ moxart.dtsi + +/ { + model = MOXA UC-7112-LX; + compatible = moxa,moxart-uc-7112-lx, moxa,moxart; + + memory { + device_type = memory; + reg = 0x0 0x200; + }; + + flash@8000,0 { + compatible = numonyx,js28f128, cfi-flash; + reg = 0x8000 0x100; + bank-width = 2; + #address-cells = 1; + #size-cells = 1; + partition@0 { + label = bootloader; + reg = 0x0 0x4; + }; + partition@4 { + label = linux kernel; + reg = 0x4 0x1C; + }; + partition@20 { + label = root filesystem; + reg = 0x20 0x80; + }; + partition@a0 { + label = user filesystem; + reg = 0xa0 0x60; + }; + }; + + leds { + compatible = gpio-leds; + user-led { + label = ready-led; + gpios = gpio 27 0x1; + default-state = on; + linux,default-trigger = default-on; + }; + }; + + gpio_keys_polled { + compatible = gpio-keys-polled; + #address-cells = 1; + #size-cells = 0; + poll-interval = 500; + button@25 { + label = GPIO Reset; + linux,code = 116; + gpios = gpio 25 1; + }; + }; + + chosen { + bootargs = console=ttyS0,115200n8 earlyprintk root=/dev/mmcblk0p1 rw rootwait; + }; +}; + +clk_pll { + clocks = ref12; +}; + +sdhci { + status = okay; +}; + +mdio0 { + status = okay; + + ethphy0: ethernet-phy@1 { + device_type = ethernet-phy; + compatible = moxa,moxart-rtl8201cp, ethernet-phy-ieee802.3-c22; + reg = 1; + }; +}; + +mdio1 { + status = okay; + + ethphy1: ethernet-phy@1 { + device_type = ethernet-phy; + compatible = moxa,moxart-rtl8201cp, ethernet-phy-ieee802.3-c22; + reg = 1; + }; You phy stuff looks good to me, thanks for the changes. +}; + +mac0 { + status = okay; +}; + +mac1 { + status = okay; +}; + +uart0 { + status = okay; +}; diff --git a/arch/arm/boot/dts/moxart.dtsi b/arch/arm/boot/dts/moxart.dtsi new file mode 100644 index 000..da1d8ef