Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-13 Thread Xiao Guangrong
On 08/11/2012 04:37 AM, David Ahern wrote: > Thanks for resubmitting this; it was on my to-do list as well. Thanks for you liking it and your precious comments, David! :) > > On 8/9/12 9:19 PM, Dong Hao wrote: >> +static bool kvm_events_exist(const char *event) >> +{ >> +char

Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-13 Thread Xiao Guangrong
On 08/10/2012 10:14 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 10, 2012 at 11:19:10AM +0800, Dong Hao escreveu: >> From: Xiao Guangrong >> >> Add 'perf kvm stat' support to analyze kvm vmexit/mmio/ioport smartly. > > Some comments below about recent changes in my perf/core branch.

Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-13 Thread Xiao Guangrong
On 08/10/2012 10:14 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 10, 2012 at 11:19:10AM +0800, Dong Hao escreveu: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Add 'perf kvm stat' support to analyze kvm vmexit/mmio/ioport smartly. Some comments below about recent changes in my

Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-13 Thread Xiao Guangrong
On 08/11/2012 04:37 AM, David Ahern wrote: Thanks for resubmitting this; it was on my to-do list as well. Thanks for you liking it and your precious comments, David! :) On 8/9/12 9:19 PM, Dong Hao wrote: +static bool kvm_events_exist(const char *event) +{ +char evt_path[MAXPATHLEN];

Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-10 Thread David Ahern
Thanks for resubmitting this; it was on my to-do list as well. On 8/9/12 9:19 PM, Dong Hao wrote: +static bool kvm_events_exist(const char *event) +{ + char evt_path[MAXPATHLEN]; + int fd; + + snprintf(evt_path, MAXPATHLEN, "%s/kvm/%s/id", tracing_events_path, +

Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-10 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 10, 2012 at 11:19:10AM +0800, Dong Hao escreveu: > From: Xiao Guangrong > > Add 'perf kvm stat' support to analyze kvm vmexit/mmio/ioport smartly. Some comments below about recent changes in my perf/core branch. > +static void process_raw_event(struct thread *thread, void *data, u64

Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-10 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 10, 2012 at 11:19:10AM +0800, Dong Hao escreveu: From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Add 'perf kvm stat' support to analyze kvm vmexit/mmio/ioport smartly. Some comments below about recent changes in my perf/core branch. +static void process_raw_event(struct

Re: [PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-10 Thread David Ahern
Thanks for resubmitting this; it was on my to-do list as well. On 8/9/12 9:19 PM, Dong Hao wrote: +static bool kvm_events_exist(const char *event) +{ + char evt_path[MAXPATHLEN]; + int fd; + + snprintf(evt_path, MAXPATHLEN, %s/kvm/%s/id, tracing_events_path, +

[PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-09 Thread Dong Hao
From: Xiao Guangrong Add 'perf kvm stat' support to analyze kvm vmexit/mmio/ioport smartly. Usage: - kvm stat run a command and gather performance counter statistics, it is the alias of perf stat - trace kvm events: perf kvm stat record, or, if other tracepoints are interesting as well,

[PATCH v6 3/3] KVM: perf kvm events analysis tool

2012-08-09 Thread Dong Hao
From: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com Add 'perf kvm stat' support to analyze kvm vmexit/mmio/ioport smartly. Usage: - kvm stat run a command and gather performance counter statistics, it is the alias of perf stat - trace kvm events: perf kvm stat record, or, if other