Re: [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues

2014-06-17 Thread Anil Shashikumar Belur
> If you are using min_t(__u32, ...) then there is no need for the (__u32) cast of LOV_MAX_STRIPE_COUNT, since that is the whole point of min_t() that the cast is done internally. Agreed, it makes sense not to cast twice when using min_t(). -- To unsubscribe from this list: send the line

Re: [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues

2014-06-17 Thread Dilger, Andreas
On 2014/06/16, 11:43 PM, "Anil Belur" wrote: >From: Anil Belur > >fixed warning: >* WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, >LOV_MAX_STRIPE_COUNT) > >Signed-off-by: Anil Belur >--- > drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 2 +- > 1 file changed, 1

Re: [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues

2014-06-17 Thread Dilger, Andreas
On 2014/06/16, 11:43 PM, Anil Belur ask...@gmail.com wrote: From: Anil Belur ask...@gmail.com fixed warning: * WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, LOV_MAX_STRIPE_COUNT) Signed-off-by: Anil Belur ask...@gmail.com ---

Re: [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues

2014-06-17 Thread Anil Shashikumar Belur
If you are using min_t(__u32, ...) then there is no need for the (__u32) cast of LOV_MAX_STRIPE_COUNT, since that is the whole point of min_t() that the cast is done internally. Agreed, it makes sense not to cast twice when using min_t(). -- To unsubscribe from this list: send the line

[PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues

2014-06-16 Thread Anil Belur
From: Anil Belur fixed warning: * WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, LOV_MAX_STRIPE_COUNT) Signed-off-by: Anil Belur --- drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues

2014-06-16 Thread Anil Belur
From: Anil Belur ask...@gmail.com fixed warning: * WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, LOV_MAX_STRIPE_COUNT) Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)