Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-27 Thread Sudeep Holla
On 27/06/16 18:07, Sudeep Holla wrote: On 27/06/16 17:29, Daniel Lezcano wrote: [...] acpi_disabled - acpi_disabled - acpi_disabled everywhere :/ The enable-method approach is not straightforward and now it is polluted by acpi-disabled. So IIUC, smp_init_cpus (contains acpi_disabled)

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-27 Thread Sudeep Holla
On 27/06/16 18:07, Sudeep Holla wrote: On 27/06/16 17:29, Daniel Lezcano wrote: [...] acpi_disabled - acpi_disabled - acpi_disabled everywhere :/ The enable-method approach is not straightforward and now it is polluted by acpi-disabled. So IIUC, smp_init_cpus (contains acpi_disabled)

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-27 Thread Sudeep Holla
On 27/06/16 17:29, Daniel Lezcano wrote: On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote: Hi Sudeep, On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: This patch adds appropriate callbacks to support ACPI Low Power Idle (LPI) on ARM64. Now that arm_enter_idle_state is exactly

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-27 Thread Sudeep Holla
On 27/06/16 17:29, Daniel Lezcano wrote: On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote: Hi Sudeep, On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: This patch adds appropriate callbacks to support ACPI Low Power Idle (LPI) on ARM64. Now that arm_enter_idle_state is exactly

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-27 Thread Daniel Lezcano
On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote: Hi Sudeep, On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: This patch adds appropriate callbacks to support ACPI Low Power Idle (LPI) on ARM64. Now that arm_enter_idle_state is exactly same in both generic ARM{32,64} CPUIdle

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-27 Thread Daniel Lezcano
On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote: Hi Sudeep, On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: This patch adds appropriate callbacks to support ACPI Low Power Idle (LPI) on ARM64. Now that arm_enter_idle_state is exactly same in both generic ARM{32,64} CPUIdle

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-27 Thread Sudeep Holla
Hi, Daniel, On 24/06/16 22:04, Daniel Lezcano wrote: [...] + +psci_states = kcalloc(count, sizeof(*psci_states), GFP_KERNEL); +if (!psci_states) +return -ENOMEM; + +for (i = 0; i < count; i++) { +u32 state; + +lpi = >power.lpi_states[i + 1]; +state

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-27 Thread Sudeep Holla
Hi, Daniel, On 24/06/16 22:04, Daniel Lezcano wrote: [...] + +psci_states = kcalloc(count, sizeof(*psci_states), GFP_KERNEL); +if (!psci_states) +return -ENOMEM; + +for (i = 0; i < count; i++) { +u32 state; + +lpi = >power.lpi_states[i + 1]; +state

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-25 Thread Daniel Lezcano
On 06/25/2016 12:47 AM, Rafael J. Wysocki wrote: [ ... ] + if (!acpi_disabled) + return psci_acpi_cpu_init_idle(cpu); Is it possible the case where there is information in both the DT and in ACPI ? No, it isn't. It is either-or, never both at the same time. Ok,

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-25 Thread Daniel Lezcano
On 06/25/2016 12:47 AM, Rafael J. Wysocki wrote: [ ... ] + if (!acpi_disabled) + return psci_acpi_cpu_init_idle(cpu); Is it possible the case where there is information in both the DT and in ACPI ? No, it isn't. It is either-or, never both at the same time. Ok,

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-24 Thread Rafael J. Wysocki
On Friday, June 24, 2016 11:04:07 PM Daniel Lezcano wrote: > On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote: > > Hi Sudeep, > > > > On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: > >> This patch adds appropriate callbacks to support ACPI Low Power Idle > >> (LPI) on ARM64. > >> >

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-24 Thread Rafael J. Wysocki
On Friday, June 24, 2016 11:04:07 PM Daniel Lezcano wrote: > On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote: > > Hi Sudeep, > > > > On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: > >> This patch adds appropriate callbacks to support ACPI Low Power Idle > >> (LPI) on ARM64. > >> >

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-24 Thread Daniel Lezcano
On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote: Hi Sudeep, On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: This patch adds appropriate callbacks to support ACPI Low Power Idle (LPI) on ARM64. Now that arm_enter_idle_state is exactly same in both generic ARM{32,64} CPUIdle

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-24 Thread Daniel Lezcano
On 06/22/2016 04:17 PM, Lorenzo Pieralisi wrote: Hi Sudeep, On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: This patch adds appropriate callbacks to support ACPI Low Power Idle (LPI) on ARM64. Now that arm_enter_idle_state is exactly same in both generic ARM{32,64} CPUIdle

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-22 Thread Lorenzo Pieralisi
Hi Sudeep, On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: > This patch adds appropriate callbacks to support ACPI Low Power Idle > (LPI) on ARM64. > > Now that arm_enter_idle_state is exactly same in both generic ARM{32,64} > CPUIdle driver and ARM64 backend for ACPI processor

Re: [PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-22 Thread Lorenzo Pieralisi
Hi Sudeep, On Tue, Jun 14, 2016 at 03:48:38PM +0100, Sudeep Holla wrote: > This patch adds appropriate callbacks to support ACPI Low Power Idle > (LPI) on ARM64. > > Now that arm_enter_idle_state is exactly same in both generic ARM{32,64} > CPUIdle driver and ARM64 backend for ACPI processor

[PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-14 Thread Sudeep Holla
This patch adds appropriate callbacks to support ACPI Low Power Idle (LPI) on ARM64. Now that arm_enter_idle_state is exactly same in both generic ARM{32,64} CPUIdle driver and ARM64 backend for ACPI processor idle driver, we can unify it and move to cpuidle-arm.h header. Cc: Lorenzo Pieralisi

[PATCH v6 4/5] arm64: add support for ACPI Low Power Idle(LPI)

2016-06-14 Thread Sudeep Holla
This patch adds appropriate callbacks to support ACPI Low Power Idle (LPI) on ARM64. Now that arm_enter_idle_state is exactly same in both generic ARM{32,64} CPUIdle driver and ARM64 backend for ACPI processor idle driver, we can unify it and move to cpuidle-arm.h header. Cc: Lorenzo Pieralisi