RE: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Ryan Chen
lt;j...@jms.id.au>; > Vladimir Zapolskiy <v...@mleia.com>; Kachalov Anton <mo...@mayc.ru>; > Cédric Le Goater <c...@kaod.org>; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; Linux Kernel Mailing List > <linux-kernel@vger.kernel.or

RE: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Ryan Chen
as > Gleixner ; Jason Cooper ; > Marc Zyngier ; Joel Stanley ; > Vladimir Zapolskiy ; Kachalov Anton ; > Cédric Le Goater ; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; Linux Kernel Mailing List > ; OpenBMC Maillist > > Subject: Re: [PA

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Brendan Higgins
s.id.au>; Vladimir Zapolskiy <v...@mleia.com>; Kachalov Anton > <mo...@mayc.ru>; Cédric Le Goater <c...@kaod.org>; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; Linux Kernel Mailing List > <linux-kernel@vger.kernel.org>; OpenBMC Maillist <open.

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Brendan Higgins
ngier ; Joel > Stanley ; Vladimir Zapolskiy ; Kachalov Anton > ; Cédric Le Goater ; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; Linux Kernel Mailing List > ; OpenBMC Maillist > Subject: Re: [PATCH v6 4/5] i2c: aspeed: added driver for Asp

RE: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Ryan Chen
olskiy <v...@mleia.com>; Kachalov Anton <mo...@mayc.ru>; Cédric Le Goater <c...@kaod.org>; linux-...@vger.kernel.org; devicet...@vger.kernel.org; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; OpenBMC Maillist <open...@lists.ozlabs.org> Subject: Re: [PATCH

RE: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Ryan Chen
per ; Marc Zyngier ; Joel Stanley ; Vladimir Zapolskiy ; Kachalov Anton ; Cédric Le Goater ; linux-...@vger.kernel.org; devicet...@vger.kernel.org; Linux Kernel Mailing List ; OpenBMC Maillist Subject: Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C On Tue, 2017-04-25 at 08:50 +

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Benjamin Herrenschmidt
ngier i...@arm.com>; Joel Stanley <j...@jms.id.au>; Vladimir Zapolskiy <vz@m > leia.com>; Kachalov Anton <mo...@mayc.ru>; Cédric Le Goater <clg@kaod > .org>; linux-...@vger.kernel.org; devicet...@vger.kernel.org; Linux > Kernel Mailing List <linux-kernel@vger

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Benjamin Herrenschmidt
t; To: Benjamin Herrenschmidt > Cc: Wolfram Sang ; Rob Herring >; Mark Rutland ; Thomas Gleixner nix.de>; Jason Cooper ; Marc Zyngier i...@arm.com>; Joel Stanley ; Vladimir Zapolskiy leia.com>; Kachalov Anton ; Cédric Le Goater .org>; linux-...@vger.kernel.org; devicet...@vger.kern

RE: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Ryan Chen
t;v...@mleia.com>; Kachalov Anton <mo...@mayc.ru>; Cédric Le Goater <c...@kaod.org>; linux-...@vger.kernel.org; devicet...@vger.kernel.org; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; OpenBMC Maillist <open...@lists.ozlabs.org>; Ryan Chen <ryan_c

RE: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Ryan Chen
mas Gleixner ; Jason Cooper ; Marc Zyngier ; Joel Stanley ; Vladimir Zapolskiy ; Kachalov Anton ; Cédric Le Goater ; linux-...@vger.kernel.org; devicet...@vger.kernel.org; Linux Kernel Mailing List ; OpenBMC Maillist ; Ryan Chen Subject: Re: [PATCH v6 4/5] i2c: aspeed: added driver for Asp

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Brendan Higgins
Adding Ryan. On Mon, Apr 24, 2017 at 7:19 PM, Benjamin Herrenschmidt wrote: > On Mon, 2017-04-24 at 11:56 -0700, Brendan Higgins wrote: >> > > +struct aspeed_i2c_bus { >> > > + struct i2c_adapter adap; >> > > + struct device *dev;

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-25 Thread Brendan Higgins
Adding Ryan. On Mon, Apr 24, 2017 at 7:19 PM, Benjamin Herrenschmidt wrote: > On Mon, 2017-04-24 at 11:56 -0700, Brendan Higgins wrote: >> > > +struct aspeed_i2c_bus { >> > > + struct i2c_adapter adap; >> > > + struct device *dev; >> > > + void __iomem

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-24 Thread Benjamin Herrenschmidt
On Mon, 2017-04-24 at 11:56 -0700, Brendan Higgins wrote: > > > +struct aspeed_i2c_bus { > > > + struct i2c_adapter  adap; > > > + struct device   *dev; > > > + void __iomem*base; > > > + /* Synchronizes I/O mem access to base. */ > >

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-24 Thread Benjamin Herrenschmidt
On Mon, 2017-04-24 at 11:56 -0700, Brendan Higgins wrote: > > > +struct aspeed_i2c_bus { > > > + struct i2c_adapter  adap; > > > + struct device   *dev; > > > + void __iomem*base; > > > + /* Synchronizes I/O mem access to base. */ > >

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-24 Thread Brendan Higgins
>> +struct aspeed_i2c_bus { >> + struct i2c_adapter adap; >> + struct device *dev; >> + void __iomem*base; >> + /* Synchronizes I/O mem access to base. */ >> + spinlock_t lock; > > I am not entirely

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-04-24 Thread Brendan Higgins
>> +struct aspeed_i2c_bus { >> + struct i2c_adapter adap; >> + struct device *dev; >> + void __iomem*base; >> + /* Synchronizes I/O mem access to base. */ >> + spinlock_t lock; > > I am not entirely

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-31 Thread Benjamin Herrenschmidt
Allright, I finally found some time for reviewing some of this after splitting the ftgmac100 patch into 54 smaller ones :) On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: .../... > +struct aspeed_i2c_bus { > + struct i2c_adapter adap; > + struct device

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-31 Thread Benjamin Herrenschmidt
Allright, I finally found some time for reviewing some of this after splitting the ftgmac100 patch into 54 smaller ones :) On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: .../... > +struct aspeed_i2c_bus { > + struct i2c_adapter adap; > + struct device

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-30 Thread Joel Stanley
On Tue, Mar 28, 2017 at 3:42 PM, Brendan Higgins wrote: > Added initial master support for Aspeed I2C controller. Supports > fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Mention that the driver supports byte at a time access only at this stage. >

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-30 Thread Joel Stanley
On Tue, Mar 28, 2017 at 3:42 PM, Brendan Higgins wrote: > Added initial master support for Aspeed I2C controller. Supports > fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Mention that the driver supports byte at a time access only at this stage. > Signed-off-by: Brendan

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-29 Thread Brendan Higgins
>> + ASPEED_I2CD_M_HIGH_SPEED_EN | >> + ASPEED_I2CD_M_SDA_DRIVE_1T_EN | > > s/ASPEED_I2CD_M_SDA_DRIVE_1T_EN/ASPEED_I2CD_M_SCL_DRIVE_1T_EN/ > > (and in the definition too) Will fix. > >> +

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-29 Thread Brendan Higgins
>> + ASPEED_I2CD_M_HIGH_SPEED_EN | >> + ASPEED_I2CD_M_SDA_DRIVE_1T_EN | > > s/ASPEED_I2CD_M_SDA_DRIVE_1T_EN/ASPEED_I2CD_M_SCL_DRIVE_1T_EN/ > > (and in the definition too) Will fix. > >> +

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-28 Thread Benjamin Herrenschmidt
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: > +   /* Set AC Timing */ > +   if (clk_freq / 1000 > 1000) { > +   aspeed_i2c_write(bus, aspeed_i2c_read(bus, > + > ASPEED_I2C_FUN_CTRL_REG) | > + 

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-28 Thread Benjamin Herrenschmidt
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: > +   /* Set AC Timing */ > +   if (clk_freq / 1000 > 1000) { > +   aspeed_i2c_write(bus, aspeed_i2c_read(bus, > + > ASPEED_I2C_FUN_CTRL_REG) | > + 

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-28 Thread Benjamin Herrenschmidt
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: > +/* 0x04 : I2CD Clock and AC Timing Control Register #1 */ > +#define ASPEED_I2CD_TIME_SCL_HIGH_SHIFT16 > +#define ASPEED_I2CD_TIME_SCL_HIGH_MASK GENMASK(19, 16) > +#define

Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-28 Thread Benjamin Herrenschmidt
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote: > +/* 0x04 : I2CD Clock and AC Timing Control Register #1 */ > +#define ASPEED_I2CD_TIME_SCL_HIGH_SHIFT16 > +#define ASPEED_I2CD_TIME_SCL_HIGH_MASK GENMASK(19, 16) > +#define

[PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-27 Thread Brendan Higgins
Added initial master support for Aspeed I2C controller. Supports fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Signed-off-by: Brendan Higgins --- Changes for v2: - Added single module_init (multiple was breaking some builds). Changes for v3: -

[PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C

2017-03-27 Thread Brendan Higgins
Added initial master support for Aspeed I2C controller. Supports fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed. Signed-off-by: Brendan Higgins --- Changes for v2: - Added single module_init (multiple was breaking some builds). Changes for v3: - Removed "bus" device tree