lt;j...@jms.id.au>;
> Vladimir Zapolskiy <v...@mleia.com>; Kachalov Anton <mo...@mayc.ru>;
> Cédric Le Goater <c...@kaod.org>; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.or
as
> Gleixner ; Jason Cooper ;
> Marc Zyngier ; Joel Stanley ;
> Vladimir Zapolskiy ; Kachalov Anton ;
> Cédric Le Goater ; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; Linux Kernel Mailing List
> ; OpenBMC Maillist
>
> Subject: Re: [PA
s.id.au>; Vladimir Zapolskiy <v...@mleia.com>; Kachalov Anton
> <mo...@mayc.ru>; Cédric Le Goater <c...@kaod.org>; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; OpenBMC Maillist <open.
ngier ; Joel
> Stanley ; Vladimir Zapolskiy ; Kachalov Anton
> ; Cédric Le Goater ; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; Linux Kernel Mailing List
> ; OpenBMC Maillist
> Subject: Re: [PATCH v6 4/5] i2c: aspeed: added driver for Asp
olskiy <v...@mleia.com>; Kachalov Anton
<mo...@mayc.ru>; Cédric Le Goater <c...@kaod.org>; linux-...@vger.kernel.org;
devicet...@vger.kernel.org; Linux Kernel Mailing List
<linux-kernel@vger.kernel.org>; OpenBMC Maillist <open...@lists.ozlabs.org>
Subject: Re: [PATCH
per ; Marc Zyngier ; Joel
Stanley ; Vladimir Zapolskiy ; Kachalov Anton
; Cédric Le Goater ; linux-...@vger.kernel.org;
devicet...@vger.kernel.org; Linux Kernel Mailing List
; OpenBMC Maillist
Subject: Re: [PATCH v6 4/5] i2c: aspeed: added driver for Aspeed I2C
On Tue, 2017-04-25 at 08:50 +
ngier i...@arm.com>; Joel Stanley <j...@jms.id.au>; Vladimir Zapolskiy <vz@m
> leia.com>; Kachalov Anton <mo...@mayc.ru>; Cédric Le Goater <clg@kaod
> .org>; linux-...@vger.kernel.org; devicet...@vger.kernel.org; Linux
> Kernel Mailing List <linux-kernel@vger
t; To: Benjamin Herrenschmidt
> Cc: Wolfram Sang ; Rob Herring >; Mark Rutland ; Thomas Gleixner nix.de>; Jason Cooper ; Marc Zyngier i...@arm.com>; Joel Stanley ; Vladimir Zapolskiy leia.com>; Kachalov Anton ; Cédric Le Goater .org>; linux-...@vger.kernel.org; devicet...@vger.kern
t;v...@mleia.com>; Kachalov Anton
<mo...@mayc.ru>; Cédric Le Goater <c...@kaod.org>; linux-...@vger.kernel.org;
devicet...@vger.kernel.org; Linux Kernel Mailing List
<linux-kernel@vger.kernel.org>; OpenBMC Maillist <open...@lists.ozlabs.org>;
Ryan Chen <ryan_c
mas Gleixner ; Jason
Cooper ; Marc Zyngier ; Joel
Stanley ; Vladimir Zapolskiy ; Kachalov Anton
; Cédric Le Goater ; linux-...@vger.kernel.org;
devicet...@vger.kernel.org; Linux Kernel Mailing List
; OpenBMC Maillist ;
Ryan Chen
Subject: Re: [PATCH v6 4/5] i2c: aspeed: added driver for Asp
Adding Ryan.
On Mon, Apr 24, 2017 at 7:19 PM, Benjamin Herrenschmidt
wrote:
> On Mon, 2017-04-24 at 11:56 -0700, Brendan Higgins wrote:
>> > > +struct aspeed_i2c_bus {
>> > > + struct i2c_adapter adap;
>> > > + struct device *dev;
Adding Ryan.
On Mon, Apr 24, 2017 at 7:19 PM, Benjamin Herrenschmidt
wrote:
> On Mon, 2017-04-24 at 11:56 -0700, Brendan Higgins wrote:
>> > > +struct aspeed_i2c_bus {
>> > > + struct i2c_adapter adap;
>> > > + struct device *dev;
>> > > + void __iomem
On Mon, 2017-04-24 at 11:56 -0700, Brendan Higgins wrote:
> > > +struct aspeed_i2c_bus {
> > > + struct i2c_adapter adap;
> > > + struct device *dev;
> > > + void __iomem*base;
> > > + /* Synchronizes I/O mem access to base. */
> >
On Mon, 2017-04-24 at 11:56 -0700, Brendan Higgins wrote:
> > > +struct aspeed_i2c_bus {
> > > + struct i2c_adapter adap;
> > > + struct device *dev;
> > > + void __iomem*base;
> > > + /* Synchronizes I/O mem access to base. */
> >
>> +struct aspeed_i2c_bus {
>> + struct i2c_adapter adap;
>> + struct device *dev;
>> + void __iomem*base;
>> + /* Synchronizes I/O mem access to base. */
>> + spinlock_t lock;
>
> I am not entirely
>> +struct aspeed_i2c_bus {
>> + struct i2c_adapter adap;
>> + struct device *dev;
>> + void __iomem*base;
>> + /* Synchronizes I/O mem access to base. */
>> + spinlock_t lock;
>
> I am not entirely
Allright, I finally found some time for reviewing some of this
after splitting the ftgmac100 patch into 54 smaller ones :)
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
.../...
> +struct aspeed_i2c_bus {
> + struct i2c_adapter adap;
> + struct device
Allright, I finally found some time for reviewing some of this
after splitting the ftgmac100 patch into 54 smaller ones :)
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
.../...
> +struct aspeed_i2c_bus {
> + struct i2c_adapter adap;
> + struct device
On Tue, Mar 28, 2017 at 3:42 PM, Brendan Higgins
wrote:
> Added initial master support for Aspeed I2C controller. Supports
> fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed.
Mention that the driver supports byte at a time access only at this stage.
>
On Tue, Mar 28, 2017 at 3:42 PM, Brendan Higgins
wrote:
> Added initial master support for Aspeed I2C controller. Supports
> fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed.
Mention that the driver supports byte at a time access only at this stage.
> Signed-off-by: Brendan
>> + ASPEED_I2CD_M_HIGH_SPEED_EN |
>> + ASPEED_I2CD_M_SDA_DRIVE_1T_EN |
>
> s/ASPEED_I2CD_M_SDA_DRIVE_1T_EN/ASPEED_I2CD_M_SCL_DRIVE_1T_EN/
>
> (and in the definition too)
Will fix.
>
>> +
>> + ASPEED_I2CD_M_HIGH_SPEED_EN |
>> + ASPEED_I2CD_M_SDA_DRIVE_1T_EN |
>
> s/ASPEED_I2CD_M_SDA_DRIVE_1T_EN/ASPEED_I2CD_M_SCL_DRIVE_1T_EN/
>
> (and in the definition too)
Will fix.
>
>> +
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
> + /* Set AC Timing */
> + if (clk_freq / 1000 > 1000) {
> + aspeed_i2c_write(bus, aspeed_i2c_read(bus,
> +
> ASPEED_I2C_FUN_CTRL_REG) |
> +
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
> + /* Set AC Timing */
> + if (clk_freq / 1000 > 1000) {
> + aspeed_i2c_write(bus, aspeed_i2c_read(bus,
> +
> ASPEED_I2C_FUN_CTRL_REG) |
> +
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
> +/* 0x04 : I2CD Clock and AC Timing Control Register #1 */
> +#define ASPEED_I2CD_TIME_SCL_HIGH_SHIFT16
> +#define ASPEED_I2CD_TIME_SCL_HIGH_MASK GENMASK(19, 16)
> +#define
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
> +/* 0x04 : I2CD Clock and AC Timing Control Register #1 */
> +#define ASPEED_I2CD_TIME_SCL_HIGH_SHIFT16
> +#define ASPEED_I2CD_TIME_SCL_HIGH_MASK GENMASK(19, 16)
> +#define
Added initial master support for Aspeed I2C controller. Supports
fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed.
Signed-off-by: Brendan Higgins
---
Changes for v2:
- Added single module_init (multiple was breaking some builds).
Changes for v3:
-
Added initial master support for Aspeed I2C controller. Supports
fourteen busses present in AST24XX and AST25XX BMC SoCs by Aspeed.
Signed-off-by: Brendan Higgins
---
Changes for v2:
- Added single module_init (multiple was breaking some builds).
Changes for v3:
- Removed "bus" device tree
28 matches
Mail list logo