Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-14 Thread Erin Lo 
On Thu, 2019-02-14 at 18:14 +0800, Erin Lo wrote:
> On Thu, 2019-02-14 at 10:01 +0100, Matthias Brugger wrote:
> > 
> > On 14/02/2019 06:27, Erin Lo wrote:
> > > On Wed, 2019-02-13 at 15:54 +0100, Matthias Brugger wrote:
> > >>
> > >> On 13/02/2019 10:03, Erin Lo wrote:
> > >>> On Thu, 2019-02-07 at 16:30 +0100, Matthias Brugger wrote:
> > 
> >  On 24/01/2019 09:07, Erin Lo wrote:
> > > From: Ben Ho 
> > >
> > > Add basic chip support for Mediatek 8183, include
> > > pinctrl file, uart node with correct uart clocks, pwrap device
> > >
> > > Add clock controller nodes, include topckgen, infracfg,
> > > apmixedsys and subsystem.
> > >
> > > Signed-off-by: Ben Ho 
> > > Signed-off-by: Erin Lo 
> > > Signed-off-by: Seiya Wang 
> > > Signed-off-by: Zhiyong Tao 
> > > Signed-off-by: Weiyi Lu 
> > > Signed-off-by: Mengqi Zhang 
> > > Signed-off-by: Hsin-Hsiung Wang 
> > > Signed-off-by: Eddie Huang 
> > > ---
> > >  arch/arm64/boot/dts/mediatek/Makefile |1 +
> > >  arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  136 +++
> > >  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 
> > > +
> > 
> >  Would you mind to make the pinfunc.h a seperate patch and adding the 
> >  pinctrl
> >  maintainers to the list.
> > 
> >  Regards,
> >  Matthias
> > 
> > >>>
> > >>> OK! I will take pinfunc.h out of this series.
> > >>
> > >> My take would be to somehow change this series in something like.
> > >> One patch which adds basic support for the SoC without any dependencies 
> > >> on other
> > >> series.
> > >> Every node that has a dependency on a different series should go in a 
> > >> separate
> > >> patch. In this case IMHO pinfunc.h can got with the dts node in one 
> > >> patch.
> > >>
> > >> Regards,
> > >> Matthias
> > >>
> > > 
> > > I will separate this patch into 3 patches : basic support for the SoC,
> > > mt8183-pinfunc.h, and spi node.
> > > 
> > > Is that OK?
> > > Is it ok, if pinctrl@1000b000 is included in basic node?
> > > 
> > 
> > Why do you want to do that? Without the pinfunc.h I can't take it 
> > independently,
> > right?
> > 
> > Regards,
> > Matthias
> 
> spi node need to use pio in mt8183-evb.dts, unless I don't submit spi
> relative.
> Best Regards.
> Erin

> > 
> > > Best Regards.
> > > Erin
> > > 
> > >>>
> > >>> Best Regards,
> > >>> Erin
> > >>>
> > >  arch/arm64/boot/dts/mediatek/mt8183.dtsi  |  408 +
> > >  4 files changed, 1665 insertions(+)
> > >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> > >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
> > > b/arch/arm64/boot/dts/mediatek/Makefile
> > > index e8f952f..458bbc4 100644
> > > --- a/arch/arm64/boot/dts/mediatek/Makefile
> > > +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > > @@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
> > >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
> > >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
> > >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
> > > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts 
> > > b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > > new file mode 100644
> > > index 000..b12c6ea
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > > @@ -0,0 +1,136 @@
> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > +/*
> > > + * Copyright (c) 2018 MediaTek Inc.
> > > + * Author: Ben Ho 
> > > + *  Erin Lo 
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "mt8183.dtsi"
> > > +
> > > +/ {
> > > + model = "MediaTek MT8183 evaluation board";
> > > + compatible = "mediatek,mt8183-evb", "mediatek,mt8183";
> > > +
> > > + aliases {
> > > + serial0 = 
> > > + };
> > > +
> > > + memory@4000 {
> > > + device_type = "memory";
> > > + reg = <0 0x4000 0 0x8000>;
> > > + };
> > > +
> > > + chosen {
> > > + stdout-path = "serial0:921600n8";
> > > + };
> > > +};
> > > +
> > > + {
> > > + spi_pins_0: spi0{
> > > + pins_spi{
> > > + pinmux = ,
> > > +  ,
> > > +  ,
> > > +  ;
> > > + bias-disable;
> > > + };
> > > + };
> > > +
> > > + spi_pins_1: spi1{
> > > + pins_spi{
> > > + pinmux = ,
> > > +

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-14 Thread Erin Lo 
On Thu, 2019-02-14 at 10:01 +0100, Matthias Brugger wrote:
> 
> On 14/02/2019 06:27, Erin Lo wrote:
> > On Wed, 2019-02-13 at 15:54 +0100, Matthias Brugger wrote:
> >>
> >> On 13/02/2019 10:03, Erin Lo wrote:
> >>> On Thu, 2019-02-07 at 16:30 +0100, Matthias Brugger wrote:
> 
>  On 24/01/2019 09:07, Erin Lo wrote:
> > From: Ben Ho 
> >
> > Add basic chip support for Mediatek 8183, include
> > pinctrl file, uart node with correct uart clocks, pwrap device
> >
> > Add clock controller nodes, include topckgen, infracfg,
> > apmixedsys and subsystem.
> >
> > Signed-off-by: Ben Ho 
> > Signed-off-by: Erin Lo 
> > Signed-off-by: Seiya Wang 
> > Signed-off-by: Zhiyong Tao 
> > Signed-off-by: Weiyi Lu 
> > Signed-off-by: Mengqi Zhang 
> > Signed-off-by: Hsin-Hsiung Wang 
> > Signed-off-by: Eddie Huang 
> > ---
> >  arch/arm64/boot/dts/mediatek/Makefile |1 +
> >  arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  136 +++
> >  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 
> > +
> 
>  Would you mind to make the pinfunc.h a seperate patch and adding the 
>  pinctrl
>  maintainers to the list.
> 
>  Regards,
>  Matthias
> 
> >>>
> >>> OK! I will take pinfunc.h out of this series.
> >>
> >> My take would be to somehow change this series in something like.
> >> One patch which adds basic support for the SoC without any dependencies on 
> >> other
> >> series.
> >> Every node that has a dependency on a different series should go in a 
> >> separate
> >> patch. In this case IMHO pinfunc.h can got with the dts node in one patch.
> >>
> >> Regards,
> >> Matthias
> >>
> > 
> > I will separate this patch into 3 patches : basic support for the SoC,
> > mt8183-pinfunc.h, and spi node.
> > 
> > Is that OK?
> > Is it ok, if pinctrl@1000b000 is included in basic node?
> > 
> 
> Why do you want to do that? Without the pinfunc.h I can't take it 
> independently,
> right?
> 
> Regards,
> Matthias

spi node need to use pio in mt8183-evb.dts, unless I don't submit spi
relative.

> 
> > Best Regards.
> > Erin
> > 
> >>>
> >>> Best Regards,
> >>> Erin
> >>>
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi  |  408 +
> >  4 files changed, 1665 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
> > b/arch/arm64/boot/dts/mediatek/Makefile
> > index e8f952f..458bbc4 100644
> > --- a/arch/arm64/boot/dts/mediatek/Makefile
> > +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > @@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts 
> > b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > new file mode 100644
> > index 000..b12c6ea
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > @@ -0,0 +1,136 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright (c) 2018 MediaTek Inc.
> > + * Author: Ben Ho 
> > + *Erin Lo 
> > + */
> > +
> > +/dts-v1/;
> > +#include "mt8183.dtsi"
> > +
> > +/ {
> > +   model = "MediaTek MT8183 evaluation board";
> > +   compatible = "mediatek,mt8183-evb", "mediatek,mt8183";
> > +
> > +   aliases {
> > +   serial0 = 
> > +   };
> > +
> > +   memory@4000 {
> > +   device_type = "memory";
> > +   reg = <0 0x4000 0 0x8000>;
> > +   };
> > +
> > +   chosen {
> > +   stdout-path = "serial0:921600n8";
> > +   };
> > +};
> > +
> > + {
> > +   spi_pins_0: spi0{
> > +   pins_spi{
> > +   pinmux = ,
> > +,
> > +,
> > +;
> > +   bias-disable;
> > +   };
> > +   };
> > +
> > +   spi_pins_1: spi1{
> > +   pins_spi{
> > +   pinmux = ,
> > +,
> > +,
> > +;
> > +   bias-disable;
> > +   };
> > +   };
> > +
> > +   spi_pins_2: spi2{
> > +   pins_spi{
> > +

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-14 Thread Matthias Brugger 



On 14/02/2019 06:27, Erin Lo wrote:
> On Wed, 2019-02-13 at 15:54 +0100, Matthias Brugger wrote:
>>
>> On 13/02/2019 10:03, Erin Lo wrote:
>>> On Thu, 2019-02-07 at 16:30 +0100, Matthias Brugger wrote:

 On 24/01/2019 09:07, Erin Lo wrote:
> From: Ben Ho 
>
> Add basic chip support for Mediatek 8183, include
> pinctrl file, uart node with correct uart clocks, pwrap device
>
> Add clock controller nodes, include topckgen, infracfg,
> apmixedsys and subsystem.
>
> Signed-off-by: Ben Ho 
> Signed-off-by: Erin Lo 
> Signed-off-by: Seiya Wang 
> Signed-off-by: Zhiyong Tao 
> Signed-off-by: Weiyi Lu 
> Signed-off-by: Mengqi Zhang 
> Signed-off-by: Hsin-Hsiung Wang 
> Signed-off-by: Eddie Huang 
> ---
>  arch/arm64/boot/dts/mediatek/Makefile |1 +
>  arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  136 +++
>  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 
> +

 Would you mind to make the pinfunc.h a seperate patch and adding the 
 pinctrl
 maintainers to the list.

 Regards,
 Matthias

>>>
>>> OK! I will take pinfunc.h out of this series.
>>
>> My take would be to somehow change this series in something like.
>> One patch which adds basic support for the SoC without any dependencies on 
>> other
>> series.
>> Every node that has a dependency on a different series should go in a 
>> separate
>> patch. In this case IMHO pinfunc.h can got with the dts node in one patch.
>>
>> Regards,
>> Matthias
>>
> 
> I will separate this patch into 3 patches : basic support for the SoC,
> mt8183-pinfunc.h, and spi node.
> 
> Is that OK?
> Is it ok, if pinctrl@1000b000 is included in basic node?
> 

Why do you want to do that? Without the pinfunc.h I can't take it independently,
right?

Regards,
Matthias

> Best Regards.
> Erin
> 
>>>
>>> Best Regards,
>>> Erin
>>>
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi  |  408 +
>  4 files changed, 1665 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
> b/arch/arm64/boot/dts/mediatek/Makefile
> index e8f952f..458bbc4 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts 
> b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> new file mode 100644
> index 000..b12c6ea
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> @@ -0,0 +1,136 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: Ben Ho 
> + *  Erin Lo 
> + */
> +
> +/dts-v1/;
> +#include "mt8183.dtsi"
> +
> +/ {
> + model = "MediaTek MT8183 evaluation board";
> + compatible = "mediatek,mt8183-evb", "mediatek,mt8183";
> +
> + aliases {
> + serial0 = 
> + };
> +
> + memory@4000 {
> + device_type = "memory";
> + reg = <0 0x4000 0 0x8000>;
> + };
> +
> + chosen {
> + stdout-path = "serial0:921600n8";
> + };
> +};
> +
> + {
> + spi_pins_0: spi0{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_1: spi1{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_2: spi2{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_3: spi3{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_4: spi4{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-13 Thread Erin Lo 
On Wed, 2019-02-13 at 15:54 +0100, Matthias Brugger wrote:
> 
> On 13/02/2019 10:03, Erin Lo wrote:
> > On Thu, 2019-02-07 at 16:30 +0100, Matthias Brugger wrote:
> >>
> >> On 24/01/2019 09:07, Erin Lo wrote:
> >>> From: Ben Ho 
> >>>
> >>> Add basic chip support for Mediatek 8183, include
> >>> pinctrl file, uart node with correct uart clocks, pwrap device
> >>>
> >>> Add clock controller nodes, include topckgen, infracfg,
> >>> apmixedsys and subsystem.
> >>>
> >>> Signed-off-by: Ben Ho 
> >>> Signed-off-by: Erin Lo 
> >>> Signed-off-by: Seiya Wang 
> >>> Signed-off-by: Zhiyong Tao 
> >>> Signed-off-by: Weiyi Lu 
> >>> Signed-off-by: Mengqi Zhang 
> >>> Signed-off-by: Hsin-Hsiung Wang 
> >>> Signed-off-by: Eddie Huang 
> >>> ---
> >>>  arch/arm64/boot/dts/mediatek/Makefile |1 +
> >>>  arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  136 +++
> >>>  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 
> >>> +
> >>
> >> Would you mind to make the pinfunc.h a seperate patch and adding the 
> >> pinctrl
> >> maintainers to the list.
> >>
> >> Regards,
> >> Matthias
> >>
> > 
> > OK! I will take pinfunc.h out of this series.
> 
> My take would be to somehow change this series in something like.
> One patch which adds basic support for the SoC without any dependencies on 
> other
> series.
> Every node that has a dependency on a different series should go in a separate
> patch. In this case IMHO pinfunc.h can got with the dts node in one patch.
> 
> Regards,
> Matthias
> 

I will separate this patch into 3 patches : basic support for the SoC,
mt8183-pinfunc.h, and spi node.

Is that OK?
Is it ok, if pinctrl@1000b000 is included in basic node?

Best Regards.
Erin

> > 
> > Best Regards,
> > Erin
> > 
> >>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi  |  408 +
> >>>  4 files changed, 1665 insertions(+)
> >>>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> >>>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> >>>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi
> >>>
> >>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
> >>> b/arch/arm64/boot/dts/mediatek/Makefile
> >>> index e8f952f..458bbc4 100644
> >>> --- a/arch/arm64/boot/dts/mediatek/Makefile
> >>> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> >>> @@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
> >>>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
> >>>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
> >>>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
> >>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts 
> >>> b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> >>> new file mode 100644
> >>> index 000..b12c6ea
> >>> --- /dev/null
> >>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> >>> @@ -0,0 +1,136 @@
> >>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> >>> +/*
> >>> + * Copyright (c) 2018 MediaTek Inc.
> >>> + * Author: Ben Ho 
> >>> + *  Erin Lo 
> >>> + */
> >>> +
> >>> +/dts-v1/;
> >>> +#include "mt8183.dtsi"
> >>> +
> >>> +/ {
> >>> + model = "MediaTek MT8183 evaluation board";
> >>> + compatible = "mediatek,mt8183-evb", "mediatek,mt8183";
> >>> +
> >>> + aliases {
> >>> + serial0 = 
> >>> + };
> >>> +
> >>> + memory@4000 {
> >>> + device_type = "memory";
> >>> + reg = <0 0x4000 0 0x8000>;
> >>> + };
> >>> +
> >>> + chosen {
> >>> + stdout-path = "serial0:921600n8";
> >>> + };
> >>> +};
> >>> +
> >>> + {
> >>> + spi_pins_0: spi0{
> >>> + pins_spi{
> >>> + pinmux = ,
> >>> +  ,
> >>> +  ,
> >>> +  ;
> >>> + bias-disable;
> >>> + };
> >>> + };
> >>> +
> >>> + spi_pins_1: spi1{
> >>> + pins_spi{
> >>> + pinmux = ,
> >>> +  ,
> >>> +  ,
> >>> +  ;
> >>> + bias-disable;
> >>> + };
> >>> + };
> >>> +
> >>> + spi_pins_2: spi2{
> >>> + pins_spi{
> >>> + pinmux = ,
> >>> +  ,
> >>> +  ,
> >>> +  ;
> >>> + bias-disable;
> >>> + };
> >>> + };
> >>> +
> >>> + spi_pins_3: spi3{
> >>> + pins_spi{
> >>> + pinmux = ,
> >>> +  ,
> >>> +  ,
> >>> +  ;
> >>> + bias-disable;
> >>> + };
> >>> + };
> >>> +
> >>> + spi_pins_4: spi4{
> >>> + pins_spi{
> >>> + pinmux = ,
> >>> +  ,
> >>> +  ,
> >>> +  ;
> >>> + bias-disable;
> >>> + };
> >>> + };
> >>> +
> >>> + spi_pins_5: spi5{
> >>> + pins_spi{
> >>> + pinmux = ,

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-13 Thread Matthias Brugger 



On 13/02/2019 10:03, Erin Lo wrote:
> On Thu, 2019-02-07 at 16:30 +0100, Matthias Brugger wrote:
>>
>> On 24/01/2019 09:07, Erin Lo wrote:
>>> From: Ben Ho 
>>>
>>> Add basic chip support for Mediatek 8183, include
>>> pinctrl file, uart node with correct uart clocks, pwrap device
>>>
>>> Add clock controller nodes, include topckgen, infracfg,
>>> apmixedsys and subsystem.
>>>
>>> Signed-off-by: Ben Ho 
>>> Signed-off-by: Erin Lo 
>>> Signed-off-by: Seiya Wang 
>>> Signed-off-by: Zhiyong Tao 
>>> Signed-off-by: Weiyi Lu 
>>> Signed-off-by: Mengqi Zhang 
>>> Signed-off-by: Hsin-Hsiung Wang 
>>> Signed-off-by: Eddie Huang 
>>> ---
>>>  arch/arm64/boot/dts/mediatek/Makefile |1 +
>>>  arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  136 +++
>>>  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 
>>> +
>>
>> Would you mind to make the pinfunc.h a seperate patch and adding the pinctrl
>> maintainers to the list.
>>
>> Regards,
>> Matthias
>>
> 
> OK! I will take pinfunc.h out of this series.

My take would be to somehow change this series in something like.
One patch which adds basic support for the SoC without any dependencies on other
series.
Every node that has a dependency on a different series should go in a separate
patch. In this case IMHO pinfunc.h can got with the dts node in one patch.

Regards,
Matthias

> 
> Best Regards,
> Erin
> 
>>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi  |  408 +
>>>  4 files changed, 1665 insertions(+)
>>>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
>>>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
>>>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
>>> b/arch/arm64/boot/dts/mediatek/Makefile
>>> index e8f952f..458bbc4 100644
>>> --- a/arch/arm64/boot/dts/mediatek/Makefile
>>> +++ b/arch/arm64/boot/dts/mediatek/Makefile
>>> @@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
>>>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
>>>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
>>>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
>>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts 
>>> b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
>>> new file mode 100644
>>> index 000..b12c6ea
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
>>> @@ -0,0 +1,136 @@
>>> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
>>> +/*
>>> + * Copyright (c) 2018 MediaTek Inc.
>>> + * Author: Ben Ho 
>>> + *Erin Lo 
>>> + */
>>> +
>>> +/dts-v1/;
>>> +#include "mt8183.dtsi"
>>> +
>>> +/ {
>>> +   model = "MediaTek MT8183 evaluation board";
>>> +   compatible = "mediatek,mt8183-evb", "mediatek,mt8183";
>>> +
>>> +   aliases {
>>> +   serial0 = 
>>> +   };
>>> +
>>> +   memory@4000 {
>>> +   device_type = "memory";
>>> +   reg = <0 0x4000 0 0x8000>;
>>> +   };
>>> +
>>> +   chosen {
>>> +   stdout-path = "serial0:921600n8";
>>> +   };
>>> +};
>>> +
>>> + {
>>> +   spi_pins_0: spi0{
>>> +   pins_spi{
>>> +   pinmux = ,
>>> +,
>>> +,
>>> +;
>>> +   bias-disable;
>>> +   };
>>> +   };
>>> +
>>> +   spi_pins_1: spi1{
>>> +   pins_spi{
>>> +   pinmux = ,
>>> +,
>>> +,
>>> +;
>>> +   bias-disable;
>>> +   };
>>> +   };
>>> +
>>> +   spi_pins_2: spi2{
>>> +   pins_spi{
>>> +   pinmux = ,
>>> +,
>>> +,
>>> +;
>>> +   bias-disable;
>>> +   };
>>> +   };
>>> +
>>> +   spi_pins_3: spi3{
>>> +   pins_spi{
>>> +   pinmux = ,
>>> +,
>>> +,
>>> +;
>>> +   bias-disable;
>>> +   };
>>> +   };
>>> +
>>> +   spi_pins_4: spi4{
>>> +   pins_spi{
>>> +   pinmux = ,
>>> +,
>>> +,
>>> +;
>>> +   bias-disable;
>>> +   };
>>> +   };
>>> +
>>> +   spi_pins_5: spi5{
>>> +   pins_spi{
>>> +   pinmux = ,
>>> +,
>>> +,
>>> +;
>>> +   bias-disable;
>>> +   };
>>> +   };
>>> +};
>>> +
>>> + {
>>> +   pinctrl-names = "default";
>>> +   pinctrl-0 = <_pins_0>;
>>> +   mediatek,pad-select = <0>;
>>> +   status = "okay";
>>> +};
>>> +
>>> + {
>>> +   pinctrl-names = "default";
>>> +   pinctrl-0 = <_pins_1>;
>>> +   mediatek,pad-select = <0>;
>>> +

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-13 Thread Erin Lo 
On Thu, 2019-02-07 at 16:30 +0100, Matthias Brugger wrote:
> 
> On 24/01/2019 09:07, Erin Lo wrote:
> > From: Ben Ho 
> > 
> > Add basic chip support for Mediatek 8183, include
> > pinctrl file, uart node with correct uart clocks, pwrap device
> > 
> > Add clock controller nodes, include topckgen, infracfg,
> > apmixedsys and subsystem.
> > 
> > Signed-off-by: Ben Ho 
> > Signed-off-by: Erin Lo 
> > Signed-off-by: Seiya Wang 
> > Signed-off-by: Zhiyong Tao 
> > Signed-off-by: Weiyi Lu 
> > Signed-off-by: Mengqi Zhang 
> > Signed-off-by: Hsin-Hsiung Wang 
> > Signed-off-by: Eddie Huang 
> > ---
> >  arch/arm64/boot/dts/mediatek/Makefile |1 +
> >  arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  136 +++
> >  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 
> > +
> 
> Would you mind to make the pinfunc.h a seperate patch and adding the pinctrl
> maintainers to the list.
> 
> Regards,
> Matthias
> 

OK! I will take pinfunc.h out of this series.

Best Regards,
Erin

> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi  |  408 +
> >  4 files changed, 1665 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
> > b/arch/arm64/boot/dts/mediatek/Makefile
> > index e8f952f..458bbc4 100644
> > --- a/arch/arm64/boot/dts/mediatek/Makefile
> > +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > @@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
> >  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts 
> > b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > new file mode 100644
> > index 000..b12c6ea
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> > @@ -0,0 +1,136 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright (c) 2018 MediaTek Inc.
> > + * Author: Ben Ho 
> > + *Erin Lo 
> > + */
> > +
> > +/dts-v1/;
> > +#include "mt8183.dtsi"
> > +
> > +/ {
> > +   model = "MediaTek MT8183 evaluation board";
> > +   compatible = "mediatek,mt8183-evb", "mediatek,mt8183";
> > +
> > +   aliases {
> > +   serial0 = 
> > +   };
> > +
> > +   memory@4000 {
> > +   device_type = "memory";
> > +   reg = <0 0x4000 0 0x8000>;
> > +   };
> > +
> > +   chosen {
> > +   stdout-path = "serial0:921600n8";
> > +   };
> > +};
> > +
> > + {
> > +   spi_pins_0: spi0{
> > +   pins_spi{
> > +   pinmux = ,
> > +,
> > +,
> > +;
> > +   bias-disable;
> > +   };
> > +   };
> > +
> > +   spi_pins_1: spi1{
> > +   pins_spi{
> > +   pinmux = ,
> > +,
> > +,
> > +;
> > +   bias-disable;
> > +   };
> > +   };
> > +
> > +   spi_pins_2: spi2{
> > +   pins_spi{
> > +   pinmux = ,
> > +,
> > +,
> > +;
> > +   bias-disable;
> > +   };
> > +   };
> > +
> > +   spi_pins_3: spi3{
> > +   pins_spi{
> > +   pinmux = ,
> > +,
> > +,
> > +;
> > +   bias-disable;
> > +   };
> > +   };
> > +
> > +   spi_pins_4: spi4{
> > +   pins_spi{
> > +   pinmux = ,
> > +,
> > +,
> > +;
> > +   bias-disable;
> > +   };
> > +   };
> > +
> > +   spi_pins_5: spi5{
> > +   pins_spi{
> > +   pinmux = ,
> > +,
> > +,
> > +;
> > +   bias-disable;
> > +   };
> > +   };
> > +};
> > +
> > + {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_pins_0>;
> > +   mediatek,pad-select = <0>;
> > +   status = "okay";
> > +};
> > +
> > + {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_pins_1>;
> > +   mediatek,pad-select = <0>;
> > +   status = "okay";
> > +};
> > +
> > + {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_pins_2>;
> > +   mediatek,pad-select = <0>;
> > +   status = "okay";
> > +};
> > +
> > + {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_pins_3>;
> > +   mediatek,pad-select = <0>;
> > +   status = "okay";
> > +};
> > +
> > + {
> > +   pinctrl-names = "default";
> > +

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-08 Thread Erin Lo 
On Thu, 2019-02-07 at 16:08 +0100, Matthias Brugger wrote:
> 
> On 01/02/2019 06:11, Erin Lo wrote:
> > Add back more people since mail server issue
> > 
> > On Fri, 2019-02-01 at 11:33 +0800, Erin Lo wrote:
> >> On Thu, 2019-01-31 at 15:10 -0600, Rob Herring wrote:
> >>> On Wed, Jan 30, 2019 at 8:34 PM Erin Lo  wrote:
> 
>  On Wed, 2019-01-30 at 10:22 -0600, Rob Herring wrote:
> > On Thu, Jan 24, 2019 at 04:07:20PM +0800, Erin Lo wrote:
> >> From: Ben Ho 
> >>
> >> Add basic chip support for Mediatek 8183, include
> >> pinctrl file, uart node with correct uart clocks, pwrap device
> >>
> >> Add clock controller nodes, include topckgen, infracfg,
> >> apmixedsys and subsystem.
> >>
> >> Signed-off-by: Ben Ho 
> >> Signed-off-by: Erin Lo 
> >> Signed-off-by: Seiya Wang 
> >> Signed-off-by: Zhiyong Tao 
> >> Signed-off-by: Weiyi Lu 
> >> Signed-off-by: Mengqi Zhang 
> >> Signed-off-by: Hsin-Hsiung Wang 
> >> Signed-off-by: Eddie Huang 
> >> ---
> >
> >
> >> +   sysirq: intpol-controller@c530a80 {
> >
> > interrupt-controller@...
> 
>  I will modify it in next version.
> >
> >
> > Place all the MMIO peripherals under one or more simple-bus nodes.
> >
> > Rob
> >
> 
>  Do you mean need to add simple-bus like this?
> >>>
> >>> Yes.
> >>
> >> We remove soc because Matthias suggested it in former MTK SoC maybe in
> >> 2015 year.
> >>
> >> We will add it back by your comment.
> >>
> >> Thank you. 
> >>
> >> Best Regards,
> >> Erin
> > 
> > Hi, Matthias,
> > Do you have any comment here?
> 
> Although I wasn't able to find it in the documentation my understanding is, 
> that
> all devices on-chip should be under soc "bus".
> 
> I'm sorry if I created confusion with comments in the past.
> 
> Regards,
> Matthias
> 

OK! we will add soc "bus" back in next version.
Thank you for your comment.

Best Regards,
Erin

> > Thanks
> > 
> > Best Regards,
> > Erin
> >>>
> 
>  +   soc: soc {
>  +#address-cells = <0x1>;
>  +#size-cells = <0x1>;
>  +ranges = <0 0 0 0x>;
>  +compatible = "simple-bus";
> 
>  soc_data: soc_data@0800 {
>  compatible = "mediatek,mt8183-efuse",
>   "mediatek,efuse";
>  reg = <0 0x0800 0 0x0010>;
>  #address-cells = <1>;
>  #size-cells = <1>;
>  status = "disabled";
>  };
> 
>  gic: interrupt-controller@0c00 {
>  compatible = "arm,gic-v3";
>  #interrupt-cells = <4>;
> 
>  Best Regards,
>  Erin
> 
> > ___
> > Linux-mediatek mailing list
> > linux-media...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 
> 
> 
>  ___
>  linux-arm-kernel mailing list
>  linux-arm-ker...@lists.infradead.org
>  http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >>
> > 
> > 
> 
> ___
> Linux-mediatek mailing list
> linux-media...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-07 Thread Matthias Brugger 



On 24/01/2019 09:07, Erin Lo wrote:
> From: Ben Ho 
> 
> Add basic chip support for Mediatek 8183, include
> pinctrl file, uart node with correct uart clocks, pwrap device
> 
> Add clock controller nodes, include topckgen, infracfg,
> apmixedsys and subsystem.
> 
> Signed-off-by: Ben Ho 
> Signed-off-by: Erin Lo 
> Signed-off-by: Seiya Wang 
> Signed-off-by: Zhiyong Tao 
> Signed-off-by: Weiyi Lu 
> Signed-off-by: Mengqi Zhang 
> Signed-off-by: Hsin-Hsiung Wang 
> Signed-off-by: Eddie Huang 
> ---
>  arch/arm64/boot/dts/mediatek/Makefile |1 +
>  arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  136 +++
>  arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 
> +

Would you mind to make the pinfunc.h a seperate patch and adding the pinctrl
maintainers to the list.

Regards,
Matthias

>  arch/arm64/boot/dts/mediatek/mt8183.dtsi  |  408 +
>  4 files changed, 1665 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi
> 
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
> b/arch/arm64/boot/dts/mediatek/Makefile
> index e8f952f..458bbc4 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts 
> b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> new file mode 100644
> index 000..b12c6ea
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
> @@ -0,0 +1,136 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: Ben Ho 
> + *  Erin Lo 
> + */
> +
> +/dts-v1/;
> +#include "mt8183.dtsi"
> +
> +/ {
> + model = "MediaTek MT8183 evaluation board";
> + compatible = "mediatek,mt8183-evb", "mediatek,mt8183";
> +
> + aliases {
> + serial0 = 
> + };
> +
> + memory@4000 {
> + device_type = "memory";
> + reg = <0 0x4000 0 0x8000>;
> + };
> +
> + chosen {
> + stdout-path = "serial0:921600n8";
> + };
> +};
> +
> + {
> + spi_pins_0: spi0{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_1: spi1{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_2: spi2{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_3: spi3{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_4: spi4{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +
> + spi_pins_5: spi5{
> + pins_spi{
> + pinmux = ,
> +  ,
> +  ,
> +  ;
> + bias-disable;
> + };
> + };
> +};
> +
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_0>;
> + mediatek,pad-select = <0>;
> + status = "okay";
> +};
> +
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_1>;
> + mediatek,pad-select = <0>;
> + status = "okay";
> +};
> +
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_2>;
> + mediatek,pad-select = <0>;
> + status = "okay";
> +};
> +
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_3>;
> + mediatek,pad-select = <0>;
> + status = "okay";
> +};
> +
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_4>;
> + mediatek,pad-select = <0>;
> + status = "okay";
> +};
> +
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_5>;
> + mediatek,pad-select = <0>;
> + status = "okay";
> +
> +};
> +
> + {
> + status = "okay";
> +};
> diff --git

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-02-07 Thread Matthias Brugger 



On 01/02/2019 06:11, Erin Lo wrote:
> Add back more people since mail server issue
> 
> On Fri, 2019-02-01 at 11:33 +0800, Erin Lo wrote:
>> On Thu, 2019-01-31 at 15:10 -0600, Rob Herring wrote:
>>> On Wed, Jan 30, 2019 at 8:34 PM Erin Lo  wrote:

 On Wed, 2019-01-30 at 10:22 -0600, Rob Herring wrote:
> On Thu, Jan 24, 2019 at 04:07:20PM +0800, Erin Lo wrote:
>> From: Ben Ho 
>>
>> Add basic chip support for Mediatek 8183, include
>> pinctrl file, uart node with correct uart clocks, pwrap device
>>
>> Add clock controller nodes, include topckgen, infracfg,
>> apmixedsys and subsystem.
>>
>> Signed-off-by: Ben Ho 
>> Signed-off-by: Erin Lo 
>> Signed-off-by: Seiya Wang 
>> Signed-off-by: Zhiyong Tao 
>> Signed-off-by: Weiyi Lu 
>> Signed-off-by: Mengqi Zhang 
>> Signed-off-by: Hsin-Hsiung Wang 
>> Signed-off-by: Eddie Huang 
>> ---
>
>
>> +   sysirq: intpol-controller@c530a80 {
>
> interrupt-controller@...

 I will modify it in next version.
>
>
> Place all the MMIO peripherals under one or more simple-bus nodes.
>
> Rob
>

 Do you mean need to add simple-bus like this?
>>>
>>> Yes.
>>
>> We remove soc because Matthias suggested it in former MTK SoC maybe in
>> 2015 year.
>>
>> We will add it back by your comment.
>>
>> Thank you. 
>>
>> Best Regards,
>> Erin
> 
> Hi, Matthias,
> Do you have any comment here?

Although I wasn't able to find it in the documentation my understanding is, that
all devices on-chip should be under soc "bus".

I'm sorry if I created confusion with comments in the past.

Regards,
Matthias

> Thanks
> 
> Best Regards,
> Erin
>>>

 +   soc: soc {
 +#address-cells = <0x1>;
 +#size-cells = <0x1>;
 +ranges = <0 0 0 0x>;
 +compatible = "simple-bus";

 soc_data: soc_data@0800 {
 compatible = "mediatek,mt8183-efuse",
  "mediatek,efuse";
 reg = <0 0x0800 0 0x0010>;
 #address-cells = <1>;
 #size-cells = <1>;
 status = "disabled";
 };

 gic: interrupt-controller@0c00 {
 compatible = "arm,gic-v3";
 #interrupt-cells = <4>;

 Best Regards,
 Erin

> ___
> Linux-mediatek mailing list
> linux-media...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek



 ___
 linux-arm-kernel mailing list
 linux-arm-ker...@lists.infradead.org
 http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
> 
>

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-01-31 Thread Erin Lo 
Add back more people since mail server issue

On Fri, 2019-02-01 at 11:33 +0800, Erin Lo wrote:
> On Thu, 2019-01-31 at 15:10 -0600, Rob Herring wrote:
> > On Wed, Jan 30, 2019 at 8:34 PM Erin Lo  wrote:
> > >
> > > On Wed, 2019-01-30 at 10:22 -0600, Rob Herring wrote:
> > > > On Thu, Jan 24, 2019 at 04:07:20PM +0800, Erin Lo wrote:
> > > > > From: Ben Ho 
> > > > >
> > > > > Add basic chip support for Mediatek 8183, include
> > > > > pinctrl file, uart node with correct uart clocks, pwrap device
> > > > >
> > > > > Add clock controller nodes, include topckgen, infracfg,
> > > > > apmixedsys and subsystem.
> > > > >
> > > > > Signed-off-by: Ben Ho 
> > > > > Signed-off-by: Erin Lo 
> > > > > Signed-off-by: Seiya Wang 
> > > > > Signed-off-by: Zhiyong Tao 
> > > > > Signed-off-by: Weiyi Lu 
> > > > > Signed-off-by: Mengqi Zhang 
> > > > > Signed-off-by: Hsin-Hsiung Wang 
> > > > > Signed-off-by: Eddie Huang 
> > > > > ---
> > > >
> > > >
> > > > > +   sysirq: intpol-controller@c530a80 {
> > > >
> > > > interrupt-controller@...
> > >
> > > I will modify it in next version.
> > > >
> > > >
> > > > Place all the MMIO peripherals under one or more simple-bus nodes.
> > > >
> > > > Rob
> > > >
> > >
> > > Do you mean need to add simple-bus like this?
> > 
> > Yes.
> 
> We remove soc because Matthias suggested it in former MTK SoC maybe in
> 2015 year.
> 
> We will add it back by your comment.
> 
> Thank you. 
> 
> Best Regards,
> Erin

Hi, Matthias,
Do you have any comment here?
Thanks

Best Regards,
Erin
> > 
> > >
> > > +   soc: soc {
> > > +#address-cells = <0x1>;
> > > +#size-cells = <0x1>;
> > > +ranges = <0 0 0 0x>;
> > > +compatible = "simple-bus";
> > >
> > > soc_data: soc_data@0800 {
> > > compatible = "mediatek,mt8183-efuse",
> > >  "mediatek,efuse";
> > > reg = <0 0x0800 0 0x0010>;
> > > #address-cells = <1>;
> > > #size-cells = <1>;
> > > status = "disabled";
> > > };
> > >
> > > gic: interrupt-controller@0c00 {
> > > compatible = "arm,gic-v3";
> > > #interrupt-cells = <4>;
> > >
> > > Best Regards,
> > > Erin
> > >
> > > > ___
> > > > Linux-mediatek mailing list
> > > > linux-media...@lists.infradead.org
> > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
> > >
> > >
> > >
> > > ___
> > > linux-arm-kernel mailing list
> > > linux-arm-ker...@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-01-31 Thread Rob Herring 
On Wed, Jan 30, 2019 at 8:34 PM Erin Lo  wrote:
>
> On Wed, 2019-01-30 at 10:22 -0600, Rob Herring wrote:
> > On Thu, Jan 24, 2019 at 04:07:20PM +0800, Erin Lo wrote:
> > > From: Ben Ho 
> > >
> > > Add basic chip support for Mediatek 8183, include
> > > pinctrl file, uart node with correct uart clocks, pwrap device
> > >
> > > Add clock controller nodes, include topckgen, infracfg,
> > > apmixedsys and subsystem.
> > >
> > > Signed-off-by: Ben Ho 
> > > Signed-off-by: Erin Lo 
> > > Signed-off-by: Seiya Wang 
> > > Signed-off-by: Zhiyong Tao 
> > > Signed-off-by: Weiyi Lu 
> > > Signed-off-by: Mengqi Zhang 
> > > Signed-off-by: Hsin-Hsiung Wang 
> > > Signed-off-by: Eddie Huang 
> > > ---
> >
> >
> > > +   sysirq: intpol-controller@c530a80 {
> >
> > interrupt-controller@...
>
> I will modify it in next version.
> >
> >
> > Place all the MMIO peripherals under one or more simple-bus nodes.
> >
> > Rob
> >
>
> Do you mean need to add simple-bus like this?

Yes.

>
> +   soc: soc {
> +#address-cells = <0x1>;
> +#size-cells = <0x1>;
> +ranges = <0 0 0 0x>;
> +compatible = "simple-bus";
>
> soc_data: soc_data@0800 {
> compatible = "mediatek,mt8183-efuse",
>  "mediatek,efuse";
> reg = <0 0x0800 0 0x0010>;
> #address-cells = <1>;
> #size-cells = <1>;
> status = "disabled";
> };
>
> gic: interrupt-controller@0c00 {
> compatible = "arm,gic-v3";
> #interrupt-cells = <4>;
>
> Best Regards,
> Erin
>
> > ___
> > Linux-mediatek mailing list
> > linux-media...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-01-30 Thread Erin Lo 
On Wed, 2019-01-30 at 10:22 -0600, Rob Herring wrote:
> On Thu, Jan 24, 2019 at 04:07:20PM +0800, Erin Lo wrote:
> > From: Ben Ho 
> > 
> > Add basic chip support for Mediatek 8183, include
> > pinctrl file, uart node with correct uart clocks, pwrap device
> > 
> > Add clock controller nodes, include topckgen, infracfg,
> > apmixedsys and subsystem.
> > 
> > Signed-off-by: Ben Ho 
> > Signed-off-by: Erin Lo 
> > Signed-off-by: Seiya Wang 
> > Signed-off-by: Zhiyong Tao 
> > Signed-off-by: Weiyi Lu 
> > Signed-off-by: Mengqi Zhang 
> > Signed-off-by: Hsin-Hsiung Wang 
> > Signed-off-by: Eddie Huang 
> > ---
> 
> 
> > +   sysirq: intpol-controller@c530a80 {
> 
> interrupt-controller@...

I will modify it in next version.
> 
> 
> Place all the MMIO peripherals under one or more simple-bus nodes.
> 
> Rob
> 

Do you mean need to add simple-bus like this?

+   soc: soc {
+#address-cells = <0x1>;
+#size-cells = <0x1>;
+ranges = <0 0 0 0x>;
+compatible = "simple-bus";

soc_data: soc_data@0800 {
compatible = "mediatek,mt8183-efuse",
 "mediatek,efuse";
reg = <0 0x0800 0 0x0010>;
#address-cells = <1>;
#size-cells = <1>;
status = "disabled";
};

gic: interrupt-controller@0c00 {
compatible = "arm,gic-v3";
#interrupt-cells = <4>;

Best Regards,
Erin

> ___
> Linux-mediatek mailing list
> linux-media...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-01-30 Thread Rob Herring 
On Thu, Jan 24, 2019 at 04:07:20PM +0800, Erin Lo wrote:
> From: Ben Ho 
> 
> Add basic chip support for Mediatek 8183, include
> pinctrl file, uart node with correct uart clocks, pwrap device
> 
> Add clock controller nodes, include topckgen, infracfg,
> apmixedsys and subsystem.
> 
> Signed-off-by: Ben Ho 
> Signed-off-by: Erin Lo 
> Signed-off-by: Seiya Wang 
> Signed-off-by: Zhiyong Tao 
> Signed-off-by: Weiyi Lu 
> Signed-off-by: Mengqi Zhang 
> Signed-off-by: Hsin-Hsiung Wang 
> Signed-off-by: Eddie Huang 
> ---


> + sysirq: intpol-controller@c530a80 {

interrupt-controller@...


Place all the MMIO peripherals under one or more simple-bus nodes.

Rob

[PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile

2019-01-24 Thread Erin Lo 
From: Ben Ho 

Add basic chip support for Mediatek 8183, include
pinctrl file, uart node with correct uart clocks, pwrap device

Add clock controller nodes, include topckgen, infracfg,
apmixedsys and subsystem.

Signed-off-by: Ben Ho 
Signed-off-by: Erin Lo 
Signed-off-by: Seiya Wang 
Signed-off-by: Zhiyong Tao 
Signed-off-by: Weiyi Lu 
Signed-off-by: Mengqi Zhang 
Signed-off-by: Hsin-Hsiung Wang 
Signed-off-by: Eddie Huang 
---
 arch/arm64/boot/dts/mediatek/Makefile |1 +
 arch/arm64/boot/dts/mediatek/mt8183-evb.dts   |  136 +++
 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h | 1120 +
 arch/arm64/boot/dts/mediatek/mt8183.dtsi  |  408 +
 4 files changed, 1665 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-evb.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8183.dtsi

diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
b/arch/arm64/boot/dts/mediatek/Makefile
index e8f952f..458bbc4 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -7,3 +7,4 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts 
b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
new file mode 100644
index 000..b12c6ea
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
@@ -0,0 +1,136 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (c) 2018 MediaTek Inc.
+ * Author: Ben Ho 
+ *Erin Lo 
+ */
+
+/dts-v1/;
+#include "mt8183.dtsi"
+
+/ {
+   model = "MediaTek MT8183 evaluation board";
+   compatible = "mediatek,mt8183-evb", "mediatek,mt8183";
+
+   aliases {
+   serial0 = 
+   };
+
+   memory@4000 {
+   device_type = "memory";
+   reg = <0 0x4000 0 0x8000>;
+   };
+
+   chosen {
+   stdout-path = "serial0:921600n8";
+   };
+};
+
+ {
+   spi_pins_0: spi0{
+   pins_spi{
+   pinmux = ,
+,
+,
+;
+   bias-disable;
+   };
+   };
+
+   spi_pins_1: spi1{
+   pins_spi{
+   pinmux = ,
+,
+,
+;
+   bias-disable;
+   };
+   };
+
+   spi_pins_2: spi2{
+   pins_spi{
+   pinmux = ,
+,
+,
+;
+   bias-disable;
+   };
+   };
+
+   spi_pins_3: spi3{
+   pins_spi{
+   pinmux = ,
+,
+,
+;
+   bias-disable;
+   };
+   };
+
+   spi_pins_4: spi4{
+   pins_spi{
+   pinmux = ,
+,
+,
+;
+   bias-disable;
+   };
+   };
+
+   spi_pins_5: spi5{
+   pins_spi{
+   pinmux = ,
+,
+,
+;
+   bias-disable;
+   };
+   };
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_0>;
+   mediatek,pad-select = <0>;
+   status = "okay";
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_1>;
+   mediatek,pad-select = <0>;
+   status = "okay";
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_2>;
+   mediatek,pad-select = <0>;
+   status = "okay";
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_3>;
+   mediatek,pad-select = <0>;
+   status = "okay";
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_4>;
+   mediatek,pad-select = <0>;
+   status = "okay";
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins_5>;
+   mediatek,pad-select = <0>;
+   status = "okay";
+
+};
+
+ {
+   status = "okay";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h 
b/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
new file mode 100644
index 000..768e41e
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-pinfunc.h
@@ -0,0 +1,1120 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2018 MediaTek Inc.
+ * Author: Zhiyong Tao 
+ *
+ */
+
+#ifndef