Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-06 Thread 'Greg KH'
On Tue, Apr 06, 2021 at 09:25:18AM +, Pho Tran wrote: > Hi Greg! > Should I send the Patch with new version (PATCH v8) or keep version of the > Patch is v7? Again, please do not top-post. v8 is needed. thanks, greg k-h

RE: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-06 Thread Pho Tran
' ; Hung Nguyen ; Tung Pham ; 'Kernel test robot' Subject: Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108 CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe

Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-06 Thread 'Greg KH'
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? On Tue, Apr 06, 2021 at

RE: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-06 Thread Pho Tran
el.org; linux-kernel@vger.kernel.org; Hung Nguyen ; Tung Pham ; Pho Tran ; Kernel test robot Subject: Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108 CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize

Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-05 Thread Greg KH
On Tue, Apr 06, 2021 at 11:02:38AM +0700, Pho Tran wrote: > From: Pho Tran > > Similar to other CP210x devices, GPIO interfaces (gpiochip) should be > supported for CP2108. > > CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared > to all of those interfaces. So, just need to

[PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

2021-04-05 Thread Pho Tran
From: Pho Tran Similar to other CP210x devices, GPIO interfaces (gpiochip) should be supported for CP2108. CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared to all of those interfaces. So, just need to initialize GPIOs of CP2108 with only one interface (I use interface 0).