Re: [PATCH v7] gpio: Add MOXA ART GPIO driver

2013-11-29 Thread Linus Walleij
On Fri, Nov 29, 2013 at 12:11 PM, Jonas Jensen wrote: > Add GPIO driver for MOXA ART SoCs. > > Signed-off-by: Jonas Jensen OK this v6 version is looking *really good* so I have applied it, couldn't hesitate. > +static struct gpio_chip moxart_template_chip = { > + .label

Re: [PATCH v7] gpio: Add MOXA ART GPIO driver

2013-11-29 Thread Arnd Bergmann
On Friday 29 November 2013, Jonas Jensen wrote: > Add GPIO driver for MOXA ART SoCs. > > Signed-off-by: Jonas Jensen Acked-by: Arnd Bergmann One more comment, no need to resend for another review if this is the only thing you want to change: > +struct moxart_gpio_chip { > + struct gpio_ch

[PATCH v7] gpio: Add MOXA ART GPIO driver

2013-11-29 Thread Jonas Jensen
Add GPIO driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Thanks Arnd, done in other drivers no reason to not do it here. Changes since v6: 1. remove global __iomem pointer 2. add derived data structure "struct moxart_gpio_chip" 3. use container_of()