Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-11-11 Thread Elie Morisse
Hi, In v9 the platform driver defers probe() if no MP2 devices has been registered in the PCI driver yet, is this an acceptable fix? I've found examples of kernel code extracting info from the ACPI namespace (e.g in i2c-core-acpi.c), but this would require adding more code to the driver and

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-11-11 Thread Elie Morisse
Hi, In v9 the platform driver defers probe() if no MP2 devices has been registered in the PCI driver yet, is this an acceptable fix? I've found examples of kernel code extracting info from the ACPI namespace (e.g in i2c-core-acpi.c), but this would require adding more code to the driver and

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-11-04 Thread Elie Morisse
The errors on module exit and the hang after a read/write timeout should be fixed in v8, someone else reported the same issue here: https://github.com/Syniurge/i2c-amd-mp2/issues/1 Weird that despite a lot of trying by doing random stuff with my touchpad and touchscreen neither never ever timed

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-11-04 Thread Elie Morisse
The errors on module exit and the hang after a read/write timeout should be fixed in v8, someone else reported the same issue here: https://github.com/Syniurge/i2c-amd-mp2/issues/1 Weird that despite a lot of trying by doing random stuff with my touchpad and touchscreen neither never ever timed

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Tobias Thomer
I've tested v7 on a Yoga 530 and it seems to work (sometimes for hours) but it randomly dies with a i2c read timeout [ 9562.237020] i2c_amd_plat_mp2 AMDI0011:00: i2c read timed out and reloading/removing of the module results in this: [ 9703.591021] pcie_mp2_amd :03:00.7: length 0 in event

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Tobias Thomer
I've tested v7 on a Yoga 530 and it seems to work (sometimes for hours) but it randomly dies with a i2c read timeout [ 9562.237020] i2c_amd_plat_mp2 AMDI0011:00: i2c read timed out and reloading/removing of the module results in this: [ 9703.591021] pcie_mp2_amd :03:00.7: length 0 in event

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Bjorn Helgaas
[+cc Rafael, Len, linux-acpi] On Sat, Oct 27, 2018 at 12:09:10PM -0300, Elie Morisse wrote: > This contains two drivers: > * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of > the two busses of the MP2) and routing any i2c read/write command to > the PCI driver. > *

Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-30 Thread Bjorn Helgaas
[+cc Rafael, Len, linux-acpi] On Sat, Oct 27, 2018 at 12:09:10PM -0300, Elie Morisse wrote: > This contains two drivers: > * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of > the two busses of the MP2) and routing any i2c read/write command to > the PCI driver. > *

[PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-27 Thread Elie Morisse
This contains two drivers: * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of the two busses of the MP2) and routing any i2c read/write command to the PCI driver. * i2c-amd-pci-mp2: PCI driver communicating through the C2P/P2C mailbox registers, or through DMA for more than 32

[PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-27 Thread Elie Morisse
This contains two drivers: * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of the two busses of the MP2) and routing any i2c read/write command to the PCI driver. * i2c-amd-pci-mp2: PCI driver communicating through the C2P/P2C mailbox registers, or through DMA for more than 32