Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Arun KS
On 2019-01-10 00:26, Andrew Morton wrote: On Wed, 09 Jan 2019 16:36:36 +0530 Arun KS wrote: On 2019-01-09 16:27, Michal Hocko wrote: > On Wed 09-01-19 16:12:48, Arun KS wrote: > [...] >> It will be called once per online of a section and the arg value is >> always >> set to 0 while entering

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Arun KS
On 2019-01-09 21:39, Alexander Duyck wrote: On Wed, 2019-01-09 at 11:51 +0530, Arun KS wrote: On 2019-01-09 03:47, Alexander Duyck wrote: > On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > > When freeing pages are done with higher order, time spent on > > coalescing > > pages by buddy

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Andrew Morton
On Wed, 09 Jan 2019 16:36:36 +0530 Arun KS wrote: > On 2019-01-09 16:27, Michal Hocko wrote: > > On Wed 09-01-19 16:12:48, Arun KS wrote: > > [...] > >> It will be called once per online of a section and the arg value is > >> always > >> set to 0 while entering online_pages_range. > > > > You

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Alexander Duyck
On Wed, 2019-01-09 at 11:51 +0530, Arun KS wrote: > On 2019-01-09 03:47, Alexander Duyck wrote: > > On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > > > When freeing pages are done with higher order, time spent on > > > coalescing > > > pages by buddy allocator can be reduced. With section

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Arun KS
On 2019-01-09 16:27, Michal Hocko wrote: On Wed 09-01-19 16:12:48, Arun KS wrote: [...] It will be called once per online of a section and the arg value is always set to 0 while entering online_pages_range. You rare right that this will be the case in the most simple scenario. But the point

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Michal Hocko
On Wed 09-01-19 16:12:48, Arun KS wrote: [...] > It will be called once per online of a section and the arg value is always > set to 0 while entering online_pages_range. You rare right that this will be the case in the most simple scenario. But the point is that the callback can be called several

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Arun KS
On 2019-01-09 14:10, Michal Hocko wrote: On Wed 09-01-19 13:58:50, Arun KS wrote: On 2019-01-09 13:07, Michal Hocko wrote: > On Wed 09-01-19 11:28:52, Arun KS wrote: > > On 2019-01-08 23:43, Michal Hocko wrote: > > > On Tue 08-01-19 09:56:09, Alexander Duyck wrote: > > > > On Fri, 2019-01-04 at

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Michal Hocko
On Wed 09-01-19 13:58:50, Arun KS wrote: > On 2019-01-09 13:07, Michal Hocko wrote: > > On Wed 09-01-19 11:28:52, Arun KS wrote: > > > On 2019-01-08 23:43, Michal Hocko wrote: > > > > On Tue 08-01-19 09:56:09, Alexander Duyck wrote: > > > > > On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > > >

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-09 Thread Arun KS
On 2019-01-09 13:07, Michal Hocko wrote: On Wed 09-01-19 11:28:52, Arun KS wrote: On 2019-01-08 23:43, Michal Hocko wrote: > On Tue 08-01-19 09:56:09, Alexander Duyck wrote: > > On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > [...] > > > static int online_pages_range(unsigned long

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Michal Hocko
On Wed 09-01-19 11:28:52, Arun KS wrote: > On 2019-01-08 23:43, Michal Hocko wrote: > > On Tue 08-01-19 09:56:09, Alexander Duyck wrote: > > > On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > > [...] > > > > static int online_pages_range(unsigned long start_pfn, unsigned long > > > >

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Arun KS
On 2019-01-09 03:47, Alexander Duyck wrote: On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: When freeing pages are done with higher order, time spent on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Arun KS
On 2019-01-08 23:43, Michal Hocko wrote: On Tue 08-01-19 09:56:09, Alexander Duyck wrote: On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: [...] > static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages, >void *arg) > { > - unsigned long i; >

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Alexander Duyck
On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > When freeing pages are done with higher order, time spent on coalescing > pages by buddy allocator can be reduced. With section size of 256MB, hot > add latency of a single section shows improvement from 50-60 ms to less > than 1 ms, hence

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Alexander Duyck
On Tue, 2019-01-08 at 21:04 +0100, Michal Hocko wrote: > On Tue 08-01-19 10:40:18, Alexander Duyck wrote: > > On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > > > When freeing pages are done with higher order, time spent on coalescing > > > pages by buddy allocator can be reduced. With section

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Michal Hocko
On Tue 08-01-19 10:40:18, Alexander Duyck wrote: > On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > > When freeing pages are done with higher order, time spent on coalescing > > pages by buddy allocator can be reduced. With section size of 256MB, hot > > add latency of a single section shows

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Alexander Duyck
On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > When freeing pages are done with higher order, time spent on coalescing > pages by buddy allocator can be reduced. With section size of 256MB, hot > add latency of a single section shows improvement from 50-60 ms to less > than 1 ms, hence

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Michal Hocko
On Tue 08-01-19 09:56:09, Alexander Duyck wrote: > On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: [...] > > static int online_pages_range(unsigned long start_pfn, unsigned long > > nr_pages, > > void *arg) > > { > > - unsigned long i; > > unsigned long onlined_pages

Re: [PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-08 Thread Alexander Duyck
On Fri, 2019-01-04 at 10:31 +0530, Arun KS wrote: > When freeing pages are done with higher order, time spent on coalescing > pages by buddy allocator can be reduced. With section size of 256MB, hot > add latency of a single section shows improvement from 50-60 ms to less > than 1 ms, hence

[PATCH v7] mm/page_alloc.c: memory_hotplug: free pages as higher order

2019-01-03 Thread Arun KS
When freeing pages are done with higher order, time spent on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less than 1 ms, hence improving the hot add latency by 60 times. Modify external