Re: [PATCH v7 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support

2018-12-26 Thread Long Cheng
On Wed, 2018-12-26 at 17:28 +0800, Nicolas Boichat wrote: .. > > > > > > +static int mtk_uart_apdma_device_pause(struct dma_chan *chan) > > > > > > +{ > > > > > > + /* just for check caps pass */ > > > > > > + return 0; > > > > > > +} > > > > > > + > > > > > > +static int

Re: [PATCH v7 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support

2018-12-26 Thread Nicolas Boichat
On Wed, Dec 26, 2018 at 2:35 PM Long Cheng wrote: > > On Wed, 2018-12-26 at 08:05 +0800, Nicolas Boichat wrote: > > thanks. > > > On Tue, Dec 25, 2018 at 8:06 PM Long Cheng wrote: > > > > > > Thanks for your comments. > > > > > > On Tue, 2018-12-25 at 15:16 +0800, Nicolas Boichat wrote: > > > >

Re: [PATCH v7 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support

2018-12-25 Thread Long Cheng
On Wed, 2018-12-26 at 08:05 +0800, Nicolas Boichat wrote: thanks. > On Tue, Dec 25, 2018 at 8:06 PM Long Cheng wrote: > > > > Thanks for your comments. > > > > On Tue, 2018-12-25 at 15:16 +0800, Nicolas Boichat wrote: > > > Not a full review, a few comments below. > > > > > > Thanks, > > > > >

Re: [PATCH v7 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support

2018-12-25 Thread Nicolas Boichat
On Tue, Dec 25, 2018 at 8:06 PM Long Cheng wrote: > > Thanks for your comments. > > On Tue, 2018-12-25 at 15:16 +0800, Nicolas Boichat wrote: > > Not a full review, a few comments below. > > > > Thanks, > > > > would you like help to full review at this version patch? and then i > can modify

Re: [PATCH v7 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support

2018-12-25 Thread Long Cheng
Thanks for your comments. On Tue, 2018-12-25 at 15:16 +0800, Nicolas Boichat wrote: > Not a full review, a few comments below. > > Thanks, > would you like help to full review at this version patch? and then i can modify these at next version patch. thanks. > On Tue, Dec 25, 2018 at 9:27 AM

Re: [PATCH v7 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support

2018-12-24 Thread Nicolas Boichat
Not a full review, a few comments below. Thanks, On Tue, Dec 25, 2018 at 9:27 AM Long Cheng wrote: > > In DMA engine framework, add 8250 uart dma to support MediaTek uart. > If MediaTek uart enabled(SERIAL_8250_MT6577), and want to improve > the performance, can enable the function. > >

[PATCH v7 1/2] dmaengine: 8250_mtk_dma: add MediaTek uart DMA support

2018-12-24 Thread Long Cheng
In DMA engine framework, add 8250 uart dma to support MediaTek uart. If MediaTek uart enabled(SERIAL_8250_MT6577), and want to improve the performance, can enable the function. Signed-off-by: Long Cheng --- drivers/dma/mediatek/8250_mtk_dma.c | 694 +++