Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-07 Thread Pavel Machek
Hi! > +What:/sys/class/leds//hw_pattern > +Date:September 2018 > +KernelVersion: 4.20 > +Description: > + Specify a hardware pattern for the SC27XX LED. For the SC27XX > + LED controller, it only supports 4 hardware patterns to >

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-07 Thread Pavel Machek
Hi! > +What:/sys/class/leds//hw_pattern > +Date:September 2018 > +KernelVersion: 4.20 > +Description: > + Specify a hardware pattern for the SC27XX LED. For the SC27XX > + LED controller, it only supports 4 hardware patterns to >

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-04 Thread Jacek Anaszewski
On 09/03/2018 11:53 PM, Pavel Machek wrote: > Hi! > >>> +static int pattern_trig_start_pattern(struct led_classdev *led_cdev) >>> +{ >>> + struct pattern_trig_data *data = led_cdev->trigger_data; >>> + >>> + if (!data->npatterns) >>> + return 0; >>> + >>> + if

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-04 Thread Jacek Anaszewski
On 09/03/2018 11:53 PM, Pavel Machek wrote: > Hi! > >>> +static int pattern_trig_start_pattern(struct led_classdev *led_cdev) >>> +{ >>> + struct pattern_trig_data *data = led_cdev->trigger_data; >>> + >>> + if (!data->npatterns) >>> + return 0; >>> + >>> + if

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-03 Thread Baolin Wang
Hi Pavel, On 4 September 2018 at 05:53, Pavel Machek wrote: > Hi! > >> > +static int pattern_trig_start_pattern(struct led_classdev *led_cdev) >> > +{ >> > + struct pattern_trig_data *data = led_cdev->trigger_data; >> > + >> > + if (!data->npatterns) >> > + return 0; >> > + >> > +

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-03 Thread Baolin Wang
Hi Pavel, On 4 September 2018 at 05:53, Pavel Machek wrote: > Hi! > >> > +static int pattern_trig_start_pattern(struct led_classdev *led_cdev) >> > +{ >> > + struct pattern_trig_data *data = led_cdev->trigger_data; >> > + >> > + if (!data->npatterns) >> > + return 0; >> > + >> > +

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-03 Thread Baolin Wang
Hi Jacek, On 4 September 2018 at 02:58, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the update. > > Please find my remarks below. > > On 08/31/2018 09:52 AM, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-03 Thread Baolin Wang
Hi Jacek, On 4 September 2018 at 02:58, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the update. > > Please find my remarks below. > > On 08/31/2018 09:52 AM, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-03 Thread Pavel Machek
Hi! > > +static int pattern_trig_start_pattern(struct led_classdev *led_cdev) > > +{ > > + struct pattern_trig_data *data = led_cdev->trigger_data; > > + > > + if (!data->npatterns) > > + return 0; > > + > > + if (data->is_hw_pattern) { > > + return

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-03 Thread Pavel Machek
Hi! > > +static int pattern_trig_start_pattern(struct led_classdev *led_cdev) > > +{ > > + struct pattern_trig_data *data = led_cdev->trigger_data; > > + > > + if (!data->npatterns) > > + return 0; > > + > > + if (data->is_hw_pattern) { > > + return

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-03 Thread Jacek Anaszewski
Hi Baolin, Thank you for the update. Please find my remarks below. On 08/31/2018 09:52 AM, Baolin Wang wrote: > This patch adds one new led trigger that LED device can configure > the software or hardware pattern and trigger it. > > Consumers can write 'pattern' file to enable the software

Re: [PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-09-03 Thread Jacek Anaszewski
Hi Baolin, Thank you for the update. Please find my remarks below. On 08/31/2018 09:52 AM, Baolin Wang wrote: > This patch adds one new led trigger that LED device can configure > the software or hardware pattern and trigger it. > > Consumers can write 'pattern' file to enable the software

[PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-08-31 Thread Baolin Wang
This patch adds one new led trigger that LED device can configure the software or hardware pattern and trigger it. Consumers can write 'pattern' file to enable the software pattern which alters the brightness for the specified duration with one software timer. Moreover consumers can write

[PATCH v7 1/2] leds: core: Introduce LED pattern trigger

2018-08-31 Thread Baolin Wang
This patch adds one new led trigger that LED device can configure the software or hardware pattern and trigger it. Consumers can write 'pattern' file to enable the software pattern which alters the brightness for the specified duration with one software timer. Moreover consumers can write