Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

2016-08-15 Thread Kyle Roeschley
On Sat, Aug 13, 2016 at 12:37:03AM +0200, Boris Brezillon wrote: > On Fri, 12 Aug 2016 16:58:22 -0500 > Kyle Roeschley wrote: > [...] > > + while (chip < nrchips) { > > I'm probably missing something, but why are you turning the for loop > into a while loop in this

Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

2016-08-15 Thread Kyle Roeschley
On Sat, Aug 13, 2016 at 12:37:03AM +0200, Boris Brezillon wrote: > On Fri, 12 Aug 2016 16:58:22 -0500 > Kyle Roeschley wrote: > [...] > > + while (chip < nrchips) { > > I'm probably missing something, but why are you turning the for loop > into a while loop in this patch? The commit message

Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

2016-08-15 Thread Boris Brezillon
On Mon, 15 Aug 2016 09:47:40 -0500 Kyle Roeschley wrote: > On Sat, Aug 13, 2016 at 12:37:03AM +0200, Boris Brezillon wrote: > > On Fri, 12 Aug 2016 16:58:22 -0500 > > Kyle Roeschley wrote: > > > [...] > > > + while (chip < nrchips) { > > > >

Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

2016-08-15 Thread Boris Brezillon
On Mon, 15 Aug 2016 09:47:40 -0500 Kyle Roeschley wrote: > On Sat, Aug 13, 2016 at 12:37:03AM +0200, Boris Brezillon wrote: > > On Fri, 12 Aug 2016 16:58:22 -0500 > > Kyle Roeschley wrote: > > > [...] > > > + while (chip < nrchips) { > > > > I'm probably missing something, but why are you

Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

2016-08-12 Thread Boris Brezillon
On Fri, 12 Aug 2016 16:58:22 -0500 Kyle Roeschley wrote: > From: Boris Brezillon > > This clarifies the write_bbt() by removing the write label and > clarifying the error/exit path. > > Signed-off-by: Boris Brezillon

Re: [PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

2016-08-12 Thread Boris Brezillon
On Fri, 12 Aug 2016 16:58:22 -0500 Kyle Roeschley wrote: > From: Boris Brezillon > > This clarifies the write_bbt() by removing the write label and > clarifying the error/exit path. > > Signed-off-by: Boris Brezillon > Tested-by: Kyle Roeschley > --- > v7: Move all code cleanup into first

[PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

2016-08-12 Thread Kyle Roeschley
From: Boris Brezillon This clarifies the write_bbt() by removing the write label and clarifying the error/exit path. Signed-off-by: Boris Brezillon Tested-by: Kyle Roeschley --- v7: Move all code

[PATCH v7 1/2] mtd: nand_bbt: Move BBT block selection logic out of write_bbt()

2016-08-12 Thread Kyle Roeschley
From: Boris Brezillon This clarifies the write_bbt() by removing the write label and clarifying the error/exit path. Signed-off-by: Boris Brezillon Tested-by: Kyle Roeschley --- v7: Move all code cleanup into first patch Correct documentation of mark_bbt_block_bad Make pr_warn