Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-09 Thread Scott Branden
Hi Matthew, On 2020-06-09 6:21 a.m., Matthew Wilcox wrote: On Mon, Jun 08, 2020 at 03:29:22PM -0700, Scott Branden wrote: Hi Matthew, I am requesting the experts in the filesystem subsystem to come to a consensus here. This is not my area of expertise at all but every time I have addressed

Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-09 Thread Matthew Wilcox
On Mon, Jun 08, 2020 at 03:29:22PM -0700, Scott Branden wrote: > Hi Matthew, > > I am requesting the experts in the filesystem subsystem to come to a > consensus here. > This is not my area of expertise at all but every time I have addressed all > of the > outstanding concerns someone else comes

Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-08 Thread Scott Branden
Hi Matthew, I am requesting the experts in the filesystem subsystem to come to a consensus here. This is not my area of expertise at all but every time I have addressed all of the outstanding concerns someone else comes along and raises another one. Please see me comments below. On

Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-08 Thread Matthew Wilcox
On Mon, Jun 08, 2020 at 09:22:06AM -0400, Mimi Zohar wrote: > On Mon, 2020-06-08 at 06:16 -0700, Matthew Wilcox wrote: > > On Mon, Jun 08, 2020 at 09:03:21AM -0400, Mimi Zohar wrote: > > > With this new design of not using a private vmalloc, will the file > > > data be accessible prior to the post

Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-08 Thread Mimi Zohar
On Mon, 2020-06-08 at 09:22 -0400, Mimi Zohar wrote: > On Mon, 2020-06-08 at 06:16 -0700, Matthew Wilcox wrote: > > On Mon, Jun 08, 2020 at 09:03:21AM -0400, Mimi Zohar wrote: > > > On Sat, 2020-06-06 at 08:52 -0700, Matthew Wilcox wrote: > > > > On Fri, Jun 05, 2020 at 10:04:51PM -0700, Scott

Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-08 Thread Mimi Zohar
On Mon, 2020-06-08 at 06:16 -0700, Matthew Wilcox wrote: > On Mon, Jun 08, 2020 at 09:03:21AM -0400, Mimi Zohar wrote: > > On Sat, 2020-06-06 at 08:52 -0700, Matthew Wilcox wrote: > > > On Fri, Jun 05, 2020 at 10:04:51PM -0700, Scott Branden wrote: > > > > -int kernel_read_file(struct file *file,

Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-08 Thread Matthew Wilcox
On Mon, Jun 08, 2020 at 09:03:21AM -0400, Mimi Zohar wrote: > On Sat, 2020-06-06 at 08:52 -0700, Matthew Wilcox wrote: > > On Fri, Jun 05, 2020 at 10:04:51PM -0700, Scott Branden wrote: > > > -int kernel_read_file(struct file *file, void **buf, loff_t *size, > > > - loff_t max_size,

Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-08 Thread Mimi Zohar
On Sat, 2020-06-06 at 08:52 -0700, Matthew Wilcox wrote: > On Fri, Jun 05, 2020 at 10:04:51PM -0700, Scott Branden wrote: > > -int kernel_read_file(struct file *file, void **buf, loff_t *size, > > -loff_t max_size, enum kernel_read_file_id id) > > -{ > > - loff_t i_size, pos; > >

Re: [PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-06 Thread Matthew Wilcox
On Fri, Jun 05, 2020 at 10:04:51PM -0700, Scott Branden wrote: > -int kernel_read_file(struct file *file, void **buf, loff_t *size, > - loff_t max_size, enum kernel_read_file_id id) > -{ > - loff_t i_size, pos; > +int kernel_pread_file(struct file *file, void **buf, loff_t

[PATCH v7 1/8] fs: introduce kernel_pread_file* support

2020-06-05 Thread Scott Branden
Add kernel_pread_file* support to kernel to allow for partial read of files with an offset into the file. Existing kernel_read_file functions call new kernel_pread_file functions with offset=0 and opt=KERNEL_PREAD_WHOLE. Signed-off-by: Scott Branden --- fs/exec.c | 95