Re: [PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods

2016-06-01 Thread Hekuang
在 2016/6/1 16:40, Jiri Olsa 写道: On Tue, May 31, 2016 at 11:19:08AM +, He Kuang wrote: SNIP -int unwind__prepare_access(struct thread *thread) +int unwind__prepare_access(struct thread *thread, struct map *map) { - unwind__register_ops(thread, local_unwind_libunwind_ops); +

Re: [PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods

2016-06-01 Thread Hekuang
在 2016/6/1 16:40, Jiri Olsa 写道: On Tue, May 31, 2016 at 11:19:08AM +, He Kuang wrote: SNIP -int unwind__prepare_access(struct thread *thread) +int unwind__prepare_access(struct thread *thread, struct map *map) { - unwind__register_ops(thread, local_unwind_libunwind_ops); +

Re: [PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods

2016-06-01 Thread Jiri Olsa
On Tue, May 31, 2016 at 11:19:08AM +, He Kuang wrote: SNIP > -int unwind__prepare_access(struct thread *thread) > +int unwind__prepare_access(struct thread *thread, struct map *map) > { > - unwind__register_ops(thread, local_unwind_libunwind_ops); > + const char *arch; > + enum

Re: [PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods

2016-06-01 Thread Jiri Olsa
On Tue, May 31, 2016 at 11:19:08AM +, He Kuang wrote: SNIP > -int unwind__prepare_access(struct thread *thread) > +int unwind__prepare_access(struct thread *thread, struct map *map) > { > - unwind__register_ops(thread, local_unwind_libunwind_ops); > + const char *arch; > + enum

Re: [PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods

2016-06-01 Thread Jiri Olsa
On Tue, May 31, 2016 at 11:19:08AM +, He Kuang wrote: SNIP > -int unwind__prepare_access(struct thread *thread) > +int unwind__prepare_access(struct thread *thread, struct map *map) > { > - unwind__register_ops(thread, local_unwind_libunwind_ops); > + const char *arch; > + enum

Re: [PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods

2016-06-01 Thread Jiri Olsa
On Tue, May 31, 2016 at 11:19:08AM +, He Kuang wrote: SNIP > -int unwind__prepare_access(struct thread *thread) > +int unwind__prepare_access(struct thread *thread, struct map *map) > { > - unwind__register_ops(thread, local_unwind_libunwind_ops); > + const char *arch; > + enum

[PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods

2016-05-31 Thread He Kuang
Currently, perf script uses host unwind methods to parse perf.data callchain info regardless of the target architecture. So we get wrong result without any warnings when unwinding callchains of x86(32-bit) on x86(64-bit) machine. This patch adds extra step that check the target platform before

[PATCH v7 10/14] perf tools: Check the target platform before assigning unwind methods

2016-05-31 Thread He Kuang
Currently, perf script uses host unwind methods to parse perf.data callchain info regardless of the target architecture. So we get wrong result without any warnings when unwinding callchains of x86(32-bit) on x86(64-bit) machine. This patch adds extra step that check the target platform before