Re: [PATCH v7 13/13] arm64: dts: Add power controller device node of MT8183

2019-08-28 Thread CK Hu
Hi, Weiyi:

On Wed, 2019-08-28 at 17:11 +0800, Weiyi Lu wrote:
> Add power controller node and smi-common node for MT8183
> In scpsys node, it contains clocks and regmapping of
> infracfg and smi-common for bus protection.
> 
> Signed-off-by: Weiyi Lu 
> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 62 
> 
>  1 file changed, 62 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c2749c4..66aaa07 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -8,6 +8,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include "mt8183-pinfunc.h"
>  
>  / {
> @@ -238,6 +239,62 @@
>   #interrupt-cells = <2>;
>   };
>  
> + scpsys: syscon@10006000 {
> + compatible = "mediatek,mt8183-scpsys", "syscon";
> + #power-domain-cells = <1>;
> + reg = <0 0x10006000 0 0x1000>;
> + clocks = < CLK_TOP_MUX_AUD_INTBUS>,
> +  < CLK_INFRA_AUDIO>,
> +  < CLK_INFRA_AUDIO_26M_BCLK>,
> +  < CLK_TOP_MUX_MFG>,
> +  < CLK_TOP_MUX_MM>,
> +  < CLK_TOP_MUX_CAM>,
> +  < CLK_TOP_MUX_IMG>,
> +  < CLK_TOP_MUX_IPU_IF>,
> +  < CLK_TOP_MUX_DSP>,
> +  < CLK_TOP_MUX_DSP1>,
> +  < CLK_TOP_MUX_DSP2>,
> +  < CLK_MM_SMI_COMMON>,
> +  < CLK_MM_SMI_LARB0>,
> +  < CLK_MM_SMI_LARB1>,
> +  < CLK_MM_GALS_COMM0>,
> +  < CLK_MM_GALS_COMM1>,
> +  < CLK_MM_GALS_CCU2MM>,
> +  < CLK_MM_GALS_IPU12MM>,
> +  < CLK_MM_GALS_IMG2MM>,
> +  < CLK_MM_GALS_CAM2MM>,
> +  < CLK_MM_GALS_IPU2MM>,

Just mention the discussion in [1], we need to confirm this is hardware
limitation or not.

[1] https://patchwork.kernel.org/patch/11005731/

Regards,
CK

> +  < CLK_IMG_LARB5>,
> +  < CLK_IMG_LARB2>,
> +  < CLK_CAM_LARB6>,
> +  < CLK_CAM_LARB3>,
> +  < CLK_CAM_SENINF>,
> +  < CLK_CAM_CAMSV0>,
> +  < CLK_CAM_CAMSV1>,
> +  < CLK_CAM_CAMSV2>,
> +  < CLK_CAM_CCU>,
> +  <_conn CLK_IPU_CONN_IPU>,
> +  <_conn CLK_IPU_CONN_AHB>,
> +  <_conn CLK_IPU_CONN_AXI>,
> +  <_conn CLK_IPU_CONN_ISP>,
> +  <_conn CLK_IPU_CONN_CAM_ADL>,
> +  <_conn CLK_IPU_CONN_IMG_ADL>;
> + clock-names = "audio", "audio1", "audio2",
> +   "mfg", "mm", "cam",
> +   "isp", "vpu", "vpu1",
> +   "vpu2", "vpu3", "mm-0",
> +   "mm-1", "mm-2", "mm-3",
> +   "mm-4", "mm-5", "mm-6",
> +   "mm-7", "mm-8", "mm-9",
> +   "isp-0", "isp-1", "cam-0",
> +   "cam-1", "cam-2", "cam-3",
> +   "cam-4", "cam-5", "cam-6",
> +   "vpu-0", "vpu-1", "vpu-2",
> +   "vpu-3", "vpu-4", "vpu-5";
> + infracfg = <>;
> + smi_comm = <_common>;
> + };
> +
>   apmixedsys: syscon@1000c000 {
>   compatible = "mediatek,mt8183-apmixedsys", "syscon";
>   reg = <0 0x1000c000 0 0x1000>;
> @@ -396,6 +453,11 @@
>   #clock-cells = <1>;
>   };
>  
> + smi_common: smi@14019000 {
> + compatible = "mediatek,mt8183-smi-common", "syscon";
> + reg = <0 0x14019000 0 0x1000>;
> + };
> +
>   imgsys: syscon@1502 {
>   compatible = "mediatek,mt8183-imgsys", "syscon";
>   reg = <0 0x1502 0 0x1000>;




[PATCH v7 13/13] arm64: dts: Add power controller device node of MT8183

2019-08-28 Thread Weiyi Lu
Add power controller node and smi-common node for MT8183
In scpsys node, it contains clocks and regmapping of
infracfg and smi-common for bus protection.

Signed-off-by: Weiyi Lu 
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 62 
 1 file changed, 62 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index c2749c4..66aaa07 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -8,6 +8,7 @@
 #include 
 #include 
 #include 
+#include 
 #include "mt8183-pinfunc.h"
 
 / {
@@ -238,6 +239,62 @@
#interrupt-cells = <2>;
};
 
+   scpsys: syscon@10006000 {
+   compatible = "mediatek,mt8183-scpsys", "syscon";
+   #power-domain-cells = <1>;
+   reg = <0 0x10006000 0 0x1000>;
+   clocks = < CLK_TOP_MUX_AUD_INTBUS>,
+< CLK_INFRA_AUDIO>,
+< CLK_INFRA_AUDIO_26M_BCLK>,
+< CLK_TOP_MUX_MFG>,
+< CLK_TOP_MUX_MM>,
+< CLK_TOP_MUX_CAM>,
+< CLK_TOP_MUX_IMG>,
+< CLK_TOP_MUX_IPU_IF>,
+< CLK_TOP_MUX_DSP>,
+< CLK_TOP_MUX_DSP1>,
+< CLK_TOP_MUX_DSP2>,
+< CLK_MM_SMI_COMMON>,
+< CLK_MM_SMI_LARB0>,
+< CLK_MM_SMI_LARB1>,
+< CLK_MM_GALS_COMM0>,
+< CLK_MM_GALS_COMM1>,
+< CLK_MM_GALS_CCU2MM>,
+< CLK_MM_GALS_IPU12MM>,
+< CLK_MM_GALS_IMG2MM>,
+< CLK_MM_GALS_CAM2MM>,
+< CLK_MM_GALS_IPU2MM>,
+< CLK_IMG_LARB5>,
+< CLK_IMG_LARB2>,
+< CLK_CAM_LARB6>,
+< CLK_CAM_LARB3>,
+< CLK_CAM_SENINF>,
+< CLK_CAM_CAMSV0>,
+< CLK_CAM_CAMSV1>,
+< CLK_CAM_CAMSV2>,
+< CLK_CAM_CCU>,
+<_conn CLK_IPU_CONN_IPU>,
+<_conn CLK_IPU_CONN_AHB>,
+<_conn CLK_IPU_CONN_AXI>,
+<_conn CLK_IPU_CONN_ISP>,
+<_conn CLK_IPU_CONN_CAM_ADL>,
+<_conn CLK_IPU_CONN_IMG_ADL>;
+   clock-names = "audio", "audio1", "audio2",
+ "mfg", "mm", "cam",
+ "isp", "vpu", "vpu1",
+ "vpu2", "vpu3", "mm-0",
+ "mm-1", "mm-2", "mm-3",
+ "mm-4", "mm-5", "mm-6",
+ "mm-7", "mm-8", "mm-9",
+ "isp-0", "isp-1", "cam-0",
+ "cam-1", "cam-2", "cam-3",
+ "cam-4", "cam-5", "cam-6",
+ "vpu-0", "vpu-1", "vpu-2",
+ "vpu-3", "vpu-4", "vpu-5";
+   infracfg = <>;
+   smi_comm = <_common>;
+   };
+
apmixedsys: syscon@1000c000 {
compatible = "mediatek,mt8183-apmixedsys", "syscon";
reg = <0 0x1000c000 0 0x1000>;
@@ -396,6 +453,11 @@
#clock-cells = <1>;
};
 
+   smi_common: smi@14019000 {
+   compatible = "mediatek,mt8183-smi-common", "syscon";
+   reg = <0 0x14019000 0 0x1000>;
+   };
+
imgsys: syscon@1502 {
compatible = "mediatek,mt8183-imgsys", "syscon";
reg = <0 0x1502 0 0x1000>;
-- 
1.8.1.1.dirty