Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2019-01-29 Thread Peter Zijlstra
On Thu, Jan 24, 2019 at 02:04:32PM +, Patrick Bellasi wrote: > > So if I'm not mistaken we then have 3 cases: > > > > 1) runnable == util <= capacity > > > > no contention, idle > > > > 2) runnable == util > capacity > > > > no contention, no idle > > > > 3) runnable > util >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2019-01-24 Thread Patrick Bellasi
On 24-Jan 10:07, Peter Zijlstra wrote: > > Sorry; trying to get back to this and re-reading the old conversations. > > On Thu, Nov 29, 2018 at 03:13:16PM +, Patrick Bellasi wrote: > > On 29-Nov 13:53, Peter Zijlstra wrote: > > > On Wed, Nov 28, 2018 at 11:53:36AM +, Patrick Bellasi

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2019-01-24 Thread Peter Zijlstra
Sorry; trying to get back to this and re-reading the old conversations. On Thu, Nov 29, 2018 at 03:13:16PM +, Patrick Bellasi wrote: > On 29-Nov 13:53, Peter Zijlstra wrote: > > On Wed, Nov 28, 2018 at 11:53:36AM +, Patrick Bellasi wrote: > > > > > diff --git a/kernel/sched/fair.c

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2019-01-11 Thread Vincent Guittot
On Thu, 10 Jan 2019 at 16:30, Patrick Bellasi wrote: > > On 29-Nov 17:19, Vincent Guittot wrote: > > On Thu, 29 Nov 2018 at 16:00, Patrick Bellasi > > wrote: > > > On 29-Nov 11:43, Vincent Guittot wrote: > > [...] > > > > Seems we agree that, when there is no idle time: > > > - the two 15%

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2019-01-10 Thread Patrick Bellasi
On 29-Nov 17:19, Vincent Guittot wrote: > On Thu, 29 Nov 2018 at 16:00, Patrick Bellasi wrote: > > On 29-Nov 11:43, Vincent Guittot wrote: [...] > > Seems we agree that, when there is no idle time: > > - the two 15% tasks will be overestimated > > - their utilization will reach 50% after a

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Vincent Guittot
On Thu, 29 Nov 2018 at 16:00, Patrick Bellasi wrote: > > On 29-Nov 11:43, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 17:35, Patrick Bellasi > > wrote: > > > On 28-Nov 16:42, Vincent Guittot wrote: > > > > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi > > > > wrote: > > > > > On 28-Nov

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Vincent Guittot
On Thu, 29 Nov 2018 at 16:00, Patrick Bellasi wrote: > > On 29-Nov 11:43, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 17:35, Patrick Bellasi > > wrote: > > > On 28-Nov 16:42, Vincent Guittot wrote: > > > > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi > > > > wrote: > > > > > On 28-Nov

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Patrick Bellasi
On 29-Nov 13:53, Peter Zijlstra wrote: > On Wed, Nov 28, 2018 at 11:53:36AM +, Patrick Bellasi wrote: > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index ac855b2f4774..93e0cf5d8a76 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -3661,6 +3661,10 @@

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Patrick Bellasi
On 29-Nov 13:53, Peter Zijlstra wrote: > On Wed, Nov 28, 2018 at 11:53:36AM +, Patrick Bellasi wrote: > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index ac855b2f4774..93e0cf5d8a76 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -3661,6 +3661,10 @@

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Patrick Bellasi
On 29-Nov 11:43, Vincent Guittot wrote: > On Wed, 28 Nov 2018 at 17:35, Patrick Bellasi wrote: > > On 28-Nov 16:42, Vincent Guittot wrote: > > > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi > > > wrote: > > > > On 28-Nov 15:55, Vincent Guittot wrote: > > > > > On Wed, 28 Nov 2018 at 15:40,

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Patrick Bellasi
On 29-Nov 11:43, Vincent Guittot wrote: > On Wed, 28 Nov 2018 at 17:35, Patrick Bellasi wrote: > > On 28-Nov 16:42, Vincent Guittot wrote: > > > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi > > > wrote: > > > > On 28-Nov 15:55, Vincent Guittot wrote: > > > > > On Wed, 28 Nov 2018 at 15:40,

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Peter Zijlstra
On Wed, Nov 28, 2018 at 11:53:36AM +, Patrick Bellasi wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index ac855b2f4774..93e0cf5d8a76 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3661,6 +3661,10 @@ util_est_dequeue(struct cfs_rq *cfs_rq, struct >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Peter Zijlstra
On Wed, Nov 28, 2018 at 11:53:36AM +, Patrick Bellasi wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index ac855b2f4774..93e0cf5d8a76 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3661,6 +3661,10 @@ util_est_dequeue(struct cfs_rq *cfs_rq, struct >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 17:35, Patrick Bellasi wrote: > > On 28-Nov 16:42, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 15:55, Vincent Guittot wrote: > > > > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi > > > > wrote: > > > > > > >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-29 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 17:35, Patrick Bellasi wrote: > > On 28-Nov 16:42, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 15:55, Vincent Guittot wrote: > > > > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi > > > > wrote: > > > > > > >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Patrick Bellasi
On 28-Nov 16:42, Vincent Guittot wrote: > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi wrote: > > > > On 28-Nov 15:55, Vincent Guittot wrote: > > > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi > > > wrote: > > > > > > > > On 28-Nov 14:33, Vincent Guittot wrote: > > > > > On Wed, 28 Nov 2018

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Patrick Bellasi
On 28-Nov 16:42, Vincent Guittot wrote: > On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi wrote: > > > > On 28-Nov 15:55, Vincent Guittot wrote: > > > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi > > > wrote: > > > > > > > > On 28-Nov 14:33, Vincent Guittot wrote: > > > > > On Wed, 28 Nov 2018

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi wrote: > > On 28-Nov 15:55, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 14:33, Vincent Guittot wrote: > > > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi > > > > wrote: > > > > > > >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 16:21, Patrick Bellasi wrote: > > On 28-Nov 15:55, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 14:33, Vincent Guittot wrote: > > > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi > > > > wrote: > > > > > > >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Patrick Bellasi
On 28-Nov 15:55, Vincent Guittot wrote: > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi wrote: > > > > On 28-Nov 14:33, Vincent Guittot wrote: > > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi > > > wrote: > > > > > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > > > On Wed, Nov 28, 2018

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Patrick Bellasi
On 28-Nov 15:55, Vincent Guittot wrote: > On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi wrote: > > > > On 28-Nov 14:33, Vincent Guittot wrote: > > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi > > > wrote: > > > > > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > > > On Wed, Nov 28, 2018

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi wrote: > > On 28-Nov 14:33, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > > >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 15:40, Patrick Bellasi wrote: > > On 28-Nov 14:33, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi > > wrote: > > > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > > >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Patrick Bellasi
On 28-Nov 14:33, Vincent Guittot wrote: > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi wrote: > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > > > Is there anything else that I should do for these patches ? > > > > >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Patrick Bellasi
On 28-Nov 14:33, Vincent Guittot wrote: > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi wrote: > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > > > Is there anything else that I should do for these patches ? > > > > >

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 14:33, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi wrote: > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > > > Is there anything else that I should do for these

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 14:33, Vincent Guittot wrote: > > On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi wrote: > > > > On 28-Nov 11:02, Peter Zijlstra wrote: > > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > > > Is there anything else that I should do for these

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi wrote: > > On 28-Nov 11:02, Peter Zijlstra wrote: > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > Is there anything else that I should do for these patches ? > > > > IIRC, Morten mention they break util_est; Patrick was

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
On Wed, 28 Nov 2018 at 12:53, Patrick Bellasi wrote: > > On 28-Nov 11:02, Peter Zijlstra wrote: > > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > > > Is there anything else that I should do for these patches ? > > > > IIRC, Morten mention they break util_est; Patrick was

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Patrick Bellasi
On 28-Nov 11:02, Peter Zijlstra wrote: > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > Is there anything else that I should do for these patches ? > > IIRC, Morten mention they break util_est; Patrick was going to explain. I guess the problem is that, once we cross the

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Patrick Bellasi
On 28-Nov 11:02, Peter Zijlstra wrote: > On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > > > Is there anything else that I should do for these patches ? > > IIRC, Morten mention they break util_est; Patrick was going to explain. I guess the problem is that, once we cross the

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Peter Zijlstra
On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > Is there anything else that I should do for these patches ? IIRC, Morten mention they break util_est; Patrick was going to explain. But yes, I like them.

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Peter Zijlstra
On Wed, Nov 28, 2018 at 10:54:13AM +0100, Vincent Guittot wrote: > Is there anything else that I should do for these patches ? IIRC, Morten mention they break util_est; Patrick was going to explain. But yes, I like them.

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
Hi, On Tue, 20 Nov 2018 at 11:55, Vincent Guittot wrote: > > The current implementation of load tracking invariance scales the > contribution with current frequency and uarch performance (only for > utilization) of the CPU. One main result of this formula is that the > figures are capped by

Re: [PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-28 Thread Vincent Guittot
Hi, On Tue, 20 Nov 2018 at 11:55, Vincent Guittot wrote: > > The current implementation of load tracking invariance scales the > contribution with current frequency and uarch performance (only for > utilization) of the CPU. One main result of this formula is that the > figures are capped by

[PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-20 Thread Vincent Guittot
The current implementation of load tracking invariance scales the contribution with current frequency and uarch performance (only for utilization) of the CPU. One main result of this formula is that the figures are capped by current capacity of CPU. Another one is that the load_avg is not

[PATCH v7 2/2] sched/fair: update scale invariance of PELT

2018-11-20 Thread Vincent Guittot
The current implementation of load tracking invariance scales the contribution with current frequency and uarch performance (only for utilization) of the CPU. One main result of this formula is that the figures are capped by current capacity of CPU. Another one is that the load_avg is not