Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-28 Thread Takashi Iwai
On Wed, 28 Nov 2018 01:49:48 +0100, ayman.baga...@gmail.com wrote: > > On Tue, 2018-11-27 at 17:52 +0200, Andy Shevchenko wrote: > > On Tue, Nov 27, 2018 at 1:02 PM Takashi Iwai wrote: > > > On Tue, 27 Nov 2018 03:57:48 +0100, > > > Ayman Bagabas wrote: > > > > + handle = ACPI_HANDLE(&inputde

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-27 Thread ayman . bagabas
On Tue, 2018-11-27 at 10:45 +0100, Takashi Iwai wrote: > On Tue, 27 Nov 2018 03:57:48 +0100, > Ayman Bagabas wrote: > > +static const struct key_entry huawei_wmi_keymap[] __initconst = { > > + { KE_KEY,0x281, { KEY_BRIGHTNESSDOWN } }, > > + { KE_KEY,0x282, { KEY_BRIGHTNE

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-27 Thread ayman . bagabas
On Tue, 2018-11-27 at 17:52 +0200, Andy Shevchenko wrote: > On Tue, Nov 27, 2018 at 1:02 PM Takashi Iwai wrote: > > On Tue, 27 Nov 2018 03:57:48 +0100, > > Ayman Bagabas wrote: > > > + handle = ACPI_HANDLE(&inputdev->dev); > > > + args[0].type = args[1].type = args[2].type = > > > ACPI_TYP

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-27 Thread Andy Shevchenko
On Tue, Nov 27, 2018 at 1:02 PM Takashi Iwai wrote: > On Tue, 27 Nov 2018 03:57:48 +0100, > Ayman Bagabas wrote: > > + handle = ACPI_HANDLE(&inputdev->dev); > > + args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER; > > + args[1].integer.value = 0x04; > > + > > + if (ac

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-27 Thread Takashi Iwai
Some more forgotten bits... On Tue, 27 Nov 2018 03:57:48 +0100, Ayman Bagabas wrote: > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > +config HUAWEI_WMI > + tristate "Huawei WMI hotkeys driver" > + depends on ACPI_WMI > + depends on INPUT > + select

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-27 Thread Takashi Iwai
On Tue, 27 Nov 2018 03:57:48 +0100, Ayman Bagabas wrote: > > +static const struct key_entry huawei_wmi_keymap[] __initconst = { > + { KE_KEY,0x281, { KEY_BRIGHTNESSDOWN } }, > + { KE_KEY,0x282, { KEY_BRIGHTNESSUP } }, > + { KE_KEY,0x284, { KEY_MUTE }

[PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-26 Thread Ayman Bagabas
This driver adds support for missing hotkeys on some Huawei laptops. Currently, only Huawei Matebook X and Matebook X Pro is supported. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/Kconfig | 15 ++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 247

[PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-26 Thread Ayman Bagabas
This driver adds support for missing hotkeys on some Huawei laptops. Currently, only Huawei Matebook X and Matebook X Pro is supported. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/Kconfig | 15 ++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/huawei-wmi.c | 247