Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-07-30 Thread Stephen Boyd
Quoting Bjorn Andersson (2019-05-23 12:09:25) > > I had to read through the clock code to conclude that this was indeed > the design, so I'm happy with your patch of ensuring that this is > followed. Perhaps add a statement in the kerneldoc for struct clk_hw as > well to state that init won't be

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-25 Thread Bjorn Andersson
On Sat 25 May 10:53 PDT 2019, Sai Prakash Ranjan wrote: > On 5/1/2019 10:07 AM, Bjorn Andersson wrote: > > The Always On Subsystem (AOSS) Qualcomm Messaging Protocol (QMP) driver > > is used to communicate with the AOSS for certain side-channel requests, > > that are not available through the

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-25 Thread Sai Prakash Ranjan
On 5/1/2019 10:07 AM, Bjorn Andersson wrote: The Always On Subsystem (AOSS) Qualcomm Messaging Protocol (QMP) driver is used to communicate with the AOSS for certain side-channel requests, that are not available through the RPMh interface. The communication is a very simple synchronous

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-23 Thread Bjorn Andersson
On Thu 23 May 11:05 PDT 2019, Stephen Boyd wrote: > Quoting Doug Anderson (2019-05-23 09:38:13) > > Hi, > > > > On Tue, Apr 30, 2019 at 9:38 PM Bjorn Andersson > > wrote: > > > > > +static int qmp_qdss_clk_add(struct qmp *qmp) > > > +{ > > > + struct clk_init_data qdss_init = { > > > +

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-23 Thread Bjorn Andersson
On Thu 23 May 09:38 PDT 2019, Doug Anderson wrote: > Hi, > > On Tue, Apr 30, 2019 at 9:38 PM Bjorn Andersson > wrote: > > > > +static int qmp_qdss_clk_prepare(struct clk_hw *hw) > > +{ > > + struct qmp *qmp = container_of(hw, struct qmp, qdss_clk); > > + char buf[QMP_MSG_LEN] =

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-23 Thread Doug Anderson
Hi, On Thu, May 23, 2019 at 11:05 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2019-05-23 09:38:13) > > Hi, > > > > On Tue, Apr 30, 2019 at 9:38 PM Bjorn Andersson > > wrote: > > > > > +static int qmp_qdss_clk_add(struct qmp *qmp) > > > +{ > > > + struct clk_init_data qdss_init = {

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-23 Thread Stephen Boyd
Quoting Doug Anderson (2019-05-23 09:38:13) > Hi, > > On Tue, Apr 30, 2019 at 9:38 PM Bjorn Andersson > wrote: > > > +static int qmp_qdss_clk_add(struct qmp *qmp) > > +{ > > + struct clk_init_data qdss_init = { > > + .ops = _qdss_clk_ops, > > + .name = "qdss",

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-23 Thread Doug Anderson
Hi, On Tue, Apr 30, 2019 at 9:38 PM Bjorn Andersson wrote: > > +static int qmp_qdss_clk_prepare(struct clk_hw *hw) > +{ > + struct qmp *qmp = container_of(hw, struct qmp, qdss_clk); > + char buf[QMP_MSG_LEN] = "{class: clock, res: qdss, val: 1}"; nit: "static const" the buf? No

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-21 Thread Vinod Koul
On 30-04-19, 21:37, Bjorn Andersson wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I would have preferred this as first one, but this is fine too :) > +/* Linux-side offsets */ > +#define QMP_DESC_MCORE_LINK_STATE0x24 >

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-21 Thread Arun Kumar Neelakantam
Hi Bjorn, On 5/1/2019 10:07 AM, Bjorn Andersson wrote: The Always On Subsystem (AOSS) Qualcomm Messaging Protocol (QMP) driver is used to communicate with the AOSS for certain side-channel requests, that are not available through the RPMh interface. The communication is a very simple

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-13 Thread Sibi Sankar
Hey Bjorn, On 5/1/19 10:07 AM, Bjorn Andersson wrote: The Always On Subsystem (AOSS) Qualcomm Messaging Protocol (QMP) driver is used to communicate with the AOSS for certain side-channel requests, that are not available through the RPMh interface. The communication is a very simple

[PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-04-30 Thread Bjorn Andersson
The Always On Subsystem (AOSS) Qualcomm Messaging Protocol (QMP) driver is used to communicate with the AOSS for certain side-channel requests, that are not available through the RPMh interface. The communication is a very simple synchronous mechanism of messages being written in message RAM and