subject:"\[PATCH v8\] media\: i2c\: add support for omnivision's ov2659 sensor"

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Lad, Prabhakar

On Fri, Mar 20, 2015 at 12:05 PM, Varka Bhadram  wrote:
> On 03/20/2015 05:18 PM, Lad Prabhakar wrote:
>
>> From: Benoit Parrot 
>>
>> this patch adds support for omnivision's ov2659
>> sensor, the driver supports following features:
>> 1: Asynchronous probing
>> 2: DT support
>> 3: Media controller support
>>
>> Signed-off-by: Benoit Parrot 
>> Signed-off-by: Lad, Prabhakar 
>> Acked-by: Sakari Ailus 
>> ---
>>   Changes for v8:
>>   --
>>   a. Now setting the link_frequency control in set_fmt
>>  callback instead of implementing g_volatile_ctrl()
>>  for it and setting it there.
>>
>>   v7: https://patchwork.kernel.org/patch/6034651/
>>   v6: https://patchwork.kernel.org/patch/6012751/
>>   v5: https://patchwork.kernel.org/patch/6000161/
>>   v4: https://patchwork.kernel.org/patch/5961661/
>>   v3: https://patchwork.kernel.org/patch/5959401/
>>   v2: https://patchwork.kernel.org/patch/5859801/
>>   v1: https://patchwork.linuxtv.org/patch/27919/
>>
>>   .../devicetree/bindings/media/i2c/ov2659.txt   |   38 +
>>   MAINTAINERS|   10 +
>>   drivers/media/i2c/Kconfig  |   11 +
>>   drivers/media/i2c/Makefile |1 +
>>   drivers/media/i2c/ov2659.c | 1528
>> 
>>   include/media/ov2659.h |   33 +
>>   6 files changed, 1621 insertions(+)
>>   create mode 100644
>> Documentation/devicetree/bindings/media/i2c/ov2659.txt
>>   create mode 100644 drivers/media/i2c/ov2659.c
>>   create mode 100644 include/media/ov2659.h
>>
> (...)
>
>> +static struct ov2659_platform_data *
>> +ov2659_get_pdata(struct i2c_client *client)
>> +{
>> +   struct ov2659_platform_data *pdata;
>> +   struct device_node *endpoint;
>> +   int ret;
>> +
>> +   if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node) {
>> +   dev_err(>dev, "ov2659_get_pdata: DT Node
>> found\n");
>
>
> ov2659_get_pdata: DT Node *not* found...?
>
Good catch!

Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Varka Bhadram


On 03/20/2015 05:18 PM, Lad Prabhakar wrote:


From: Benoit Parrot 

this patch adds support for omnivision's ov2659
sensor, the driver supports following features:
1: Asynchronous probing
2: DT support
3: Media controller support

Signed-off-by: Benoit Parrot 
Signed-off-by: Lad, Prabhakar 
Acked-by: Sakari Ailus 
---
  Changes for v8:
  --
  a. Now setting the link_frequency control in set_fmt
 callback instead of implementing g_volatile_ctrl()
 for it and setting it there.

  v7: https://patchwork.kernel.org/patch/6034651/
  v6: https://patchwork.kernel.org/patch/6012751/
  v5: https://patchwork.kernel.org/patch/6000161/
  v4: https://patchwork.kernel.org/patch/5961661/
  v3: https://patchwork.kernel.org/patch/5959401/
  v2: https://patchwork.kernel.org/patch/5859801/
  v1: https://patchwork.linuxtv.org/patch/27919/

  .../devicetree/bindings/media/i2c/ov2659.txt   |   38 +
  MAINTAINERS|   10 +
  drivers/media/i2c/Kconfig  |   11 +
  drivers/media/i2c/Makefile |1 +
  drivers/media/i2c/ov2659.c | 1528 
  include/media/ov2659.h |   33 +
  6 files changed, 1621 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2659.txt
  create mode 100644 drivers/media/i2c/ov2659.c
  create mode 100644 include/media/ov2659.h


(...)


+static struct ov2659_platform_data *
+ov2659_get_pdata(struct i2c_client *client)
+{
+   struct ov2659_platform_data *pdata;
+   struct device_node *endpoint;
+   int ret;
+
+   if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node) {
+   dev_err(>dev, "ov2659_get_pdata: DT Node found\n");


ov2659_get_pdata: DT Node *not* found...?

--
Varka Bhadram

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Lad Prabhakar

From: Benoit Parrot 

this patch adds support for omnivision's ov2659
sensor, the driver supports following features:
1: Asynchronous probing
2: DT support
3: Media controller support

Signed-off-by: Benoit Parrot 
Signed-off-by: Lad, Prabhakar 
Acked-by: Sakari Ailus 
---
 Changes for v8:
 --
 a. Now setting the link_frequency control in set_fmt
callback instead of implementing g_volatile_ctrl()
for it and setting it there.

 v7: https://patchwork.kernel.org/patch/6034651/
 v6: https://patchwork.kernel.org/patch/6012751/
 v5: https://patchwork.kernel.org/patch/6000161/
 v4: https://patchwork.kernel.org/patch/5961661/
 v3: https://patchwork.kernel.org/patch/5959401/
 v2: https://patchwork.kernel.org/patch/5859801/
 v1: https://patchwork.linuxtv.org/patch/27919/

 .../devicetree/bindings/media/i2c/ov2659.txt   |   38 +
 MAINTAINERS|   10 +
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |1 +
 drivers/media/i2c/ov2659.c | 1528 
 include/media/ov2659.h |   33 +
 6 files changed, 1621 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2659.txt
 create mode 100644 drivers/media/i2c/ov2659.c
 create mode 100644 include/media/ov2659.h

diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt 
b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
new file mode 100644
index 000..cabc7d8
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
@@ -0,0 +1,38 @@
+* OV2659 1/5-Inch 2Mp SOC Camera
+
+The Omnivision OV2659 is a 1/5-inch SOC camera, with an active array size of
+1632H x 1212V. It is programmable through a SCCB. The OV2659 sensor supports
+multiple resolutions output, such as UXGA, SVGA, 720p. It also can support
+YUV422, RGB565/555 or raw RGB output formats.
+
+Required Properties:
+- compatible: Must be "ovti,ov2659"
+- reg: I2C slave address
+- clocks: reference to the xvclk input clock.
+- clock-names: should be "xvclk".
+- link-frequencies: target pixel clock frequency.
+
+For further reading on port node refer to
+Documentation/devicetree/bindings/media/video-interfaces.txt.
+
+Example:
+
+   i2c0@1c22000 {
+   ...
+   ...
+ov2659@30 {
+   compatible = "ovti,ov2659";
+   reg = <0x30>;
+
+   clocks = <_ov2659 0>;
+   clock-names = "xvclk";
+
+   port {
+   ov2659_0: endpoint {
+   remote-endpoint = <_ep>;
+   link-frequencies = /bits/ 64 <7000>;
+   };
+   };
+   };
+   ...
+   };
diff --git a/MAINTAINERS b/MAINTAINERS
index ddc5a8c..4006cc8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8910,6 +8910,16 @@ T:   git 
git://linuxtv.org/mhadli/v4l-dvb-davinci_devices.git
 S: Maintained
 F: drivers/media/platform/am437x/
 
+OV2659 OMNIVISION SENSOR DRIVER
+M: Lad, Prabhakar 
+L: linux-me...@vger.kernel.org
+W: http://linuxtv.org/
+Q: http://patchwork.linuxtv.org/project/linux-media/list/
+T: git git://linuxtv.org/mhadli/v4l-dvb-davinci_devices.git
+S: Maintained
+F: drivers/media/i2c/ov2659.c
+F: include/media/ov2659.h
+
 SIS 190 ETHERNET DRIVER
 M: Francois Romieu 
 L: net...@vger.kernel.org
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index da58c9b..6f30ea7 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -466,6 +466,17 @@ config VIDEO_APTINA_PLL
 config VIDEO_SMIAPP_PLL
tristate
 
+config VIDEO_OV2659
+   tristate "OmniVision OV2659 sensor support"
+   depends on VIDEO_V4L2 && I2C
+   depends on MEDIA_CAMERA_SUPPORT
+   ---help---
+ This is a Video4Linux2 sensor-level driver for the OmniVision
+ OV2659 camera.
+
+ To compile this driver as a module, choose M here: the
+ module will be called ov2659.
+
 config VIDEO_OV7640
tristate "OmniVision OV7640 sensor support"
depends on I2C && VIDEO_V4L2
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index 98589001..f165fae 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -77,3 +77,4 @@ obj-$(CONFIG_VIDEO_SMIAPP_PLL)+= smiapp-pll.o
 obj-$(CONFIG_VIDEO_AK881X) += ak881x.o
 obj-$(CONFIG_VIDEO_IR_I2C)  += ir-kbd-i2c.o
 obj-$(CONFIG_VIDEO_ML86V7667)  += ml86v7667.o
+obj-$(CONFIG_VIDEO_OV2659) += ov2659.o
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
new file mode 100644
index 000..94f11dc
--- /dev/null
+++ b/drivers/media/i2c/ov2659.c
@@ -0,0 +1,1528 @@
+/*
+ * Omnivision OV2659 CMOS Image Sensor driver
+ *
+ *

[PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Lad Prabhakar

From: Benoit Parrot bpar...@ti.com

this patch adds support for omnivision's ov2659
sensor, the driver supports following features:
1: Asynchronous probing
2: DT support
3: Media controller support

Signed-off-by: Benoit Parrot bpar...@ti.com
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
---
 Changes for v8:
 --
 a. Now setting the link_frequency control in set_fmt
callback instead of implementing g_volatile_ctrl()
for it and setting it there.

 v7: https://patchwork.kernel.org/patch/6034651/
 v6: https://patchwork.kernel.org/patch/6012751/
 v5: https://patchwork.kernel.org/patch/6000161/
 v4: https://patchwork.kernel.org/patch/5961661/
 v3: https://patchwork.kernel.org/patch/5959401/
 v2: https://patchwork.kernel.org/patch/5859801/
 v1: https://patchwork.linuxtv.org/patch/27919/

 .../devicetree/bindings/media/i2c/ov2659.txt   |   38 +
 MAINTAINERS|   10 +
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |1 +
 drivers/media/i2c/ov2659.c | 1528 
 include/media/ov2659.h |   33 +
 6 files changed, 1621 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2659.txt
 create mode 100644 drivers/media/i2c/ov2659.c
 create mode 100644 include/media/ov2659.h

diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt 
b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
new file mode 100644
index 000..cabc7d8
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
@@ -0,0 +1,38 @@
+* OV2659 1/5-Inch 2Mp SOC Camera
+
+The Omnivision OV2659 is a 1/5-inch SOC camera, with an active array size of
+1632H x 1212V. It is programmable through a SCCB. The OV2659 sensor supports
+multiple resolutions output, such as UXGA, SVGA, 720p. It also can support
+YUV422, RGB565/555 or raw RGB output formats.
+
+Required Properties:
+- compatible: Must be ovti,ov2659
+- reg: I2C slave address
+- clocks: reference to the xvclk input clock.
+- clock-names: should be xvclk.
+- link-frequencies: target pixel clock frequency.
+
+For further reading on port node refer to
+Documentation/devicetree/bindings/media/video-interfaces.txt.
+
+Example:
+
+   i2c0@1c22000 {
+   ...
+   ...
+ov2659@30 {
+   compatible = ovti,ov2659;
+   reg = 0x30;
+
+   clocks = clk_ov2659 0;
+   clock-names = xvclk;
+
+   port {
+   ov2659_0: endpoint {
+   remote-endpoint = vpfe_ep;
+   link-frequencies = /bits/ 64 7000;
+   };
+   };
+   };
+   ...
+   };
diff --git a/MAINTAINERS b/MAINTAINERS
index ddc5a8c..4006cc8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8910,6 +8910,16 @@ T:   git 
git://linuxtv.org/mhadli/v4l-dvb-davinci_devices.git
 S: Maintained
 F: drivers/media/platform/am437x/
 
+OV2659 OMNIVISION SENSOR DRIVER
+M: Lad, Prabhakar prabhakar.cse...@gmail.com
+L: linux-me...@vger.kernel.org
+W: http://linuxtv.org/
+Q: http://patchwork.linuxtv.org/project/linux-media/list/
+T: git git://linuxtv.org/mhadli/v4l-dvb-davinci_devices.git
+S: Maintained
+F: drivers/media/i2c/ov2659.c
+F: include/media/ov2659.h
+
 SIS 190 ETHERNET DRIVER
 M: Francois Romieu rom...@fr.zoreil.com
 L: net...@vger.kernel.org
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index da58c9b..6f30ea7 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -466,6 +466,17 @@ config VIDEO_APTINA_PLL
 config VIDEO_SMIAPP_PLL
tristate
 
+config VIDEO_OV2659
+   tristate OmniVision OV2659 sensor support
+   depends on VIDEO_V4L2  I2C
+   depends on MEDIA_CAMERA_SUPPORT
+   ---help---
+ This is a Video4Linux2 sensor-level driver for the OmniVision
+ OV2659 camera.
+
+ To compile this driver as a module, choose M here: the
+ module will be called ov2659.
+
 config VIDEO_OV7640
tristate OmniVision OV7640 sensor support
depends on I2C  VIDEO_V4L2
diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
index 98589001..f165fae 100644
--- a/drivers/media/i2c/Makefile
+++ b/drivers/media/i2c/Makefile
@@ -77,3 +77,4 @@ obj-$(CONFIG_VIDEO_SMIAPP_PLL)+= smiapp-pll.o
 obj-$(CONFIG_VIDEO_AK881X) += ak881x.o
 obj-$(CONFIG_VIDEO_IR_I2C)  += ir-kbd-i2c.o
 obj-$(CONFIG_VIDEO_ML86V7667)  += ml86v7667.o
+obj-$(CONFIG_VIDEO_OV2659) += ov2659.o
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
new file mode 100644
index 000..94f11dc
--- /dev/null
+++

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Varka Bhadram


On 03/20/2015 05:18 PM, Lad Prabhakar wrote:


From: Benoit Parrot bpar...@ti.com

this patch adds support for omnivision's ov2659
sensor, the driver supports following features:
1: Asynchronous probing
2: DT support
3: Media controller support

Signed-off-by: Benoit Parrot bpar...@ti.com
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
---
  Changes for v8:
  --
  a. Now setting the link_frequency control in set_fmt
 callback instead of implementing g_volatile_ctrl()
 for it and setting it there.

  v7: https://patchwork.kernel.org/patch/6034651/
  v6: https://patchwork.kernel.org/patch/6012751/
  v5: https://patchwork.kernel.org/patch/6000161/
  v4: https://patchwork.kernel.org/patch/5961661/
  v3: https://patchwork.kernel.org/patch/5959401/
  v2: https://patchwork.kernel.org/patch/5859801/
  v1: https://patchwork.linuxtv.org/patch/27919/

  .../devicetree/bindings/media/i2c/ov2659.txt   |   38 +
  MAINTAINERS|   10 +
  drivers/media/i2c/Kconfig  |   11 +
  drivers/media/i2c/Makefile |1 +
  drivers/media/i2c/ov2659.c | 1528 
  include/media/ov2659.h |   33 +
  6 files changed, 1621 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2659.txt
  create mode 100644 drivers/media/i2c/ov2659.c
  create mode 100644 include/media/ov2659.h


(...)


+static struct ov2659_platform_data *
+ov2659_get_pdata(struct i2c_client *client)
+{
+   struct ov2659_platform_data *pdata;
+   struct device_node *endpoint;
+   int ret;
+
+   if (!IS_ENABLED(CONFIG_OF) || !client-dev.of_node) {
+   dev_err(client-dev, ov2659_get_pdata: DT Node found\n);


ov2659_get_pdata: DT Node *not* found...?

--
Varka Bhadram

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

2015-03-20 Thread Lad, Prabhakar

On Fri, Mar 20, 2015 at 12:05 PM, Varka Bhadram varkabhad...@gmail.com wrote:
 On 03/20/2015 05:18 PM, Lad Prabhakar wrote:

 From: Benoit Parrot bpar...@ti.com

 this patch adds support for omnivision's ov2659
 sensor, the driver supports following features:
 1: Asynchronous probing
 2: DT support
 3: Media controller support

 Signed-off-by: Benoit Parrot bpar...@ti.com
 Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
 Acked-by: Sakari Ailus sakari.ai...@linux.intel.com
 ---
   Changes for v8:
   --
   a. Now setting the link_frequency control in set_fmt
  callback instead of implementing g_volatile_ctrl()
  for it and setting it there.

   v7: https://patchwork.kernel.org/patch/6034651/
   v6: https://patchwork.kernel.org/patch/6012751/
   v5: https://patchwork.kernel.org/patch/6000161/
   v4: https://patchwork.kernel.org/patch/5961661/
   v3: https://patchwork.kernel.org/patch/5959401/
   v2: https://patchwork.kernel.org/patch/5859801/
   v1: https://patchwork.linuxtv.org/patch/27919/

   .../devicetree/bindings/media/i2c/ov2659.txt   |   38 +
   MAINTAINERS|   10 +
   drivers/media/i2c/Kconfig  |   11 +
   drivers/media/i2c/Makefile |1 +
   drivers/media/i2c/ov2659.c | 1528
 
   include/media/ov2659.h |   33 +
   6 files changed, 1621 insertions(+)
   create mode 100644
 Documentation/devicetree/bindings/media/i2c/ov2659.txt
   create mode 100644 drivers/media/i2c/ov2659.c
   create mode 100644 include/media/ov2659.h

 (...)

 +static struct ov2659_platform_data *
 +ov2659_get_pdata(struct i2c_client *client)
 +{
 +   struct ov2659_platform_data *pdata;
 +   struct device_node *endpoint;
 +   int ret;
 +
 +   if (!IS_ENABLED(CONFIG_OF) || !client-dev.of_node) {
 +   dev_err(client-dev, ov2659_get_pdata: DT Node
 found\n);


 ov2659_get_pdata: DT Node *not* found...?

Good catch!

Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

[PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

[PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

6 matches

Site Navigation

Mail list logo

Footer information