Re: [PATCH v8 0/7] i2c: Add FSI-attached I2C master algorithm

2018-05-31 Thread Benjamin Herrenschmidt
On Thu, 2018-05-31 at 09:29 +0300, Andy Shevchenko wrote: > > If you have specific issues with how this is done, please express them > > clearly. It's quite possible that there's some better way to do what > > Eddie is doing here, but without *construtive* feedback this is > > pointless. > > It fe

Re: [PATCH v8 0/7] i2c: Add FSI-attached I2C master algorithm

2018-05-30 Thread Andy Shevchenko
On Thu, May 31, 2018 at 1:42 AM, Benjamin Herrenschmidt wrote: > On Thu, 2018-05-31 at 00:31 +0300, Andy Shevchenko wrote: >> On Thu, May 31, 2018 at 12:07 AM, Eddie James >> wrote: >> I'll comment the series later, though you have to address previous >> comments first: >> - understand devm_ pur

Re: [PATCH v8 0/7] i2c: Add FSI-attached I2C master algorithm

2018-05-30 Thread Benjamin Herrenschmidt
On Thu, 2018-05-31 at 00:31 +0300, Andy Shevchenko wrote: > On Thu, May 31, 2018 at 12:07 AM, Eddie James > wrote: > > This series adds an algorithm for an I2C master physically located on an FSI > > slave device. The I2C master has multiple ports, each of which may be > > connected > > to an I2C

Re: [PATCH v8 0/7] i2c: Add FSI-attached I2C master algorithm

2018-05-30 Thread Andy Shevchenko
On Thu, May 31, 2018 at 12:07 AM, Eddie James wrote: > This series adds an algorithm for an I2C master physically located on an FSI > slave device. The I2C master has multiple ports, each of which may be > connected > to an I2C slave. Access to the I2C master registers is achieved over FSI bus. >

[PATCH v8 0/7] i2c: Add FSI-attached I2C master algorithm

2018-05-30 Thread Eddie James
This series adds an algorithm for an I2C master physically located on an FSI slave device. The I2C master has multiple ports, each of which may be connected to an I2C slave. Access to the I2C master registers is achieved over FSI bus. Due to the multi-port nature of the I2C master, the driver inst