Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-12 Thread Dou Liyang
Hi Baoquan, At 09/13/2017 10:30 AM, Baoquan He wrote: Hi dou, On 09/12/17 at 09:20am, Dou Liyang wrote: I thought again and again, I would not change this check logic. Because actually, we have three possibilities: 1. ACPI on chip 2. 82489DX 3. no APIC lapic_is_integrated() is used

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-12 Thread Dou Liyang
Hi Baoquan, At 09/13/2017 10:30 AM, Baoquan He wrote: Hi dou, On 09/12/17 at 09:20am, Dou Liyang wrote: I thought again and again, I would not change this check logic. Because actually, we have three possibilities: 1. ACPI on chip 2. 82489DX 3. no APIC lapic_is_integrated() is used

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-12 Thread Baoquan He
Hi dou, On 09/12/17 at 09:20am, Dou Liyang wrote: > I thought again and again, I would not change this check logic. > > Because actually, we have three possibilities: > > 1. ACPI on chip > 2. 82489DX > 3. no APIC > > lapic_is_integrated() is used to check the APIC's type which is > APIC

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-12 Thread Baoquan He
Hi dou, On 09/12/17 at 09:20am, Dou Liyang wrote: > I thought again and again, I would not change this check logic. > > Because actually, we have three possibilities: > > 1. ACPI on chip > 2. 82489DX > 3. no APIC > > lapic_is_integrated() is used to check the APIC's type which is > APIC

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-12 Thread Baoquan He
Hi dou, I tested your patchset, the result is positive. Kdump kernel functions well. About the sanity check in patch 1/13, I still have concerns. On 09/12/17 at 09:20am, Dou Liyang wrote: > Hi Baoquan, > > At 09/07/2017 01:22 PM, Baoquan He wrote: > > On 09/07/17 at 12:19pm, Dou Liyang wrote: >

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-12 Thread Baoquan He
Hi dou, I tested your patchset, the result is positive. Kdump kernel functions well. About the sanity check in patch 1/13, I still have concerns. On 09/12/17 at 09:20am, Dou Liyang wrote: > Hi Baoquan, > > At 09/07/2017 01:22 PM, Baoquan He wrote: > > On 09/07/17 at 12:19pm, Dou Liyang wrote: >

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-11 Thread Dou Liyang
Hi Baoquan, At 09/07/2017 01:22 PM, Baoquan He wrote: On 09/07/17 at 12:19pm, Dou Liyang wrote: Hi Baoquan I am wordy one ah: our target is checking if BIOS supports APIC, no matter what type(separated/integrated) it is. if not, go to PIC mode. Let‘s discuss the original logic and the

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-11 Thread Dou Liyang
Hi Baoquan, At 09/07/2017 01:22 PM, Baoquan He wrote: On 09/07/17 at 12:19pm, Dou Liyang wrote: Hi Baoquan I am wordy one ah: our target is checking if BIOS supports APIC, no matter what type(separated/integrated) it is. if not, go to PIC mode. Let‘s discuss the original logic and the

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-06 Thread Baoquan He
On 09/07/17 at 12:19pm, Dou Liyang wrote: > Hi Baoquan > > I am wordy one ah: > our target is checking if BIOS supports APIC, no matter what > type(separated/integrated) it is. if not, go to PIC mode. > > Let‘s discuss the original logic and the smp_found_config, > then take about your code. >

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-06 Thread Baoquan He
On 09/07/17 at 12:19pm, Dou Liyang wrote: > Hi Baoquan > > I am wordy one ah: > our target is checking if BIOS supports APIC, no matter what > type(separated/integrated) it is. if not, go to PIC mode. > > Let‘s discuss the original logic and the smp_found_config, > then take about your code. >

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-06 Thread Dou Liyang
Hi Baoquan I am wordy one ah: our target is checking if BIOS supports APIC, no matter what type(separated/integrated) it is. if not, go to PIC mode. Let‘s discuss the original logic and the smp_found_config, then take about your code. The existing logic is: if

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-06 Thread Dou Liyang
Hi Baoquan I am wordy one ah: our target is checking if BIOS supports APIC, no matter what type(separated/integrated) it is. if not, go to PIC mode. Let‘s discuss the original logic and the smp_found_config, then take about your code. The existing logic is: if

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-06 Thread Baoquan He
Hi Dou, On 08/28/17 at 11:20am, Dou Liyang wrote: > +static int __init apic_intr_mode_select(void) > +{ > + /* Check kernel option */ > + if (disable_apic) { > + pr_info("APIC disabled via kernel command line\n"); > + return APIC_PIC; > + } > + I am not very

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-06 Thread Baoquan He
Hi Dou, On 08/28/17 at 11:20am, Dou Liyang wrote: > +static int __init apic_intr_mode_select(void) > +{ > + /* Check kernel option */ > + if (disable_apic) { > + pr_info("APIC disabled via kernel command line\n"); > + return APIC_PIC; > + } > + I am not very

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-06 Thread Baoquan He
On 09/06/17 at 12:18pm, Dou Liyang wrote: > > > +static int __init apic_intr_mode_select(void) > > > +{ > > > + /* Check kernel option */ > > > + if (disable_apic) { > > > + pr_info("APIC disabled via kernel command line\n"); > > > + return APIC_PIC; > > > + } > > > + > > > + /*

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-06 Thread Baoquan He
On 09/06/17 at 12:18pm, Dou Liyang wrote: > > > +static int __init apic_intr_mode_select(void) > > > +{ > > > + /* Check kernel option */ > > > + if (disable_apic) { > > > + pr_info("APIC disabled via kernel command line\n"); > > > + return APIC_PIC; > > > + } > > > + > > > + /*

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-05 Thread Dou Liyang
Hi Baoquan, Thanks for your reply! My answer is in below. At 09/06/2017 08:55 AM, Baoquan He wrote: Hi Liyang, On 08/28/17 at 11:20am, Dou Liyang wrote: Now, there are many switches in kernel which are used to determine the final interrupt delivery mode, as shown below: 1) kconfig:

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-05 Thread Dou Liyang
Hi Baoquan, Thanks for your reply! My answer is in below. At 09/06/2017 08:55 AM, Baoquan He wrote: Hi Liyang, On 08/28/17 at 11:20am, Dou Liyang wrote: Now, there are many switches in kernel which are used to determine the final interrupt delivery mode, as shown below: 1) kconfig:

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-05 Thread Baoquan He
Hi Liyang, On 08/28/17 at 11:20am, Dou Liyang wrote: > Now, there are many switches in kernel which are used to determine > the final interrupt delivery mode, as shown below: > > 1) kconfig: >CONFIG_X86_64; CONFIG_X86_LOCAL_APIC; CONFIG_x86_IO_APIC > 2) kernel option: disable_apic;

Re: [PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-09-05 Thread Baoquan He
Hi Liyang, On 08/28/17 at 11:20am, Dou Liyang wrote: > Now, there are many switches in kernel which are used to determine > the final interrupt delivery mode, as shown below: > > 1) kconfig: >CONFIG_X86_64; CONFIG_X86_LOCAL_APIC; CONFIG_x86_IO_APIC > 2) kernel option: disable_apic;

[PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-08-27 Thread Dou Liyang
Now, there are many switches in kernel which are used to determine the final interrupt delivery mode, as shown below: 1) kconfig: CONFIG_X86_64; CONFIG_X86_LOCAL_APIC; CONFIG_x86_IO_APIC 2) kernel option: disable_apic; skip_ioapic_setup 3) CPU Capability: boot_cpu_has(X86_FEATURE_APIC) 4) MP

[PATCH v8 01/13] x86/apic: Construct a selector for the interrupt delivery mode

2017-08-27 Thread Dou Liyang
Now, there are many switches in kernel which are used to determine the final interrupt delivery mode, as shown below: 1) kconfig: CONFIG_X86_64; CONFIG_X86_LOCAL_APIC; CONFIG_x86_IO_APIC 2) kernel option: disable_apic; skip_ioapic_setup 3) CPU Capability: boot_cpu_has(X86_FEATURE_APIC) 4) MP