Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware
interface when unbinding the device.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulie...@suse.de>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 8b2b4771f420..e39897c38e6a 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -2738,7 +2738,7 @@ static int vchiq_probe(struct platform_device *pdev)
                return -ENOENT;
        }
 
-       drvdata->fw = rpi_firmware_get(fw_node);
+       drvdata->fw = devm_rpi_firmware_get(&pdev->dev, fw_node);
        of_node_put(fw_node);
        if (!drvdata->fw)
                return -EPROBE_DEFER;
-- 
2.30.1

Reply via email to