Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread Viresh Kumar
On 21-05-18, 12:00, ilia...@codeaurora.org wrote: > Final version (addressing Russel's comment as well): Sorry, can't review it like this. At least you should be posting your diff here and you also need to do that from a sane email client like mutt, which wouldn't auto-fix/update the code. Doing

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread Viresh Kumar
On 21-05-18, 12:00, ilia...@codeaurora.org wrote: > Final version (addressing Russel's comment as well): Sorry, can't review it like this. At least you should be posting your diff here and you also need to do that from a sane email client like mutt, which wouldn't auto-fix/update the code. Doing

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread ilialin
ger.kernel.org; linux- > ker...@vger.kernel.org; linux...@vger.kernel.org; linux-arm- > m...@vger.kernel.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; rna...@codeaurora.org; > amit.kuche...@linaro.org; nicolas.deche...@linaro.org; > cels...@codeaurora.org; tfi

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-21 Thread ilialin
gt; ker...@vger.kernel.org; linux...@vger.kernel.org; linux-arm- > m...@vger.kernel.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; rna...@codeaurora.org; > amit.kuche...@linaro.org; nicolas.deche...@linaro.org; > cels...@codeaurora.org; tfin...@codeaurora.org > Subject

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-20 Thread Viresh Kumar
On 19-05-18, 14:45, ilia...@codeaurora.org wrote: > Hi Viresh, > > If I send patches in reply, it will produce new patches, instead of answers > in the thread. Please find below the file dump. There is one email from you which appears to be just fine and appears to be in reply to this thread

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-20 Thread Viresh Kumar
On 19-05-18, 14:45, ilia...@codeaurora.org wrote: > Hi Viresh, > > If I send patches in reply, it will produce new patches, instead of answers > in the thread. Please find below the file dump. There is one email from you which appears to be just fine and appears to be in reply to this thread

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread Russell King - ARM Linux
On Sat, May 19, 2018 at 02:09:24PM +0300, ilia...@codeaurora.org wrote: > +static int __init qcom_cpufreq_kryo_driver_init(void) > +{ > + struct device *cpu_dev_silver, *cpu_dev_gold; > + struct opp_table *opp_silver, *opp_gold; > + enum _msm8996_version msm8996_version; > +

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread Russell King - ARM Linux
On Sat, May 19, 2018 at 02:09:24PM +0300, ilia...@codeaurora.org wrote: > +static int __init qcom_cpufreq_kryo_driver_init(void) > +{ > + struct device *cpu_dev_silver, *cpu_dev_gold; > + struct opp_table *opp_silver, *opp_gold; > + enum _msm8996_version msm8996_version; > +

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
@vger.kernel.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; rna...@codeaurora.org; > amit.kuche...@linaro.org; nicolas.deche...@linaro.org; > cels...@codeaurora.org; tfin...@codeaurora.org > Subject: Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver >

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
t; ker...@lists.infradead.org; rna...@codeaurora.org; > amit.kuche...@linaro.org; nicolas.deche...@linaro.org; > cels...@codeaurora.org; tfin...@codeaurora.org > Subject: Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver > > On 17-05-18, 14:19, Ilia Lin wrote: > > +static

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
...@kernel.org; andy.gr...@linaro.org; david.br...@linaro.org; > catalin.mari...@arm.com; will.dea...@arm.com; r...@rjwysocki.net; linux- > c...@vger.kernel.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux...@vger.kernel.org; linux-arm- > m...@vger.kernel.org; linux-...@vger.ker

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
ernel.org; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux...@vger.kernel.org; linux-arm- > m...@vger.kernel.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; rna...@codeaurora.org; > amit.kuche...@linaro.org; nicolas.deche...@linaro.org;

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
t...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux...@vger.kernel.org; linux-arm- > m...@vger.kernel.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; rna...@codeaurora.org; > amit.kuche...@linaro.org; nicolas.deche...@linaro.org; > cels...@codeaurora.o

RE: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-19 Thread ilialin
-arm- > ker...@lists.infradead.org; rna...@codeaurora.org; > amit.kuche...@linaro.org; nicolas.deche...@linaro.org; > cels...@codeaurora.org; tfin...@codeaurora.org > Subject: Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver > > On 17-05-18, 14:19, Ilia Lin wrote: > &

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread Viresh Kumar
On 17-05-18, 14:19, Ilia Lin wrote: > +static int __init qcom_cpufreq_kryo_driver_init(void) > +{ > + size_t len; > + int ret = 0; > + u32 versions; > + enum _msm8996_version msm8996_version; > + u8 *speedbin; > + struct device *cpu_dev_silver, *cpu_dev_gold; > + struct

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread Viresh Kumar
On 17-05-18, 14:19, Ilia Lin wrote: > +static int __init qcom_cpufreq_kryo_driver_init(void) > +{ > + size_t len; > + int ret = 0; > + u32 versions; > + enum _msm8996_version msm8996_version; > + u8 *speedbin; > + struct device *cpu_dev_silver, *cpu_dev_gold; > + struct

[PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread Ilia Lin
In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, the CPU frequency subset and voltage value of each OPP varies based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables defines the voltage and frequency value based on the msm-id in SMEM and speedbin blown

[PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

2018-05-17 Thread Ilia Lin
In Certain QCOM SoCs like apq8096 and msm8996 that have KRYO processors, the CPU frequency subset and voltage value of each OPP varies based on the silicon variant in use. Qualcomm Process Voltage Scaling Tables defines the voltage and frequency value based on the msm-id in SMEM and speedbin blown