Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 16:46:01 +0100, ayman.baga...@gmail.com wrote: > > > > + priv->cdev.name = "platform::micmute"; > > > + priv->cdev.max_brightness = 1; > > > + priv->cdev.brightness_set_blocking = > > > huawei_wmi_micmute_led_set; > > > + priv->cdev.default_trigger = "audio-micmute"; > > > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 16:46:01 +0100, ayman.baga...@gmail.com wrote: > > > > + priv->cdev.name = "platform::micmute"; > > > + priv->cdev.max_brightness = 1; > > > + priv->cdev.brightness_set_blocking = > > > huawei_wmi_micmute_led_set; > > > + priv->cdev.default_trigger = "audio-micmute"; > > > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread ayman . bagabas
On Mon, 2018-12-03 at 13:00 +0100, Takashi Iwai wrote: > On Fri, 30 Nov 2018 00:57:37 +0100, > Ayman Bagabas wrote: > > This driver adds support for missing hotkeys on some Huawei > > laptops. > > Laptops such as the Matebook X have non functioning hotkeys. > > Whereas > > newer laptops such as

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread ayman . bagabas
On Mon, 2018-12-03 at 13:00 +0100, Takashi Iwai wrote: > On Fri, 30 Nov 2018 00:57:37 +0100, > Ayman Bagabas wrote: > > This driver adds support for missing hotkeys on some Huawei > > laptops. > > Laptops such as the Matebook X have non functioning hotkeys. > > Whereas > > newer laptops such as

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 4:22 PM Takashi Iwai wrote: > On Mon, 03 Dec 2018 15:18:54 +0100, > Andy Shevchenko wrote: > > > > On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai wrote: > > > On Fri, 30 Nov 2018 00:57:37 +0100, > > > Ayman Bagabas wrote: > > > > > > +struct huawei_wmi_priv { > > > > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 4:22 PM Takashi Iwai wrote: > On Mon, 03 Dec 2018 15:18:54 +0100, > Andy Shevchenko wrote: > > > > On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai wrote: > > > On Fri, 30 Nov 2018 00:57:37 +0100, > > > Ayman Bagabas wrote: > > > > > > +struct huawei_wmi_priv { > > > > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Fri, Nov 30, 2018 at 1:58 AM Ayman Bagabas wrote: > +static int huawei_wmi_micmute_led_set(struct led_classdev *led_cdev, > + enum led_brightness brightness) > +{ > + struct huawei_wmi_priv *priv = dev_get_drvdata(led_cdev->dev->parent); > + acpi_status status; > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Fri, Nov 30, 2018 at 1:58 AM Ayman Bagabas wrote: > +static int huawei_wmi_micmute_led_set(struct led_classdev *led_cdev, > + enum led_brightness brightness) > +{ > + struct huawei_wmi_priv *priv = dev_get_drvdata(led_cdev->dev->parent); > + acpi_status status; > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 15:18:54 +0100, Andy Shevchenko wrote: > > On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai wrote: > > On Fri, 30 Nov 2018 00:57:37 +0100, > > Ayman Bagabas wrote: > > > > +struct huawei_wmi_priv { > > > + struct input_dev *idev; > > > + struct led_classdev cdev; > > > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Mon, 03 Dec 2018 15:18:54 +0100, Andy Shevchenko wrote: > > On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai wrote: > > On Fri, 30 Nov 2018 00:57:37 +0100, > > Ayman Bagabas wrote: > > > > +struct huawei_wmi_priv { > > > + struct input_dev *idev; > > > + struct led_classdev cdev; > > > +

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai wrote: > On Fri, 30 Nov 2018 00:57:37 +0100, > Ayman Bagabas wrote: > > +struct huawei_wmi_priv { > > + struct input_dev *idev; > > + struct led_classdev cdev; > > + acpi_handle handle; > > Is this handle set in anywhere? I couldn't see it

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 2:00 PM Takashi Iwai wrote: > On Fri, 30 Nov 2018 00:57:37 +0100, > Ayman Bagabas wrote: > > +struct huawei_wmi_priv { > > + struct input_dev *idev; > > + struct led_classdev cdev; > > + acpi_handle handle; > > Is this handle set in anywhere? I couldn't see it

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Fri, 30 Nov 2018 00:57:37 +0100, Ayman Bagabas wrote: > > This driver adds support for missing hotkeys on some Huawei laptops. > Laptops such as the Matebook X have non functioning hotkeys. Whereas > newer laptops such as the Matebook X Pro come with working hotkeys out > of the box. > > Old

Re: [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-03 Thread Takashi Iwai
On Fri, 30 Nov 2018 00:57:37 +0100, Ayman Bagabas wrote: > > This driver adds support for missing hotkeys on some Huawei laptops. > Laptops such as the Matebook X have non functioning hotkeys. Whereas > newer laptops such as the Matebook X Pro come with working hotkeys out > of the box. > > Old

[PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-29 Thread Ayman Bagabas
This driver adds support for missing hotkeys on some Huawei laptops. Laptops such as the Matebook X have non functioning hotkeys. Whereas newer laptops such as the Matebook X Pro come with working hotkeys out of the box. Old laptops, such as the Matebook X, report hotkey events through ACPI

[PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-29 Thread Ayman Bagabas
This driver adds support for missing hotkeys on some Huawei laptops. Laptops such as the Matebook X have non functioning hotkeys. Whereas newer laptops such as the Matebook X Pro come with working hotkeys out of the box. Old laptops, such as the Matebook X, report hotkey events through ACPI