Re: [PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-12 Thread Bart Van Assche
On 2020-08-12 20:00, Daejun Park wrote: > On 2020-08-06 02:11, Daejun Park wrote: >>> +static int ufshpb_create_sysfs(struct ufs_hba *hba, struct ufshpb_lu *hpb) >>> +{ >>> +int ret; >>> + >>> +ufshpb_stat_init(hpb); >>> + >>> +kobject_init(>kobj, _ktype); >>> +

Re: [PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-12 Thread Daejun Park
Hi Bart, On 2020-08-06 02:11, Daejun Park wrote: > > This is a patch for the HPB feature. > > This patch adds HPB function calls to UFS core driver. > > > > The mininum size of the memory pool used in the HPB is implemented as a > ^^^ > minimum? I will fix it. > > Kconfig

Re: [PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-12 Thread Daejun Park
Hi Bart, On 2020-08-06 02:11, Daejun Park wrote: > > +static void ufshpb_issue_hpb_reset_query(struct ufs_hba *hba) > > +{ > > +int err; > > +int retries; > > + > > +for (retries = 0; retries < HPB_RESET_REQ_RETRIES; retries++) { > > +err = ufshcd_query_flag(hba,

Re: [PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-08 Thread Bart Van Assche
On 2020-08-06 02:11, Daejun Park wrote: > This is a patch for the HPB feature. > This patch adds HPB function calls to UFS core driver. > > The mininum size of the memory pool used in the HPB is implemented as a ^^^ minimum? > Kconfig parameter (SCSI_UFS_HPB_HOST_MEM), so that it

Re: [PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-08 Thread Bart Van Assche
On 2020-08-06 02:11, Daejun Park wrote: > +static void ufshpb_issue_hpb_reset_query(struct ufs_hba *hba) > +{ > + int err; > + int retries; > + > + for (retries = 0; retries < HPB_RESET_REQ_RETRIES; retries++) { > + err = ufshcd_query_flag(hba, UPIU_QUERY_OPCODE_SET_FLAG, >

[PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-06 Thread Daejun Park
This is a patch for the HPB feature. This patch adds HPB function calls to UFS core driver. The mininum size of the memory pool used in the HPB is implemented as a Kconfig parameter (SCSI_UFS_HPB_HOST_MEM), so that it can be configurable. Tested-by: Bean Huo Signed-off-by: Daejun Park ---