Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-13 Thread Ley Foon Tan
On Mon, Oct 12, 2015 at 8:03 PM, Arnd Bergmann wrote: > > On Friday 09 October 2015 18:15:40 Bjorn Helgaas wrote: > > > > I don't know if this should be a kernel taint, a simple warning in > > dmesg, or what. I guess the tainting mechanism is probably too > > general-purpose for this, and

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-13 Thread Ley Foon Tan
On Mon, Oct 12, 2015 at 8:03 PM, Arnd Bergmann wrote: > > On Friday 09 October 2015 18:15:40 Bjorn Helgaas wrote: > > > > I don't know if this should be a kernel taint, a simple warning in > > dmesg, or what. I guess the tainting mechanism is probably too > > general-purpose for

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-12 Thread Arnd Bergmann
On Friday 09 October 2015 18:15:40 Bjorn Helgaas wrote: > > I don't know if this should be a kernel taint, a simple warning in > dmesg, or what. I guess the tainting mechanism is probably too > general-purpose for this, and add_taint() doesn't give any dmesg > indication. We wouldn't see the

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-12 Thread Arnd Bergmann
On Friday 09 October 2015 18:15:40 Bjorn Helgaas wrote: > > I don't know if this should be a kernel taint, a simple warning in > dmesg, or what. I guess the tainting mechanism is probably too > general-purpose for this, and add_taint() doesn't give any dmesg > indication. We wouldn't see the

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-09 Thread Bjorn Helgaas
On Thu, Oct 08, 2015 at 06:03:24PM +0800, Ley Foon Tan wrote: > On Thu, Oct 8, 2015 at 5:47 PM, Russell King - ARM Linux > wrote: > > > > On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > > > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > > > +

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-09 Thread Bjorn Helgaas
On Thu, Oct 08, 2015 at 06:03:24PM +0800, Ley Foon Tan wrote: > On Thu, Oct 8, 2015 at 5:47 PM, Russell King - ARM Linux > wrote: > > > > On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > > > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread kbuild test robot
Hi Ley, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: sparc-allmodconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread kbuild test robot
Hi Ley, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-allmodconfig (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>):

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread Ley Foon Tan
On Thu, Oct 8, 2015 at 5:47 PM, Russell King - ARM Linux wrote: > > On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > > + int where, int size, u32 value) > > +{ > > +

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread Russell King - ARM Linux
On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > + int where, int size, u32 value) > +{ > + struct altera_pcie *pcie = bus->sysdata; > + u32 data32; > + u32 shift =

[PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread Ley Foon Tan
This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan Reviewed-by: Marc Zyngier --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 588 + 3 files changed, 596

[PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread Ley Foon Tan
This patch adds the Altera PCIe host controller driver. Signed-off-by: Ley Foon Tan Reviewed-by: Marc Zyngier --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera.c | 588

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread Russell King - ARM Linux
On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > + int where, int size, u32 value) > +{ > + struct altera_pcie *pcie = bus->sysdata; > + u32 data32; > + u32 shift =

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread Ley Foon Tan
On Thu, Oct 8, 2015 at 5:47 PM, Russell King - ARM Linux wrote: > > On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > > + int where, int size, u32

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread kbuild test robot
Hi Ley, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-allmodconfig (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>):

Re: [PATCH v8 3/6] pci:host: Add Altera PCIe host controller driver

2015-10-08 Thread kbuild test robot
Hi Ley, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: sparc-allmodconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x